RFR: 8357619: [JVMCI] Revisit phantom_ref parameter in JVMCINMethodData::get_nmethod_mirror

Erik Österlund eosterlund at openjdk.org
Thu May 29 13:04:41 UTC 2025


On Wed, 28 May 2025 18:10:39 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> src/hotspot/share/jvmci/jvmciCompilerToVM.cpp line 2834:
>> 
>>> 2832:           // Only the mirror in the HotSpot heap is accessible
>>> 2833:           // through JVMCINMethodData
>>> 2834:           oop nmethod_mirror = data->get_nmethod_mirror(nm);
>> 
>> Is the nmethod guaranteed to be on-stack here? If not it gotta be phantom.
>
> Is the use of `JVMCINMethodHandle` equivalent to `nm` being on-stack?

Yes. Great, so that should be fine then.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25488#discussion_r2112673894


More information about the graal-dev mailing list