RFR: 8353686: Optimize Math.cbrt for x86 64 bit platforms [v4]

[Julian Waters]

On Thu, 29 May 2025 18:52:51 GMT, Mohamed Issa <duke at openjdk.org> wrote:

>> src/hotspot/cpu/x86/stubGenerator_x86_64_cbrt.cpp line 49:
>> 
>>> 47: /******************************************************************************/
>>> 48: 
>>> 49: ATTRIBUTE_ALIGNED(4) static const juint _SIG_MASK[] =
>> 
>> ATTRIBUTE_ALIGNED expands to alignas, I suggest using that directly instead
>
> The ATTRIBUTE_ALIGNED macro is used in other stub generator files. Should all of those be changed to alignas as well? If so, would it best to make those changes in a separate PR?
> 
> Also, is the suggestion to change just for code readability?

There's no need to change the other files, that would be out of scope for this Pull Request. Yes, it's just a suggestion for readability, it can be ignored if you deem it as not necessary.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24470#discussion_r2115174843