RFR: 8357660: [JVMCI] Add Support for Retrieving All Indy BootstrapMethodInvocations directly from the ConstantPool

[Tom Shull]

On Thu, 29 May 2025 13:40:55 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> I updated the javadoc misplaced `@` in `{@code}`. However, the `opcode` doc changes look wrong to me; the opcode must be -1 or INVOKEDYNAMIC (https://github.com/openjdk/jdk/blob/04e0fe00abcf1d7919a50e0c9dd44ce2856984ea/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotConstantPool.java#L592)
>
> yeah, looks like you're right. I was basing my assumption on `case "Dynamic"` in:
> 
>     @Override
>     public BootstrapMethodInvocation lookupBootstrapMethodInvocation(int index, int opcode) {
>         int cpi = opcode == -1 ? index : indyIndexConstantPoolIndex(index, opcode);
>         final JvmConstant tag = getTagAt(cpi);
>         switch (tag.name) {
>             case "InvokeDynamic":
>             case "Dynamic":
> 
> I guess it's possible for an INVOKEDYNAMIC to resolve it's cpi to a CONSTANT_Dynamic entry.

I think INVOKEDYNAMIC should always point to a CONSTANT_InvokeDynamic entry

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25420#discussion_r2114794800