RFR: 8327963: C2: fix construction of memory graph around Initialize node to prevent incorrect execution if allocation is removed [v17]

Roland Westrelin roland at openjdk.org
Tue Nov 4 08:35:52 UTC 2025


On Tue, 4 Nov 2025 07:17:02 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/opto/memnode.hpp line 1418:
> 
>> 1416:     }
>> 1417:     return res->as_NarrowMemProj();
>> 1418:   }
> 
> Nit, optional: Could we not remove some fluff here with a `isa_NarrowMemProj`? You would not have to check for `res == nullptr`.

I don't think we can. Wouldn't we have to call a method on a possibly `null` res?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24570#discussion_r2489235039


More information about the graal-dev mailing list