RFR: 8372098: Move AccessFlags to InstanceKlass
Coleen Phillimore
coleenp at openjdk.org
Tue Nov 18 18:55:03 UTC 2025
On Tue, 18 Nov 2025 18:15:40 GMT, ExE Boss <duke at openjdk.org> wrote:
>> ArrayKlass doesn't set AccessFlags so don't look for them there. See CR for details.
>> Fixed SA and jvmci. @iwanowww Can you check that I changed C2 correctly (we talked about this in August).
>> Tested with tier1-4. 5-7 in progress.
>
> src/hotspot/share/classfile/classFileParser.cpp line 815:
>
>> 813: interface_index, CHECK);
>> 814: if (cp->tag_at(interface_index).is_klass()) {
>> 815: interf = InstanceKlass::cast(cp->resolved_klass_at(interface_index));
>
> Note that a resolved `CONSTANT_Class` can refer to an array type, so this cast is incorrect.
There are a bunch of tests that we don't have. This would be an error since Interfaces are never arrays, but that's checked later. I'll revert some of these casts (as well as try to write a test for this).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28371#discussion_r2539318553
More information about the graal-dev
mailing list