RFR: 8372098: Move AccessFlags to InstanceKlass [v2]

[Coleen Phillimore]

On Tue, 18 Nov 2025 20:02:09 GMT, Chen Liang <liach at openjdk.org> wrote:

>> There are a bunch of tests that we don't have. This would be an error since Interfaces are never arrays, but that's checked later.  I'll revert some of these casts (as well as try to write a test for this).
>
> I thought the cast at line 839 would have handled this. Turns out it has a `!interf->is_interface()` check before so this cast is problematic.

There's a reason this isn't tested.  The constant pool reference for JVM_CONSTANT_Class is tested to be resolved at line 814 and because it's an interface, it's not easy to be resolved by this point (unless it's a duplicate class in which case it will be an InstanceKlass).  The array case goes through the else part of this and throws a ClassFormatError.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28371#discussion_r2539645039