RFR: 8347248: Fingerprinter::size_of_parameters() should not be used for getting number of parameters

Matias Saavedra Silva matsaave at openjdk.org
Tue Nov 18 22:24:11 UTC 2025


On Tue, 18 Nov 2025 22:16:18 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/oops/method.cpp line 736:
>> 
>>> 734:   for (SignatureStream ss(signature()); !ss.at_return_type(); ss.next()) {
>>> 735:     count++;
>>> 736:   }
>> 
>> Shouldn't we do this at construction time and store into a field and return that here?
>
> That would increase footprint. It looks like we don't need this function after all.

Oops I forgot to push the commit that caches this value

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28380#discussion_r2539805680


More information about the graal-dev mailing list