RFR: 8347248: Fingerprinter::size_of_parameters() should not be used for getting number of parameters

Vladimir Kozlov kvn at openjdk.org
Fri Nov 21 01:28:23 UTC 2025


On Wed, 19 Nov 2025 17:53:10 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> So it looks like the use of "arg" here refers to "arg slot" meaning these variables and methods could be renamed to be more clear. What do you think of renaming methods like `arg_modified` to `arg_slot_modified`?
>
> I think it's OK to rename `arg_count` to `arg_size`. There's quite a lot of existing code that does this. `arg_size` is understood to be the "number of slots". 
> 
> https://github.com/openjdk/jdk/blob/9ea8201b7494fe9107d4abd78c02ac765a5751d4/src/hotspot/share/opto/graphKit.cpp#L2365-L2366
> 
> https://github.com/openjdk/jdk/blob/9ea8201b7494fe9107d4abd78c02ac765a5751d4/src/hotspot/share/ci/bcEscapeAnalyzer.cpp#L192-L196
> 
> I am not sure about adding "slot" to "arg_modified". While there are some use of the word "slot" in the compiler APIs, it's not common.

I vote for `size_of_args` suggested by Dean. I would rename local variable too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28380#discussion_r2548222005


More information about the graal-dev mailing list