RFR: 8371820: Further AES performance improvements for key schedule generation [v5]

[Shawn M Emery]

On Mon, 24 Nov 2025 17:00:04 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> This fix simplifies the hotspot intrinsics for some platforms and optimizes the key computation for encryption. We can save the `genInvRoundKeys` computation when we only do encryption.
>> 
>> The micro:org.openjdk.bench.javax.crypto.AESReinit benchmark results are improved by 17% for ppc64 and 26% for x86_64.
>
> Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Address review comments.
>  - Merge remote-tracking branch 'origin' into 8371820_AES_Crypt
>  - Remove K from AES_Crypt
>  - More minor cleanup.
>  - Improve comment and minor cleanup.
>  - 8371820: Further AES performance improvements for key schedule generation

The internal testing came back clean and performed AESReinit benchmarks on aarch64, where a 8.9% performance gain was observed with the complete set of changes!

-------------

Marked as reviewed by smemery at github.com (no known OpenJDK username).

PR Review: https://git.openjdk.org/jdk/pull/28299#pullrequestreview-3508635701