RFR: 8344116: C2: remove slice parameter from LoadNode::make [v8]

Zihao Lin duke at openjdk.org
Wed Nov 26 08:36:09 UTC 2025


On Wed, 5 Nov 2025 13:20:26 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Zihao Lin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>> 
>>  - fix assert
>>  - add more assert
>>  - rid of access.addr().type()
>>  - Merge branch 'openjdk:master' into 8344116
>>  - Merge branch 'openjdk:master' into 8344116
>>  - Merge branch 'openjdk:master' into 8344116
>>  - Fix build
>>  - Fix test failed
>>  - 8344116: C2: remove slice parameter from LoadNode::make
>
> Can we remove `C2AccessValuePtr`  entirely and use:
> 
> Node* _addr;
> 
> where, currently, there's:
> 
> C2AccessValuePtr& _addr;
> 
> ?

Hi @rwestrel , I removed C2AccessValuePtr, Could you please take a look, thank you.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24258#issuecomment-3580115736


More information about the graal-dev mailing list