RFR: 8344116: C2: remove slice parameter from LoadNode::make [v13]

[Roland Westrelin]

On Mon, 24 Nov 2025 15:46:20 GMT, Zihao Lin <duke at openjdk.org> wrote:

>> This patch remove slice parameter from LoadNode::make
>> 
>> I have done more work which remove slice paramater from StoreNode::make.
>> 
>> Mention in https://github.com/openjdk/jdk/pull/21834#pullrequestreview-2429164805
>> 
>> Hi team, I am new, I'd appreciate any guidance. Thank a lot!
>
> Zihao Lin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix test failed

Changes requested by roland (Reviewer).

src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp line 720:

> 718:     if (ShenandoahCardBarrier) {
> 719:       post_barrier(kit, kit->control(), access.raw_access(), access.base(),
> 720:                    access.addr(), access.alias_idx(), new_val, T_OBJECT, true);

`access.alias_idx()` should be `C->get_alias_index(kit.gvn().type(access.addr()))`

So I think we want to remove `uint  _alias_idx;` from `C2AtomicParseAccess` as well. This could be done as a follow up if you think this change has already gotten too complicated.

src/hotspot/share/opto/escape.cpp line 4488:

> 4486:           const TypePtr* adr_type = proj->adr_type();
> 4487:           const TypePtr* new_adr_type = tinst->add_offset(adr_type->offset());
> 4488:           if (adr_type != new_adr_type) {

Can you explain that change? Did something go wrong in a merge?

src/hotspot/share/opto/graphKit.cpp line 1703:

> 1701:                                              BasicType bt,
> 1702:                                              DecoratorSet decorators) {
> 1703:   C2AccessValuePtr addr(adr, adr_type);

`adr_type` no longer used in this and next methods.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24258#pullrequestreview-3514352600
PR Review Comment: https://git.openjdk.org/jdk/pull/24258#discussion_r2567870138
PR Review Comment: https://git.openjdk.org/jdk/pull/24258#discussion_r2567854115
PR Review Comment: https://git.openjdk.org/jdk/pull/24258#discussion_r2567875036