RFR: 8354282: C2: more crashes in compiled code because of dependency on removed range check CastIIs [v3]

[Roland Westrelin]

On Wed, 23 Apr 2025 10:56:51 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - review
>>  - infinite loop in gvn fix
>>  - renaming
>
> @rwestrel thanks for looking into this one!
> 
> I have not yet deeply studied the PR, but am feeling some confusion about the naming.
> 
> I think the `DependencyType` is really a good step into the right direction, it helps clean things up.
> 
> I'm wondering if we should pick either `depends_only_on_test` or `pinned`, and use it everywhere consistently. Having both around as near synonymes (antonymes?) is a bit confusing for me.
> 
> I'll look into the code more later.

I pushed an update with the renaming suggested by @eme64 and an extra comment with example use cases

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24575#issuecomment-3360011105