RFR: 8303762: Optimize vector slice operation with constant index using VPALIGNR instruction [v8]
erifan
duke at openjdk.org
Tue Oct 7 05:49:50 UTC 2025
On Thu, 25 Sep 2025 08:52:09 GMT, erifan <duke at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update callGenerator.hpp copyright year
>
> test/hotspot/jtreg/compiler/vectorapi/TestSliceOptValueTransforms.java line 45:
>
>> 43: public static final VectorSpecies<Short> SSP = ShortVector.SPECIES_PREFERRED;
>> 44: public static final VectorSpecies<Integer> ISP = IntVector.SPECIES_PREFERRED;
>> 45: public static final VectorSpecies<Long> LSP = LongVector.SPECIES_PREFERRED;
>
> The implementation supports floating point types, but why doesn't the test include fp types?
It might be better to consider **partial cases**. I looked at the aarch64 situation and found that different implementations are needed for partial and non-partial cases. The test indices in `test/jdk/jdk/incubator/vector/` are randomly generated, so it might be better to test different vector species here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24104#discussion_r2409431981
More information about the graal-dev
mailing list