RFR: 8367689: Revert removal of several compilation-related vmStructs fields [v2]

Francesco Andreuzzi fandreuzzi at openjdk.org
Wed Sep 17 08:43:06 UTC 2025


On Wed, 17 Sep 2025 08:28:53 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Francesco Andreuzzi has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - note
>>  - nn
>>  - nn
>>  - cc
>>  - nn
>>  - nn
>
> src/hotspot/share/runtime/vmStructs.cpp line 670:
> 
>> 668:                                                                                                                                      \
>> 669:   /**************/                                                                                                                   \
>> 670:   /* CI (NOTE: these fields should not be removed, they can be used by external tools) */                                            \
> 
> Can you also clarify what "external tools" are in the comment so that when/if those external tools stop using them, we can re-evaluate?

Do you mean I should explicitly mention Async-Profiler?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27318#discussion_r2354766869


More information about the graal-dev mailing list