[OpenJDK Rasterizer] [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

[Laurent Bourgès]

Phil,

Thanks for your feedback !

2015-03-06 20:06 GMT+01:00 Phil Race <philip.race at oracle.com>:

> Hi,
>
> you placed the test in the java.awt.geom package.
>
>   25 package java.awt.geom;
>
> and are accessing internals of that package.
>
> In jigsaw/modular mode that won't even compile.
>

Ok it is annoying:
as all Path2D fields are package protected, I designed the test using
direct access to any fields ...


> So the test should go in the anonymous package and avoid accessing
> internals.
> It should be possible to use just public API  to verify the arrays  of a
> shape
> being cloned are trimmed .
>

No, it is not possible to use Shape API to access arrays nor fields
(numTypes ...):
only getPathIterator() could give me data but it won't tell me if the
underlying arrays or fields are correct.

Maybe I could use introspection to getDeclaredField(name) and
setAccessible(true) to get internal data.

Any idea or utility class I could use ?


>
> Why is it necessary to explicitly add the call to super(); ?
>
> 223             super();
>

I agree it is not necessary but it explicitely says that I use the empty
constructor:

    /**
     * Constructs a new empty {@code Path2D} object.
     * It is assumed that the package sibling subclass that is
     * defaulting to this constructor will fill in all values.
     *
     * @since 1.6
     */
    /* private protected */
    Path2D() {
    }

Laurent
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/graphics-rasterizer-dev/attachments/20150306/ce6b5a38/attachment.html>