[OpenJDK Rasterizer] Marlin renderer contribution for review

Laurent Bourgès bourges.laurent at gmail.com
Tue Mar 17 21:47:55 UTC 2015


Jim,

I updated my local copy and made a full clean & build.

I fixed a bug at line 69 in MarlinRenderingEngine.java related to recent
Path2D changes:

+                (rdrCtx.p2d = new Path2D.Float(Path2D.WIND_NON_ZERO,
+                                               INITIAL_MEDIUM_ARRAY))

Here is the new webrev:
http://cr.openjdk.java.net/~lbourges/marlin/marlin.2/

All pisces tests passed (manually run):

bourgesl at bourgesl-HP-ZBook-15:/home/graphics-rasterizer/jdk9/jdk/test/sun/java2d/pisces$
java -version
openjdk version "1.9.0-internal"
OpenJDK Runtime Environment (build
1.9.0-internal-bourgesl_2015_03_17_22_09-b00)
OpenJDK 64-Bit Server VM (build
1.9.0-internal-bourgesl_2015_03_17_22_09-b00, mixed mode)

bourgesl at bourgesl-HP-ZBook-15:/home/graphics-rasterizer/jdk9/jdk/test/sun/java2d/pisces$
ls *.java
OpenJDKFillBug.java  Test7036754.java
bourgesl at bourgesl-HP-ZBook-15:/home/graphics-rasterizer/jdk9/jdk/test/sun/java2d/pisces$
java -Dsun.java2d.renderer=sun.java2d.marlin.MarlinRenderingEngine
Test7036754
INFO:
===============================================================================
INFO: Marlin software rasterizer           = ENABLED
INFO: Version                              = [marlin-0.5.6-Unsafe-OpenJDK]
INFO: sun.java2d.renderer                  =
sun.java2d.marlin.MarlinRenderingEngine
INFO: sun.java2d.renderer.useThreadLocal   = false
INFO: sun.java2d.renderer.useRef           = soft
INFO: sun.java2d.renderer.pixelsize        = 2048
INFO: sun.java2d.renderer.subPixel_log2_X  = 3
INFO: sun.java2d.renderer.subPixel_log2_Y  = 3
INFO: sun.java2d.renderer.tileSize_log2    = 5
INFO: sun.java2d.renderer.useFastMath      = true
INFO: sun.java2d.renderer.useSimplifier    = false
INFO: sun.java2d.renderer.doStats          = false
INFO: sun.java2d.renderer.doMonitors       = false
INFO: sun.java2d.renderer.doChecks         = false
INFO: sun.java2d.renderer.useJul           = false
INFO: sun.java2d.renderer.logCreateContext = false
INFO: sun.java2d.renderer.logUnsafeMalloc  = false
INFO:
===============================================================================

bourgesl at bourgesl-HP-ZBook-15:/home/graphics-rasterizer/jdk9/jdk/test/sun/java2d/pisces$
java -Dsun.java2d.renderer=sun.java2d.marlin.MarlinRenderingEngine
OpenJDKFillBug
INFO:
===============================================================================
INFO: Marlin software rasterizer           = ENABLED
INFO: Version                              = [marlin-0.5.6-Unsafe-OpenJDK]
INFO: sun.java2d.renderer                  =
sun.java2d.marlin.MarlinRenderingEngine
INFO: sun.java2d.renderer.useThreadLocal   = false
INFO: sun.java2d.renderer.useRef           = soft
INFO: sun.java2d.renderer.pixelsize        = 2048
INFO: sun.java2d.renderer.subPixel_log2_X  = 3
INFO: sun.java2d.renderer.subPixel_log2_Y  = 3
INFO: sun.java2d.renderer.tileSize_log2    = 5
INFO: sun.java2d.renderer.useFastMath      = true
INFO: sun.java2d.renderer.useSimplifier    = false
INFO: sun.java2d.renderer.doStats          = false
INFO: sun.java2d.renderer.doMonitors       = false
INFO: sun.java2d.renderer.doChecks         = false
INFO: sun.java2d.renderer.useJul           = false
INFO: sun.java2d.renderer.logCreateContext = false
INFO: sun.java2d.renderer.logUnsafeMalloc  = false
INFO:
===============================================================================
INFO: AAShapePipe: overriding JDK implementation: marlin-renderer TILE
patch enabled.
Test passed

bourgesl at bourgesl-HP-ZBook-15:/home/graphics-rasterizer/jdk9/jdk/test/sun/java2d/pisces/Renderer$
ls *.java
Test7019861.java  TestNPE.java

bourgesl at bourgesl-HP-ZBook-15:/home/graphics-rasterizer/jdk9/jdk/test/sun/java2d/pisces/Renderer$
java -Dsun.java2d.renderer=sun.java2d.marlin.MarlinRenderingEngine
Test7019861
INFO:
===============================================================================
INFO: Marlin software rasterizer           = ENABLED
INFO: Version                              = [marlin-0.5.6-Unsafe-OpenJDK]
INFO: sun.java2d.renderer                  =
sun.java2d.marlin.MarlinRenderingEngine
INFO: sun.java2d.renderer.useThreadLocal   = false
INFO: sun.java2d.renderer.useRef           = soft
INFO: sun.java2d.renderer.pixelsize        = 2048
INFO: sun.java2d.renderer.subPixel_log2_X  = 3
INFO: sun.java2d.renderer.subPixel_log2_Y  = 3
INFO: sun.java2d.renderer.tileSize_log2    = 5
INFO: sun.java2d.renderer.useFastMath      = true
INFO: sun.java2d.renderer.useSimplifier    = false
INFO: sun.java2d.renderer.doStats          = false
INFO: sun.java2d.renderer.doMonitors       = false
INFO: sun.java2d.renderer.doChecks         = false
INFO: sun.java2d.renderer.useJul           = false
INFO: sun.java2d.renderer.logCreateContext = false
INFO: sun.java2d.renderer.logUnsafeMalloc  = false
INFO:
===============================================================================
INFO: AAShapePipe: overriding JDK implementation: marlin-renderer TILE
patch enabled.

bourgesl at bourgesl-HP-ZBook-15:/home/graphics-rasterizer/jdk9/jdk/test/sun/java2d/pisces/Renderer$
java -Dsun.java2d.renderer=sun.java2d.marlin.MarlinRenderingEngine TestNPE
INFO:
===============================================================================
INFO: Marlin software rasterizer           = ENABLED
INFO: Version                              = [marlin-0.5.6-Unsafe-OpenJDK]
INFO: sun.java2d.renderer                  =
sun.java2d.marlin.MarlinRenderingEngine
INFO: sun.java2d.renderer.useThreadLocal   = false
INFO: sun.java2d.renderer.useRef           = soft
INFO: sun.java2d.renderer.pixelsize        = 2048
INFO: sun.java2d.renderer.subPixel_log2_X  = 3
INFO: sun.java2d.renderer.subPixel_log2_Y  = 3
INFO: sun.java2d.renderer.tileSize_log2    = 5
INFO: sun.java2d.renderer.useFastMath      = true
INFO: sun.java2d.renderer.useSimplifier    = false
INFO: sun.java2d.renderer.doStats          = false
INFO: sun.java2d.renderer.doMonitors       = false
INFO: sun.java2d.renderer.doChecks         = false
INFO: sun.java2d.renderer.useJul           = false
INFO: sun.java2d.renderer.logCreateContext = false
INFO: sun.java2d.renderer.logUnsafeMalloc  = false
INFO:
===============================================================================

PS: I will implement soon the discussed Path2D Test for the trimmed copy
constructor !

Regards,
Laurent
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/graphics-rasterizer-dev/attachments/20150317/585970ff/attachment-0001.html>


More information about the graphics-rasterizer-dev mailing list