[OpenJDK Rasterizer] Marlin renderer contribution for review

[Laurent Bourgès]

Jim,

I looked quickly the Renderer code and it is not obvious to ensure values
are positive.

Let's keep it as it is now as it is tested and fast enough.

However I would like to improve quality too and you have the experience and
knowledge to help me when I am lost in the details.

Thanks a lot

Laurent

Le 19 mars 2015 21:16, "Jim Graham" <james.graham at oracle.com> a écrit :
>
> The only "gotcha" with this technique is that the rendering inner loop
should really use "ceil(x,y - 0.5)" to properly compute the shape
insideness rule and that would mean that using an integer cast would
require negative values to get the ceil() effect...
>
>                         ...jim
>
>
> On 3/19/15 10:21 AM, Laurent Bourgčs wrote:
>>
>> Jim,
>>
>>>> I use FastMath mainly to handle boundaries and coordinates can be
either
>>>> positive or negative ... so I do not have the choice to deal with
>>>> negative values !
>>>
>>>
>>>
>>> That's probably true for normalization then.  For the rendering part,
we could carefully constrain our values so that they are always positive or
negative since we have a target clip to render relative to.
>>
>>
>> Good catch: I will test using int cast in the renderer code : only
>> positive !
>>
>> Laurent
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/graphics-rasterizer-dev/attachments/20150319/ef91c4fa/attachment-0001.html>