[OpenJDK Rasterizer] Marlin renderer contribution for review

dalibor topic dalibor.topic at oracle.com
Mon Mar 23 16:14:04 UTC 2015


I took a look at the webrev, and I have no objections, other than that 
src/java.desktop/share/classes/sun/java2d/marlin/FastMath.java seems to 
be based off third party code with an unknown license.

So that class should be removed in the next iteration.

It may be worth filing a bug to optimize Math.* performance in general 
with respect to known classes of inputs instead. Alternatively, 
StrictMath versions of these methods should be in pure Java, and avoid 
the JNI invocation penalty, so could be worth a try as well.

cheers,
dalibor topic

On 19.03.2015 00:25, Laurent Bourgès wrote:
> Jim,
>
> Here is the new webrev:
> http://cr.openjdk.java.net/~lbourges/marlin/marlin.3/
>
> Changes:
> - discussed changes in Dasher, Stroker, TransformingPathConsumer2D
> - indentation, line breaks (continuation lines)
> - revert many float suffix in math operations (useless ? does the
> compiler make conversions ?)
>
> Hope it looks better ...
>
> Good night,
> Laurent

-- 
<http://www.oracle.com> Dalibor Topic | Principal Product Manager
Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961
<tel:+491737185961>

ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher

<http://www.oracle.com/commitment> Oracle is committed to developing
practices and products that help protect the environment


More information about the graphics-rasterizer-dev mailing list