[OpenJDK Rasterizer] Marlin renderer contribution for review

Laurent Bourgès bourges.laurent at gmail.com
Sun Mar 29 14:45:41 UTC 2015


Hi Jim,

Here is the new webrev:
http://cr.openjdk.java.net/~lbourges/marlin/marlin.6/

> Just some minor stuff this time...

Great news !

> MarlinRenderingEngine.java:
>
> line 378 - my eye just caught this.  "between the stroker and Dasher"? It
looks like this is going between the stroking engine and the Renderer, no?

Right, I fixed that comment.

> MarlinUtils.java:
>
> the getCallerInfo stuff may eventually need to be in a doPrivileged
context, but we don't need to deal with that now.

No need like other jdk classes I looked at.

> Renderer.java:
>
> lines 46-50 - something looks off on the indentation there

Fixed.

> line 53 - I believe that getUnsafe() would need a doPrivileged as well

No need neither.

> lines 1385-1400 - lots of indentation issues

Done.

I spent a lot of my spare time up to now and I expect it is now time to let
marlin go into the graphics repository ...

Cheers,
Laurent
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/graphics-rasterizer-dev/attachments/20150329/b11149d6/attachment.html>


More information about the graphics-rasterizer-dev mailing list