[OpenJDK Rasterizer] Marlin #4

[Jim Graham]

Hi Laurent,

That is my number one focus this week, including doing a test build with 
it and running my own tests.

The big fly in the ointment, though, is that I've recently hosed my JDK 
build environment for Windows (I normally work on the FX source and only 
rarely build the JDK sources) and I'm working hard in restoring it... :(

			...jim

On 11/11/15 2:51 AM, Laurent Bourgès wrote:
> Jim,
>
> Just a reminder: could you review the last marlin patch 4.2 (10/19) ?
>
>> >> 1. Do you prefer I send you another webrev including my last changes ?
>> >
>> >
>> > Let me look through the latest webrev first.
>>
>> Ok. FYI new changes are very small.
>
> If you want, I can send you an up-to-date webrev including few
> improvements but also jdk9 & modifier fixes and the new crash test.
>
>>
>> I started writing the CrashTest class testing several corner cases with huge images & paths to force growable arrays to resize all but also testing the 2gb  overflow on the  offheap edge array.
>>
>> Of course some integer overflow checks are still missing but now Marlin passes that test although ductus fails.
>
>> >> What is the plan according to you ?
>> >
>> >
>> > We can integrate at any point now I think. The main advantage of holding off is that there is less bureaucracy to get changes in, but when we have to coordinate via email I don't think the added burden of having to submit bugs for everything that we fix matters much anyway so that's a moot point for this effort.
>>
>> Agreed but there is few time left.
>> Will you push J2dBench change soon ?
>
> Any news ?
> Should we ask to postpone the integration deadline (11/27) ?
>
>> >> Could you merge gr forrest with latest jdk9 forrest ?
>> >
>> >
>> > I'll take care of that shortly.
>>
>> Great !
>> I will then fix Marlin to use the new jdk.internal.Unsafe and maybe we could use the new  Objects.rangecheck () methods ?
>
> Maybe you should synchronize the repository again to let me fix marlin
> with recent jdk changes (Unsafe...).
>
>> >
>> >> Do you need me to perform some cleanup (system properties, code
>> >> formatting like modifiers ...) before pushing marlin into jdk9 ?
>> >
>> >
>> > I can deal with most of that if you are out of time in the short term.
>>
>> That would be great.
>> Please could you also enable Marlin as the default rasterizer ? So SQE tests will use it with its default settings.
>
> Any progress ?
>
> Cheers,
> Laurent
>