[OpenJDK Rasterizer] Marlin #4

[Jim Graham]

Hi Laurent,

I ran a bunch of tests on 4.2 and saw no issues and the performance 
looked good.  There were still some things that Ductus was faster on, 
but I just did a brief run of a few tests I cobbled together so I don't 
know how representative they are.  Marlin beat Ductus on a number of 
tests as well, so they are right there fighting neck and neck.  I was 
using the defaults which have the RLE code turned off I believe, so 
maybe I wasn't running it in its fastest configuration?

I'm code reading now:

ArrayCache.java, line 205 - should that be needSize there?  Also, should 
these tests be > or >=?

MarlinCache.java, line 181 - in the comment, shouldn't those be maxx and 
minx?

Renderer.java, line 1446 - initial value of useBlkFlags will be false if 
heuristics is enabled
Renderer.java, line 1329 - we send a row to the cache before we update 
heuristics at line 1332
- taken together that means that with heuristics the very first cache 
line sent out will always be non-RLE?

None of those are blocking so I'm going to go through with pushing this 
to the sandbox under your ID, then follow it up with a small cleanup:

- blessed modifier order script
- switch to new jdk.internal.misc.Unsafe class
- turning off verbose
- switch default renderer to Marlin
- add RenderingEngine flag to print out RenderingEngine class chosen 
(-Dsun.java2d.renderer.verbose=true)

Then I'll generate a webrev against the client JDK and send that out for 
review to the 2D list...

			...jim

On 10/19/15 7:06 AM, Laurent Bourgès wrote:
> Hi Jim,
>
> Here is the new webrev:
> http://cr.openjdk.java.net/~lbourges/marlin/marlin-s4.2/