[OpenJDK Rasterizer] Fix Overflow in Marlin ArrayCache

Laurent Bourgès bourges.laurent at gmail.com
Fri Nov 27 11:42:34 UTC 2015


Hi,

Here is a new webrev that fix the Renderer usage of getNewLargeSize() as
the overflow check fails due to integer maths:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-s6.1/

Patched line:

             final long edgeNewSize =
ArrayCache.getNewLargeSize(_edges.length,-
           edgePtr + _SIZEOF_EDGE_BYTES);+
           ((long)edgePtr) + _SIZEOF_EDGE_BYTES);


The CrashTest passes again after the fix (automated tests are very cool) !

Laurent

2015-11-27 12:18 GMT+01:00 Laurent Bourgès <bourges.laurent at gmail.com>:

> Hi Jim,
>
> Here is a simple fix on potential overflow in ArrayCache.getNewLargeSize()
> discussed during Marlin integration:
> http://cr.openjdk.java.net/~lbourges/marlin/marlin-s6.0/
>
> I added the ArrayCacheSizeTest class which now passes in jtreg.
>
> Could you create a bug, I am not sure what I should fill in the form ?
>
> Laurent
>



-- 
-- 
Laurent Bourgès
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/graphics-rasterizer-dev/attachments/20151127/2aa83bc4/attachment.html>


More information about the graphics-rasterizer-dev mailing list