[OpenJDK Rasterizer] Marlin #4

[Jim Graham]

Hi Laurent,

Sorry it took me so long to get around to this...

MarlinConst.java, line 86 - "+2 explain"?

MarlinProperties.java - indentation on && continuations should be 4 
spaces and/or line up the operands (as in:
     return isEnableRLE() &&
            isSomethingElse...;
OR
     return isEnableRLE()
         && isSomethingElse...;
)

Renderer.java - edgeNewSize - why did this use to be long and why 
downgrade to int now?

Renderer.java - tosubpix() - did removing static help?

Renderer.java, line 1057,1163 - for the case of producing -1 or 0 from 
the sign bit, you could use:
      ((err >> 31) << 1)

Renderer.java, line 1288,1350 - don't you need to mark tile for 
(pix_x+1) in case it is a new tile?

Renderer.java, line 1308,1370 - don't you need to mark all tiles from x0 
to x1?

TransformingPC2D - why make all the inner classes private?  I'm wary of 
private for inner classes because sometimes it forces the compiler to 
insert internal accessor methods for methods which are "semantically 
accessible" according to the rules of inner classes, but the standard 
inter-class access was marked private.

I'm still reviewing the new RLE stuff, but wanted to get this much out 
there for now.

A couple of inline comments below...

On 9/10/15 3:53 PM, Laurent Bourgès wrote:
> Jim,
>
> Here is the first webrev improving copyAARow() on large shapes (pixel
> loops):
> http://cr.openjdk.java.net/~lbourges/marlin/marlin-s4.0/
>
> I advocate it is not yet completly ready (cleanup, log statement) but I
> wanted to show the new algorithm & variants:
> copyAARow uses now 4 variants:
> - RLE encoding or uncompress alpha values
> - Both can use block flags to only process small touched pixel blocks
> (like tiles but only 1D) that boosts simple but large shapes !

Whoops, I guess I reviewed the wrong stuff (all the glue rather than the 
RLE algorithms themselves - D'oh!).

> Please give me your first comments (overview).
>   I tested them with my regression tests and all variants are now OK.
>
>
> Here are few results on my machine:

Unfortunately, the giant tables of numbers came through on my end as 
just a mish-mosh of digits in confusing columns.  Can you summarize or 
try to express it as a smaller ascii table or a real HTML <TABLE>?

			...jim