RFR: Added section for newcomers [v8]

Magnus Ihse Bursie ihse at openjdk.java.net
Thu Dec 3 13:29:03 UTC 2020


On Thu, 3 Dec 2020 13:10:02 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added text about API changes
>
> src/index.md line 35:
> 
>> 33: ### 2. Socialize your change
>> 34: 
>> 35: Once the OCA is signed, please restrain your urge to create a PR just a little while longer. In order to prepare the community for your patch, please socialize your idea on the relevant [mailing lists](#mailing-lists). Almost all changes, and in particular any API changes, must go this route and have a broad agreement in place before there is any point in presenting code. To understand the criteria by which your patch is going to be judged, please read [_Why is My Change Rejected?_](#why-is-my-change-rejected) below. In short, hidden constraints and assumptions, stability and quality, maintainability, compatibility, and conformance to specifications must be considered before your PR is ready to be submitted. If you don't understand the constraints for acceptance, you might be surprised when your PR is rejected.
> 
> Thanks for the update. One small suggestion is to say "proposals for new APIs" rather than "any API change".

That seems like it narrows down the criteria. Maybe Random J Hacker only wants to add a getFronglified() to java.lang.String -- since that is not a new API, he does not think it necessary to discuss it first..?

I'd say keep it as it is; it's better to send one too many to the mailing list rather than one too few.

And also, it's better to actually get this document out to the public. We can refine it iteratively if we discover that people misunderstand it.

-------------

PR: https://git.openjdk.java.net/guide/pull/38


More information about the guide-dev mailing list