RFR: Filing bug, ProblemListing, Backing out [v2]

Jesper Wilhelmsson jwilhelm at openjdk.java.net
Mon Jul 6 21:46:26 UTC 2020


On Mon, 6 Jul 2020 20:04:26 GMT, Phil Race <prr at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed comments from review
>
> src/next.md line 149:
> 
>> 148:
>> 149: The backout is a regular change and will have to go through the standard code review process, but is considered a
>> trivial change and thus it requires only one Reviewer and will avoid the 24h code review window, even for areas where
>> stricter rules usually applies. The rationale is that a backout is usually urgent in nature and the change itself is
>> automatically created by hg, and reviewed by the person who is performing the backout, so even though only one
>> additional Reviewer is required the change will in practice get two reviews. 150:
> 
> where is the 24h code review window discussed ?
> It might be a sensible policy for non-urgent fixes but I've never seen it documented/codified and we've never had it as
> a rule in the client area.

That text hasn't been written yet. The 24h-rule is in use in the VM. I don't know if any other area use this rule. It
doesn't apply to urgent fixes. Once we write that text it should specify if there are differences between areas.
Whether it's needed or not depends, I guess, on how distributed the active area developers are over timezones.

-------------

PR: https://git.openjdk.java.net/guide/pull/21


More information about the guide-dev mailing list