RFR: Updated section on Code Conventions. [v4]

Jesper Wilhelmsson jwilhelm at openjdk.java.net
Thu Jun 25 15:28:56 UTC 2020


On Thu, 25 Jun 2020 08:36:12 GMT, Andreas Lundblad <github.com+5994243+aioobe at openjdk.org> wrote:

>> Pull request for adding code conventions.
>> 
>> The code conventions in this pull request is a verbatim copy of [3]. These conventions were the ones discussed in
>> detail on discuss at openjdk.java.net in 2015. Two rounds of reviews were performed, [1] [2], and all comments were
>> addressed. The 6th and last draft [3] has been stable since then, and been in use by several OpenJDK projects.  [1]
>> http://mail.openjdk.java.net/pipermail/discuss/2015-August/003766.html [2]
>> http://mail.openjdk.java.net/pipermail/discuss/2015-August/003771.html [3]
>> http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html
>
> Andreas Lundblad has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Changed from 1. to #. in a few ordered lists.
>  - Added an empty line to separate text from list.

Getting close now ��
But I would like to hear back from Mark on our questions in this thread before approving.

src/javaStyleGuide.md line 4:

> 3: ::: {.NavBit}
> 4: [« Previous](mailinglists.html) • [TOC](index.html) ��� [Next »](changePlanning.html)
> 5: :::

I think previous should go to codeConventions.html. Same at the bottom of this file.

src/hgHelp.md line 6:

> 5: :::
> 6:
> 7: >     $ hg help

Good catch!  Thanks for cleaning this up as well!

-------------

PR: https://git.openjdk.java.net/guide/pull/14


More information about the guide-dev mailing list