From jesper.wilhelmsson at oracle.com Fri May 8 15:49:46 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Fri, 8 May 2020 17:49:46 +0200 Subject: PR #1: Populating the repo with the old html guide files Message-ID: Hi. I created a pull request in the new github repo to populate it with the old guide files so that we have a starting point. The files are unmodified except for three cases where I removed text that concerned Oracle-internal process. The modified files are changePlanning.html, codeReview.html, and producingChangeset.html To play by the rules I need someone who is a Reviewer to approve the PR. https://github.com/openjdk/guide/pull/1 Thanks, /Jesper From jwilhelm at openjdk.java.net Fri May 8 15:48:21 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 8 May 2020 15:48:21 GMT Subject: RFR: Populating the repo with the old html guide files. Message-ID: Adding the old guide files. ------------- Commit messages: - Moved files to src directory - Changed mode on image. - Populating the repo with the old html guide files. Changes: https://git.openjdk.java.net/guide/pull/1/files Webrev: https://webrevs.openjdk.java.net/guide/1/webrev.00 Stats: 2318 lines in 22 files changed: 2318 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/1.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/1/head:pull/1 PR: https://git.openjdk.java.net/guide/pull/1 From jesper.wilhelmsson at oracle.com Fri May 8 17:15:43 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Fri, 8 May 2020 19:15:43 +0200 Subject: PR #1: Populating the repo with the old html guide files In-Reply-To: References: Message-ID: <05E984F0-1730-4EA9-9B49-F3B078BD9573@oracle.com> I see that the Skara tooling sent an RFR email as well so I guess this kind of emails are redundant going forward. /Jesper > On 8 May 2020, at 17:49, Jesper Wilhelmsson wrote: > > Hi. > > I created a pull request in the new github repo to populate it with the old guide files so that we have a starting point. The files are unmodified except for three cases where I removed text that concerned Oracle-internal process. > > The modified files are changePlanning.html, codeReview.html, and producingChangeset.html > > To play by the rules I need someone who is a Reviewer to approve the PR. > > https://github.com/openjdk/guide/pull/1 > > Thanks, > /Jesper > From jwilhelm at openjdk.java.net Fri May 8 19:20:06 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 8 May 2020 19:20:06 GMT Subject: RFR: Populating the repo with the old html guide files. In-Reply-To: References: Message-ID: On Fri, 8 May 2020 19:04:28 GMT, Iris Clark wrote: >> Adding the old guide files. > > src/changePlanning.html line 134: > >> 133: >> 134: N >> 135: > > I hope this or similar anchor to the "noreg-" suffices stays around long term. I often use it when answering questions. As long as we preserve these names in the markdown the links will continue to work. ------------- PR: https://git.openjdk.java.net/guide/pull/1 From jwilhelm at openjdk.java.net Fri May 8 19:28:47 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 8 May 2020 19:28:47 GMT Subject: RFR: Populating the repo with the old html guide files. In-Reply-To: <08IGa-WNuzCHdsmRsx7torPh4P91PRn7SC2r3qNl0dg=.f62e0472-10fb-4464-a271-e86e6a9d4547@github.com> References: <08IGa-WNuzCHdsmRsx7torPh4P91PRn7SC2r3qNl0dg=.f62e0472-10fb-4464-a271-e86e6a9d4547@github.com> Message-ID: <6nefp81d4s4a7W0vivvcenp9y2eChrtwunDxQiFAF9M=.e06a746d-ed01-4a21-bf5b-9f8bdae472be@github.com> On Fri, 8 May 2020 19:10:47 GMT, Iris Clark wrote: >> Adding the old guide files. > > src/producingChangeset.html line 233: > >> 232: >> 233:

Generating an SSH Key

>> 234: > > I hope this or similar anchor stays around long term. I often use it when answering user questions. The ATX headers that is recommended in other OpenJDK documents that use markdown automatically creates links to all headers. The default is to use the text from the header so the header above would be written as > ### Generating an SSH Key which in turn would generate this html >

Generating an SSH Key

So all headers will have links but by default they won't be the same links as they used to be. I would prefer if we could stick with the defaults if possible. ------------- PR: https://git.openjdk.java.net/guide/pull/1 From jwilhelm at openjdk.java.net Fri May 8 19:33:01 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 8 May 2020 19:33:01 GMT Subject: [Integrated] RFR: Populating the repo with the old html guide files. In-Reply-To: References: Message-ID: <8KzaDR8zII7dlCmJ63oev68l8IBd_fZ4y5t3p93PWDs=.e5d1e9fe-79ec-4f25-bc2b-4278326ed7ef@github.com> On Fri, 8 May 2020 14:48:21 GMT, Jesper Wilhelmsson wrote: > Adding the old guide files. This pull request has now been integrated. Changeset: 71c759dd Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/71c759dd Stats: 2318 lines in 22 files changed: 0 ins; 2318 del; 0 mod Populating the repo with the old html guide files. Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/1 From iris at openjdk.java.net Fri May 8 19:20:06 2020 From: iris at openjdk.java.net (Iris Clark) Date: Fri, 8 May 2020 19:20:06 GMT Subject: RFR: Populating the repo with the old html guide files. In-Reply-To: References: Message-ID: On Fri, 8 May 2020 14:48:21 GMT, Jesper Wilhelmsson wrote: > Adding the old guide files. Thanks so much for working to update this document! I look forward to seeing it evolve to describe our latest practices for development. ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/1 From iris at openjdk.java.net Fri May 8 19:13:03 2020 From: iris at openjdk.java.net (Iris Clark) Date: Fri, 8 May 2020 19:13:03 GMT Subject: RFR: Populating the repo with the old html guide files. In-Reply-To: References: Message-ID: <08IGa-WNuzCHdsmRsx7torPh4P91PRn7SC2r3qNl0dg=.f62e0472-10fb-4464-a271-e86e6a9d4547@github.com> On Fri, 8 May 2020 14:48:21 GMT, Jesper Wilhelmsson wrote: > Adding the old guide files. src/producingChangeset.html line 233: > 232: > 233:

Generating an SSH Key

> 234: I hope this or similar anchor stays around long term. I often use it when answering user questions. ------------- PR: https://git.openjdk.java.net/guide/pull/1 From iris at openjdk.java.net Fri May 8 19:06:35 2020 From: iris at openjdk.java.net (Iris Clark) Date: Fri, 8 May 2020 19:06:35 GMT Subject: RFR: Populating the repo with the old html guide files. In-Reply-To: References: Message-ID: On Fri, 8 May 2020 14:48:21 GMT, Jesper Wilhelmsson wrote: > Adding the old guide files. src/changePlanning.html line 134: > 133: > 134: N > 135: I hope this or similar anchor to the "noreg-" suffices stays around long term. I often use it when answering questions. ------------- PR: https://git.openjdk.java.net/guide/pull/1 From jesper.wilhelmsson at oracle.com Fri May 8 19:42:50 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Fri, 8 May 2020 21:42:50 +0200 Subject: [Integrated] RFR: Populating the repo with the old html guide files. In-Reply-To: <8KzaDR8zII7dlCmJ63oev68l8IBd_fZ4y5t3p93PWDs=.e5d1e9fe-79ec-4f25-bc2b-4278326ed7ef@github.com> References: <8KzaDR8zII7dlCmJ63oev68l8IBd_fZ4y5t3p93PWDs=.e5d1e9fe-79ec-4f25-bc2b-4278326ed7ef@github.com> Message-ID: <3DC48389-E438-47F6-BAF5-19883BFDBE20@oracle.com> Thank you for reviewing Iris! I'm not sure where to put this in the github flow, so sending an email :-) /Jesper > On 8 May 2020, at 21:33, Jesper Wilhelmsson wrote: > > On Fri, 8 May 2020 14:48:21 GMT, Jesper Wilhelmsson wrote: > >> Adding the old guide files. > > This pull request has now been integrated. > > Changeset: 71c759dd > Author: Jesper Wilhelmsson > URL: https://git.openjdk.java.net/guide/commit/71c759dd > Stats: 2318 lines in 22 files changed: 0 ins; 2318 del; 0 mod > > Populating the repo with the old html guide files. > > Reviewed-by: iris > > ------------- > > PR: https://git.openjdk.java.net/guide/pull/1 From jwilhelm at openjdk.java.net Fri May 8 19:50:19 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 8 May 2020 19:50:19 GMT Subject: RFR: Update conf Message-ID: Changed project to guide. ------------- Commit messages: - Update conf Changes: https://git.openjdk.java.net/guide/pull/2/files Webrev: https://webrevs.openjdk.java.net/guide/2/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/2/head:pull/2 PR: https://git.openjdk.java.net/guide/pull/2 From iris at openjdk.java.net Fri May 8 19:53:41 2020 From: iris at openjdk.java.net (Iris Clark) Date: Fri, 8 May 2020 19:53:41 GMT Subject: RFR: Populating the repo with the old html guide files. In-Reply-To: <6nefp81d4s4a7W0vivvcenp9y2eChrtwunDxQiFAF9M=.e06a746d-ed01-4a21-bf5b-9f8bdae472be@github.com> References: <08IGa-WNuzCHdsmRsx7torPh4P91PRn7SC2r3qNl0dg=.f62e0472-10fb-4464-a271-e86e6a9d4547@github.com> <6nefp81d4s4a7W0vivvcenp9y2eChrtwunDxQiFAF9M=.e06a746d-ed01-4a21-bf5b-9f8bdae472be@github.com> Message-ID: On Fri, 8 May 2020 19:26:23 GMT, Jesper Wilhelmsson wrote: >> src/producingChangeset.html line 233: >> >>> 232: >>> 233:

Generating an SSH Key

>>> 234: >> >> I hope this or similar anchor stays around long term. I often use it when answering user questions. > > The ATX headers that is recommended in other OpenJDK documents that use markdown automatically creates links to all > headers. The default is to use the text from the header so the header above would be written as >> ### Generating an SSH Key > > which in turn would generate this html > >>

Generating an SSH Key

> > So all headers will have links but by default they won't be the same links as they used to be. I would prefer if we > could stick with the defaults if possible. I agree. We should use default links whenever possible. My only concern is that the new links are stable. ------------- PR: https://git.openjdk.java.net/guide/pull/1 From jwilhelm at openjdk.java.net Sat May 9 04:11:43 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Sat, 9 May 2020 04:11:43 GMT Subject: RFR: Introducing markdown Message-ID: Converted all html files to markdown and added a makefile to build the html. ------------- Commit messages: - Converted all html files to markdown - Moved files to src directory - Changed mode on image. - Populating the repo with the old html guide files. Changes: https://git.openjdk.java.net/guide/pull/3/files Webrev: https://webrevs.openjdk.java.net/guide/3/webrev.00 Stats: 1837 lines in 23 files changed: 1837 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/3.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/3/head:pull/3 PR: https://git.openjdk.java.net/guide/pull/3 From iris at openjdk.java.net Sun May 10 00:51:25 2020 From: iris at openjdk.java.net (Iris Clark) Date: Sun, 10 May 2020 00:51:25 GMT Subject: RFR: Update conf In-Reply-To: References: Message-ID: On Fri, 8 May 2020 19:45:16 GMT, Jesper Wilhelmsson wrote: > Changed project to guide. Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/guide/pull/2 From iris at openjdk.java.net Sun May 10 00:58:29 2020 From: iris at openjdk.java.net (Iris Clark) Date: Sun, 10 May 2020 00:58:29 GMT Subject: RFR: Introducing markdown In-Reply-To: References: Message-ID: <-U7u4RlYVA6u_YmNmP8GOUK6leMp5rbTT0oGs12F4c4=.09223ce4-6a99-4537-9c06-5a241369c793@github.com> On Sat, 9 May 2020 04:06:51 GMT, Jesper Wilhelmsson wrote: > Converted all html files to markdown and added a makefile to build the html. Fantastic! Modern markup! ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/3 From jwilhelm at openjdk.java.net Sun May 10 20:44:44 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Sun, 10 May 2020 20:44:44 GMT Subject: [Rev 01] RFR: Update conf In-Reply-To: References: Message-ID: > Changed project to guide. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Update conf Changed to require "Reviewer" review. ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/2/files - new: https://git.openjdk.java.net/guide/pull/2/files/ad54f93d..95b74894 Webrevs: - full: https://webrevs.openjdk.java.net/guide/2/webrev.01 - incr: https://webrevs.openjdk.java.net/guide/2/webrev.00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/2.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/2/head:pull/2 PR: https://git.openjdk.java.net/guide/pull/2 From jwilhelm at openjdk.java.net Mon May 11 06:53:24 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Mon, 11 May 2020 06:53:24 GMT Subject: [Integrated] RFR: Introducing markdown In-Reply-To: References: Message-ID: On Sat, 9 May 2020 04:06:51 GMT, Jesper Wilhelmsson wrote: > Converted all html files to markdown and added a makefile to build the html. This pull request has now been integrated. Changeset: 1b6e508a Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/1b6e508a Stats: 1833 lines in 21 files changed: 0 ins; 1833 del; 0 mod Introducing markdown Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/3 From jesper.wilhelmsson at oracle.com Mon May 11 06:55:20 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Mon, 11 May 2020 08:55:20 +0200 Subject: RFR: Introducing markdown In-Reply-To: <-U7u4RlYVA6u_YmNmP8GOUK6leMp5rbTT0oGs12F4c4=.09223ce4-6a99-4537-9c06-5a241369c793@github.com> References: <-U7u4RlYVA6u_YmNmP8GOUK6leMp5rbTT0oGs12F4c4=.09223ce4-6a99-4537-9c06-5a241369c793@github.com> Message-ID: Thank you for your review! /Jesper > On 10 May 2020, at 02:58, Iris Clark wrote: > > On Sat, 9 May 2020 04:06:51 GMT, Jesper Wilhelmsson wrote: > >> Converted all html files to markdown and added a makefile to build the html. > > Fantastic! Modern markup! > > ------------- > > Marked as reviewed by iris (Reviewer). > > PR: https://git.openjdk.java.net/guide/pull/3 From jwilhelm at openjdk.java.net Mon May 11 06:56:11 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Mon, 11 May 2020 06:56:11 GMT Subject: [Integrated] RFR: Update conf In-Reply-To: References: Message-ID: On Fri, 8 May 2020 19:45:16 GMT, Jesper Wilhelmsson wrote: > Changed project to guide. This pull request has now been integrated. Changeset: 407a2001 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/407a2001 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Update conf Reviewed-by: rwestberg, iris ------------- PR: https://git.openjdk.java.net/guide/pull/2 From rwestberg at openjdk.java.net Sat May 9 06:57:15 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 9 May 2020 06:57:15 GMT Subject: RFR: Update conf In-Reply-To: References: Message-ID: On Fri, 8 May 2020 19:45:16 GMT, Jesper Wilhelmsson wrote: > Changed project to guide. Looks good to me! Perhaps you want to update the reviewer check as well now that you have a project with proper reviewers: [checks "reviewers"] committers=1 could be [checks "reviewers"] reviewers=1 if you want to require a Review before a PR can be integrated. ------------- Marked as reviewed by rwestberg (Committer). PR: https://git.openjdk.java.net/guide/pull/2 From jesper.wilhelmsson at oracle.com Wed May 13 12:10:48 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Wed, 13 May 2020 14:10:48 +0200 Subject: Using JBS for guide changes? Message-ID: Hi guide developers. I was wondering if we want to use JBS to track issues in the Developer's Guide. If so we need to have a component/subcomponent for this. If a PR is created for a change all discussion and tracking of that change can be kept in that PR. However if there are ideas or bug reports where the change itself is not ready for a PR I guess we need some way to track those issues. GitHub has a built in issue tracker as well. I don't know if we want to utilize that. Any thoughts on this? /Jesper From jwilhelm at openjdk.java.net Thu May 14 14:19:25 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 14 May 2020 14:19:25 GMT Subject: RFR: Introducing markdown Message-ID: Fixed a few bugs from html to markdown conversion. ------------- Commit messages: - Fixed page title and minor bugs from html to markdown conversion. - Converted all html files to markdown - Moved files to src directory - Changed mode on image. - Populating the repo with the old html guide files. Changes: https://git.openjdk.java.net/guide/pull/4/files Webrev: https://webrevs.openjdk.java.net/guide/4/webrev.00 Stats: 1840 lines in 23 files changed: 1840 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/4/head:pull/4 PR: https://git.openjdk.java.net/guide/pull/4 From jwilhelm at openjdk.java.net Thu May 14 14:49:10 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 14 May 2020 14:49:10 GMT Subject: [Rev 01] RFR: Introducing markdown In-Reply-To: References: Message-ID: > Fixed a few bugs from html to markdown conversion. Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into introducing_markdown - Fixed page title and minor bugs from html to markdown conversion. - Converted all html files to markdown - Moved files to src directory - Changed mode on image. - Populating the repo with the old html guide files. ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/4/files - new: https://git.openjdk.java.net/guide/pull/4/files/d116159b..72ca8428 Webrevs: - full: https://webrevs.openjdk.java.net/guide/4/webrev.01 - incr: https://webrevs.openjdk.java.net/guide/4/webrev.00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/4/head:pull/4 PR: https://git.openjdk.java.net/guide/pull/4 From jesper.wilhelmsson at oracle.com Thu May 14 14:53:19 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 14 May 2020 16:53:19 +0200 Subject: [Rev 01] RFR: Introducing markdown In-Reply-To: References: Message-ID: Re-using the same branch to do additional changes to something already pushed seems to be a bad idea. The PR makes it look like all the commits in the branch are new. This is a link to the only new change (the rest is already reviewed and pushed to master): https://github.com/openjdk/guide/pull/4/commits/d116159bead56fb725d5e884044dfadd76fc66b5 /Jesper > On 14 May 2020, at 16:49, Jesper Wilhelmsson wrote: > >> Fixed a few bugs from html to markdown conversion. > > Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental > webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits > since the last revision: > > - Merge remote-tracking branch 'upstream/master' into introducing_markdown > - Fixed page title and minor bugs from html to markdown conversion. > - Converted all html files to markdown > - Moved files to src directory > - Changed mode on image. > - Populating the repo with the old html guide files. > > ------------- > > Changes: > - all: https://git.openjdk.java.net/guide/pull/4/files > - new: https://git.openjdk.java.net/guide/pull/4/files/d116159b..72ca8428 > > Webrevs: > - full: https://webrevs.openjdk.java.net/guide/4/webrev.01 > - incr: https://webrevs.openjdk.java.net/guide/4/webrev.00-01 > > Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/guide/pull/4.diff > Fetch: git fetch https://git.openjdk.java.net/guide pull/4/head:pull/4 > > PR: https://git.openjdk.java.net/guide/pull/4 From iris at openjdk.java.net Thu May 14 15:10:27 2020 From: iris at openjdk.java.net (Iris Clark) Date: Thu, 14 May 2020 15:10:27 GMT Subject: [Rev 01] RFR: Introducing markdown In-Reply-To: References: Message-ID: <334B1-iOg3HFCvUnPJ3qic3Um2na1poyMSH9bw9qxwQ=.fd827423-4f6c-4ab1-8740-f039529a91ea@github.com> On Thu, 14 May 2020 14:49:10 GMT, Jesper Wilhelmsson wrote: >> Fixed a few bugs from html to markdown conversion. > > Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental > webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits > since the last revision: > - Merge remote-tracking branch 'upstream/master' into introducing_markdown > - Fixed page title and minor bugs from html to markdown conversion. > - Converted all html files to markdown > - Moved files to src directory > - Changed mode on image. > - Populating the repo with the old html guide files. Looks good! ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/4 From rwestberg at openjdk.java.net Thu May 14 15:32:56 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 14 May 2020 15:32:56 GMT Subject: [Rev 01] RFR: Introducing markdown In-Reply-To: References: Message-ID: On Thu, 14 May 2020 14:49:10 GMT, Jesper Wilhelmsson wrote: >> Fixed a few bugs from html to markdown conversion. > > Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental > webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits > since the last revision: > - Merge remote-tracking branch 'upstream/master' into introducing_markdown > - Fixed page title and minor bugs from html to markdown conversion. > - Converted all html files to markdown > - Moved files to src directory > - Changed mode on image. > - Populating the repo with the old html guide files. .jcheck/conf line 25: > 24: [general] > 25: project=jdk > 26: jbs=JDK This change looks like an unintended merge, should probably revert it! .jcheck/conf line 39: > 38: [checks "reviewers"] > 39: committers=1 Same here. ------------- PR: https://git.openjdk.java.net/guide/pull/4 From jwilhelm at openjdk.java.net Thu May 14 15:59:41 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 14 May 2020 15:59:41 GMT Subject: [Rev 01] RFR: Introducing markdown In-Reply-To: References: Message-ID: <07ZJV7MtGSAxio9RzZMeGz_m6j3l5nGpv5l2hHEC5Mg=.7598117f-ee2b-4fa6-b3b8-592311d8d198@github.com> On Thu, 14 May 2020 15:30:27 GMT, Robin Westberg wrote: >> Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits >> since the last revision: >> - Merge remote-tracking branch 'upstream/master' into introducing_markdown >> - Fixed page title and minor bugs from html to markdown conversion. >> - Converted all html files to markdown >> - Moved files to src directory >> - Changed mode on image. >> - Populating the repo with the old html guide files. > > .jcheck/conf line 39: > >> 38: [checks "reviewers"] >> 39: committers=1 > > Same here. Interesting. The conf file wasn't even in the list of conflicting files. ------------- PR: https://git.openjdk.java.net/guide/pull/4 From jwilhelm at openjdk.java.net Thu May 14 16:05:53 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 14 May 2020 16:05:53 GMT Subject: [Rev 02] RFR: Introducing markdown In-Reply-To: References: Message-ID: > Fixed a few bugs from html to markdown conversion. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Undo unintentional merge ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/4/files - new: https://git.openjdk.java.net/guide/pull/4/files/72ca8428..73737a7c Webrevs: - full: https://webrevs.openjdk.java.net/guide/4/webrev.02 - incr: https://webrevs.openjdk.java.net/guide/4/webrev.01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/guide/pull/4.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/4/head:pull/4 PR: https://git.openjdk.java.net/guide/pull/4 From jwilhelm at openjdk.java.net Tue May 19 14:14:02 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 19 May 2020 14:14:02 GMT Subject: [Integrated] RFR: Introducing markdown In-Reply-To: References: Message-ID: On Thu, 14 May 2020 14:13:22 GMT, Jesper Wilhelmsson wrote: > Fixed a few bugs from html to markdown conversion. This pull request has now been integrated. Changeset: 03233b92 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/03233b92 Stats: 2354 lines in 39 files changed: 2314 ins; 3 del; 37 mod Introducing markdown Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/4 From jwilhelm at openjdk.java.net Wed May 20 22:26:16 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 20 May 2020 22:26:16 GMT Subject: RFR: Fixed character encoding issues Message-ID: Removed invisible spaces that weren't actually spaces and told pandoc to generate ascii output. Also using iconv to change the file encoding to Latin-1. ------------- Commit messages: - Fixed character encoding issues Changes: https://git.openjdk.java.net/guide/pull/5/files Webrev: https://webrevs.openjdk.java.net/guide/5/webrev.00 Stats: 40 lines in 19 files changed: 1 ins; 0 del; 39 mod Patch: https://git.openjdk.java.net/guide/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/5/head:pull/5 PR: https://git.openjdk.java.net/guide/pull/5 From jwilhelm at openjdk.java.net Wed May 20 22:34:05 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 20 May 2020 22:34:05 GMT Subject: [Rev 01] RFR: Fixed character encoding issues In-Reply-To: References: Message-ID: > Removed invisible spaces that weren't actually spaces and told pandoc to generate ascii output. Also using iconv to > change the file encoding to Latin-1. Jesper Wilhelmsson has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. This pull request has now been integrated. Changeset: 03233b92 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/03233b92 Stats: 2354 lines in 39 files changed: 2314 ins; 3 del; 37 mod Introducing markdown Reviewed-by: iris ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/5/files - new: https://git.openjdk.java.net/guide/pull/5/files/fb114370..03233b92 Webrevs: - full: https://webrevs.openjdk.java.net/guide/5/webrev.01 - incr: https://webrevs.openjdk.java.net/guide/5/webrev.00-01 Stats: 40 lines in 19 files changed: 0 ins; 1 del; 39 mod Patch: https://git.openjdk.java.net/guide/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/5/head:pull/5 PR: https://git.openjdk.java.net/guide/pull/5 From jwilhelm at openjdk.java.net Wed May 20 22:37:34 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 20 May 2020 22:37:34 GMT Subject: RFR: Fixed character encoding issues Message-ID: Removed invisible spaces that weren't actually spaces and told pandoc to generate ascii output. Also using iconv to change the file encoding to Latin-1. ------------- Commit messages: - Fixed character encoding issues Changes: https://git.openjdk.java.net/guide/pull/6/files Webrev: https://webrevs.openjdk.java.net/guide/6/webrev.00 Stats: 40 lines in 19 files changed: 1 ins; 0 del; 39 mod Patch: https://git.openjdk.java.net/guide/pull/6.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/6/head:pull/6 PR: https://git.openjdk.java.net/guide/pull/6 From jwilhelm at openjdk.java.net Wed May 20 22:58:34 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 20 May 2020 22:58:34 GMT Subject: RFR: Fixed character encoding issues In-Reply-To: References: Message-ID: On Wed, 20 May 2020 22:32:36 GMT, Jesper Wilhelmsson wrote: > Removed invisible spaces that weren't actually spaces and told pandoc to generate ascii output. Also using iconv to > change the file encoding to Latin-1. Sorry for the noise! The last pull request (#5) was sad because I didn't create a brach for it. Once I did that #5 was closed and I had to create a new pull request (this one). Please ignore #5 and review this one ?? Thanks! ------------- PR: https://git.openjdk.java.net/guide/pull/6 From iris at openjdk.java.net Thu May 21 03:26:19 2020 From: iris at openjdk.java.net (Iris Clark) Date: Thu, 21 May 2020 03:26:19 GMT Subject: RFR: Fixed character encoding issues In-Reply-To: References: Message-ID: On Wed, 20 May 2020 22:32:36 GMT, Jesper Wilhelmsson wrote: > Removed invisible spaces that weren't actually spaces and told pandoc to generate ascii output. Also using iconv to > change the file encoding to Latin-1. Looks good. Glad you were able to track down this problem. I think you should consider updating the version number. While there have been no significant content changes yet, I think that the new formatting and generation does merit an updated version number. ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/6 From jwilhelm at openjdk.java.net Thu May 21 03:41:04 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 21 May 2020 03:41:04 GMT Subject: [Integrated] RFR: Fixed character encoding issues In-Reply-To: References: Message-ID: On Wed, 20 May 2020 22:32:36 GMT, Jesper Wilhelmsson wrote: > Removed invisible spaces that weren't actually spaces and told pandoc to generate ascii output. Also using iconv to > change the file encoding to Latin-1. This pull request has now been integrated. Changeset: 7f9c265d Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/7f9c265d Stats: 40 lines in 19 files changed: 0 ins; 1 del; 39 mod Fixed character encoding issues Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/6 From jwilhelm at openjdk.java.net Thu May 21 03:41:04 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 21 May 2020 03:41:04 GMT Subject: RFR: Fixed character encoding issues In-Reply-To: References: Message-ID: <31LaxTBIhIUrErggsMWmhhOWP5Tulq8Ojea2uNo3zxg=.3b253771-9aed-4a47-81f5-09c101f2b53d@github.com> On Thu, 21 May 2020 03:24:08 GMT, Iris Clark wrote: >> Removed invisible spaces that weren't actually spaces and told pandoc to generate ascii output. Also using iconv to >> change the file encoding to Latin-1. > > Looks good. Glad you were able to track down this problem. > > I think you should consider updating the version number. While there have been no significant content changes yet, I > think that the new formatting and generation does merit an updated version number. Yeah.. I was meaning to bring up the subject of the version numbers. I'll start a different thread on that. Thanks for the review! ------------- PR: https://git.openjdk.java.net/guide/pull/6 From jesper.wilhelmsson at oracle.com Thu May 21 04:02:51 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 21 May 2020 06:02:51 +0200 Subject: Version numbers in the guide Message-ID: <7BB79C3B-4123-4F1A-B311-CF88DDB0070E@oracle.com> Hi. I have been thinking about the version numbers and the release notes in the guide; do we really need that part? Who are the audience for this information? To me, today, these numbers and notes only creates extra work and I don't see any real benefit in having them. If I want to see when or why some part of the guide changed I wouldn't trust the release notes anyway as they are way too coarse - I would go to the change log on Github. Release notes like these are always subject to subjective opinions on what is an important change and what is not, and unless pretty much every change is included someone has to make a decision for each change wether to include it or not. /Jesper From iris.clark at oracle.com Thu May 21 04:28:43 2020 From: iris.clark at oracle.com (Iris Clark) Date: Wed, 20 May 2020 21:28:43 -0700 (PDT) Subject: Version numbers in the guide In-Reply-To: <7BB79C3B-4123-4F1A-B311-CF88DDB0070E@oracle.com> References: <7BB79C3B-4123-4F1A-B311-CF88DDB0070E@oracle.com> Message-ID: Hi, Jesper. I don't think the Guide needs version numbers. This type of documentation should be viewed as continually evolving. MLA, Chicago, APA and other style guides use an "accessed on #DATE" for on-line references. If somebody really wants to have some kind of numbering system associated with a particular Guide web page, then a time/date stamp or commit would be reasonable if there is a relatively passive solution to add it. Perhaps the stamp is added at build time or it is updated when the editor saves changes? The second choice would lead to differing stamps across the Guide over time, but I don't see that as a problem. Thanks, Iris From jesper.wilhelmsson at oracle.com Thu May 21 04:54:04 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 21 May 2020 06:54:04 +0200 Subject: Version numbers in the guide In-Reply-To: References: <7BB79C3B-4123-4F1A-B311-CF88DDB0070E@oracle.com> Message-ID: <07DEBF02-955C-4547-963B-45DBEA775D4A@oracle.com> > On 21 May 2020, at 06:28, Iris Clark wrote: > > Hi, Jesper. > > I don't think the Guide needs version numbers. This type of documentation should be viewed as continually evolving. MLA, Chicago, APA and other style guides use an "accessed on #DATE" for on-line references. > > If somebody really wants to have some kind of numbering system associated with a particular Guide web page, then a time/date stamp or commit would be reasonable if there is a relatively passive solution to add it. Perhaps the stamp is added at build time or it is updated when the editor saves changes? The second choice would lead to differing stamps across the Guide over time, but I don't see that as a problem. I would even see that as a bonus if each page has its own "last modified" date. Adding a small JavaScript or PHP call to add the file date is very easy. It will show the date when a file was last saved, so I assume that would be the time when the file was uploaded to the webserver. Replacing the version number with a last modified date sounds like a good idea to me. Thanks, /Jesper > > Thanks, > Iris From jwilhelm at openjdk.java.net Mon May 25 08:55:50 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Mon, 25 May 2020 08:55:50 GMT Subject: RFR: Cleaned up the noreg table Message-ID: Added link targets for all noreg-labels. ------------- Commit messages: - Cleaned up the noreg table Changes: https://git.openjdk.java.net/guide/pull/7/files Webrev: https://webrevs.openjdk.java.net/guide/7/webrev.00 Stats: 19 lines in 1 file changed: 0 ins; 0 del; 19 mod Patch: https://git.openjdk.java.net/guide/pull/7.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/7/head:pull/7 PR: https://git.openjdk.java.net/guide/pull/7 From jwilhelm at openjdk.java.net Mon May 25 21:52:44 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Mon, 25 May 2020 21:52:44 GMT Subject: RFR: Created README for the project Message-ID: A readme file that will serve as the GitHub front page for the project. ------------- Commit messages: - Created README for the project Changes: https://git.openjdk.java.net/guide/pull/8/files Webrev: https://webrevs.openjdk.java.net/guide/8/webrev.00 Stats: 38 lines in 1 file changed: 38 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/8/head:pull/8 PR: https://git.openjdk.java.net/guide/pull/8 From jwilhelm at openjdk.java.net Mon May 25 22:01:57 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Mon, 25 May 2020 22:01:57 GMT Subject: RFR: Remove version numbering Message-ID: Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time instead. The modification time is currently only placed at the bottom of each file, while the version number was present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that decision. It's a simple makefile change to add it at the top as well. ------------- Commit messages: - Remove version numbering Changes: https://git.openjdk.java.net/guide/pull/9/files Webrev: https://webrevs.openjdk.java.net/guide/9/webrev.00 Stats: 158 lines in 20 files changed: 5 ins; 152 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/9.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/9/head:pull/9 PR: https://git.openjdk.java.net/guide/pull/9 From david.holmes at oracle.com Mon May 25 23:58:07 2020 From: david.holmes at oracle.com (David Holmes) Date: Tue, 26 May 2020 09:58:07 +1000 Subject: RFR: Created README for the project In-Reply-To: References: Message-ID: <2a20614d-5e84-9de2-f4ce-e0491f92ceff@oracle.com> Hi Jesper, A couple of typos: 5. et.c. -> etc. 11. isn't -> aren't Otherwise seems a good start. :) Thanks, David On 26/05/2020 7:52 am, Jesper Wilhelmsson wrote: > A readme file that will serve as the GitHub front page for the project. > > ------------- > > Commit messages: > - Created README for the project > > Changes: https://git.openjdk.java.net/guide/pull/8/files > Webrev: https://webrevs.openjdk.java.net/guide/8/webrev.00 > Stats: 38 lines in 1 file changed: 38 ins; 0 del; 0 mod > Patch: https://git.openjdk.java.net/guide/pull/8.diff > Fetch: git fetch https://git.openjdk.java.net/guide pull/8/head:pull/8 > > PR: https://git.openjdk.java.net/guide/pull/8 > From david.holmes at oracle.com Tue May 26 00:01:52 2020 From: david.holmes at oracle.com (David Holmes) Date: Tue, 26 May 2020 10:01:52 +1000 Subject: RFR: Remove version numbering In-Reply-To: References: Message-ID: <2353958e-ce1c-cbfa-3723-77caf7aecc1a@oracle.com> Hi Jesper, On 26/05/2020 8:01 am, Jesper Wilhelmsson wrote: > Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time > instead. The modification time is currently only placed at the bottom of each file, while the version number was > present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that > decision. It's a simple makefile change to add it at the top as well. Seems okay, but do we want any kind of change history in the documents themselves? I find a last modified date of little use in general. Thanks, David > ------------- > > Commit messages: > - Remove version numbering > > Changes: https://git.openjdk.java.net/guide/pull/9/files > Webrev: https://webrevs.openjdk.java.net/guide/9/webrev.00 > Stats: 158 lines in 20 files changed: 5 ins; 152 del; 1 mod > Patch: https://git.openjdk.java.net/guide/pull/9.diff > Fetch: git fetch https://git.openjdk.java.net/guide pull/9/head:pull/9 > > PR: https://git.openjdk.java.net/guide/pull/9 > From jesper.wilhelmsson at oracle.com Tue May 26 00:14:46 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 26 May 2020 02:14:46 +0200 Subject: RFR: Created README for the project In-Reply-To: <2a20614d-5e84-9de2-f4ce-e0491f92ceff@oracle.com> References: <2a20614d-5e84-9de2-f4ce-e0491f92ceff@oracle.com> Message-ID: <493D83E9-57B8-4C15-8EDA-97A0B3242E10@oracle.com> Thanks David! Fixed the typos. /Jesper > On 26 May 2020, at 01:58, David Holmes wrote: > > Hi Jesper, > > A couple of typos: > > 5. et.c. -> etc. > > 11. isn't -> aren't > > Otherwise seems a good start. :) > > Thanks, > David > > On 26/05/2020 7:52 am, Jesper Wilhelmsson wrote: >> A readme file that will serve as the GitHub front page for the project. >> ------------- >> Commit messages: >> - Created README for the project >> Changes: https://git.openjdk.java.net/guide/pull/8/files >> Webrev: https://webrevs.openjdk.java.net/guide/8/webrev.00 >> Stats: 38 lines in 1 file changed: 38 ins; 0 del; 0 mod >> Patch: https://git.openjdk.java.net/guide/pull/8.diff >> Fetch: git fetch https://git.openjdk.java.net/guide pull/8/head:pull/8 >> PR: https://git.openjdk.java.net/guide/pull/8 From jwilhelm at openjdk.java.net Tue May 26 00:19:30 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 26 May 2020 00:19:30 GMT Subject: [Rev 01] RFR: Created README for the project In-Reply-To: References: Message-ID: > A readme file that will serve as the GitHub front page for the project. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Fixed typos ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/8/files - new: https://git.openjdk.java.net/guide/pull/8/files/31896379..07449ce7 Webrevs: - full: https://webrevs.openjdk.java.net/guide/8/webrev.01 - incr: https://webrevs.openjdk.java.net/guide/8/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/guide/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/8/head:pull/8 PR: https://git.openjdk.java.net/guide/pull/8 From jesper.wilhelmsson at oracle.com Tue May 26 00:28:22 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 26 May 2020 02:28:22 +0200 Subject: RFR: Remove version numbering In-Reply-To: <2353958e-ce1c-cbfa-3723-77caf7aecc1a@oracle.com> References: <2353958e-ce1c-cbfa-3723-77caf7aecc1a@oracle.com> Message-ID: <89D9649C-2513-4DAA-B1D5-0EF4E3AE2620@oracle.com> > On 26 May 2020, at 02:01, David Holmes wrote: > > Hi Jesper, > > On 26/05/2020 8:01 am, Jesper Wilhelmsson wrote: >> Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time >> instead. The modification time is currently only placed at the bottom of each file, while the version number was >> present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that >> decision. It's a simple makefile change to add it at the top as well. > > Seems okay, but do we want any kind of change history in the documents themselves? I find a last modified date of little use in general. The complete change history is available in the GitHub repo: https://github.com/openjdk/guide/commits/master You can also see history for individual files: https://github.com/openjdk/guide/commits/master/src/changePlanning.md Adding the date was suggested in a previous thread. To me it serves as a way to at least get an impression of how current some information is. In this case it also serves as a tag on the document to refer to in discussions where the version number was previously used. Since the date is kept up to date automatically it's a more convenient way to tag the document. /Jesper > > Thanks, > David > >> ------------- >> Commit messages: >> - Remove version numbering >> Changes: https://git.openjdk.java.net/guide/pull/9/files >> Webrev: https://webrevs.openjdk.java.net/guide/9/webrev.00 >> Stats: 158 lines in 20 files changed: 5 ins; 152 del; 1 mod >> Patch: https://git.openjdk.java.net/guide/pull/9.diff >> Fetch: git fetch https://git.openjdk.java.net/guide pull/9/head:pull/9 >> PR: https://git.openjdk.java.net/guide/pull/9 From david.holmes at oracle.com Tue May 26 00:53:20 2020 From: david.holmes at oracle.com (David Holmes) Date: Tue, 26 May 2020 10:53:20 +1000 Subject: [Rev 01] RFR: Created README for the project In-Reply-To: References: Message-ID: <06e216ec-c67d-4de9-d243-c0f8960d596e@oracle.com> LGTM :) David On 26/05/2020 10:19 am, Jesper Wilhelmsson wrote: >> A readme file that will serve as the GitHub front page for the project. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fixed typos > > ------------- > > Changes: > - all: https://git.openjdk.java.net/guide/pull/8/files > - new: https://git.openjdk.java.net/guide/pull/8/files/31896379..07449ce7 > > Webrevs: > - full: https://webrevs.openjdk.java.net/guide/8/webrev.01 > - incr: https://webrevs.openjdk.java.net/guide/8/webrev.00-01 > > Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/guide/pull/8.diff > Fetch: git fetch https://git.openjdk.java.net/guide pull/8/head:pull/8 > > PR: https://git.openjdk.java.net/guide/pull/8 > From david.holmes at oracle.com Tue May 26 00:58:40 2020 From: david.holmes at oracle.com (David Holmes) Date: Tue, 26 May 2020 10:58:40 +1000 Subject: RFR: Remove version numbering In-Reply-To: <89D9649C-2513-4DAA-B1D5-0EF4E3AE2620@oracle.com> References: <2353958e-ce1c-cbfa-3723-77caf7aecc1a@oracle.com> <89D9649C-2513-4DAA-B1D5-0EF4E3AE2620@oracle.com> Message-ID: On 26/05/2020 10:28 am, Jesper Wilhelmsson wrote: >> On 26 May 2020, at 02:01, David Holmes wrote: >> >> Hi Jesper, >> >> On 26/05/2020 8:01 am, Jesper Wilhelmsson wrote: >>> Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time >>> instead. The modification time is currently only placed at the bottom of each file, while the version number was >>> present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that >>> decision. It's a simple makefile change to add it at the top as well. >> >> Seems okay, but do we want any kind of change history in the documents themselves? I find a last modified date of little use in general. > > The complete change history is available in the GitHub repo: https://github.com/openjdk/guide/commits/master > > You can also see history for individual files: https://github.com/openjdk/guide/commits/master/src/changePlanning.md Sure but I don't expect people to have to go to the repo to check the history. Version numbers indicate relative significance of changes, so if discussing something and you have version 2 while someone else references version 3, then you know you have to update and see what changed. Without a version number there is no direct indication of any significant changes. A change history captures that as part of the visible document. > Adding the date was suggested in a previous thread. To me it serves as a way to at least get an impression of how current some information is. In this case it also serves as a tag on the document to refer to in discussions where the version number was previously used. Since the date is kept up to date automatically it's a more convenient way to tag the document. I find such a date of little use because the bulk of the content could be 10 years old and out of date, but a recent insignificant edit (maybe a broken URL) caused the last modified date to be updated. Such a single value really tells you nothing about how current the information is. Cheers, David > /Jesper > >> >> Thanks, >> David >> >>> ------------- >>> Commit messages: >>> - Remove version numbering >>> Changes: https://git.openjdk.java.net/guide/pull/9/files >>> Webrev: https://webrevs.openjdk.java.net/guide/9/webrev.00 >>> Stats: 158 lines in 20 files changed: 5 ins; 152 del; 1 mod >>> Patch: https://git.openjdk.java.net/guide/pull/9.diff >>> Fetch: git fetch https://git.openjdk.java.net/guide pull/9/head:pull/9 >>> PR: https://git.openjdk.java.net/guide/pull/9 > From jesper.wilhelmsson at oracle.com Tue May 26 17:42:44 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Tue, 26 May 2020 19:42:44 +0200 Subject: RFR: Remove version numbering In-Reply-To: References: <2353958e-ce1c-cbfa-3723-77caf7aecc1a@oracle.com> <89D9649C-2513-4DAA-B1D5-0EF4E3AE2620@oracle.com> Message-ID: <31237917-2FFA-4C95-A105-E3DFF16AF225@oracle.com> > On 26 May 2020, at 02:58, David Holmes wrote: > On 26/05/2020 10:28 am, Jesper Wilhelmsson wrote: >>> On 26 May 2020, at 02:01, David Holmes wrote: >>> >>> Hi Jesper, >>> >>> On 26/05/2020 8:01 am, Jesper Wilhelmsson wrote: >>>> Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time >>>> instead. The modification time is currently only placed at the bottom of each file, while the version number was >>>> present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that >>>> decision. It's a simple makefile change to add it at the top as well. >>> >>> Seems okay, but do we want any kind of change history in the documents themselves? I find a last modified date of little use in general. >> The complete change history is available in the GitHub repo: https://github.com/openjdk/guide/commits/master >> You can also see history for individual files: https://github.com/openjdk/guide/commits/master/src/changePlanning.md > > Sure but I don't expect people to have to go to the repo to check the history. Version numbers indicate relative significance of changes, so if discussing something and you have version 2 while someone else references version 3, then you know you have to update and see what changed. Without a version number there is no direct indication of any significant changes. A change history captures that as part of the visible document. I'm not sure why the average reader would care about the history of this document at all. They just want to find the answer to their current question and have presumably little interest in knowing how that question was answered in the past. The change history is of more importance to maintainers of the guide, and as such I would expect people to go to the repo. The version number as it looks right now has both a major and a minor part. Deciding if a change is major or not is a difficult task, and may be cause for friction within the project if someone think they did a huge job while others don't see the importance of that work. Where do we draw the line between a major change and a minor change? This is especially difficult in a living document where many small changes are expected frequently, and the major change might evolve through many smaller changes. It's basically the same problem as with the JEP process - If a number of smaller changes over several releases turns out to sum up to a new feature - would the last small change get a JEP? >> Adding the date was suggested in a previous thread. To me it serves as a way to at least get an impression of how current some information is. In this case it also serves as a tag on the document to refer to in discussions where the version number was previously used. Since the date is kept up to date automatically it's a more convenient way to tag the document. > > I find such a date of little use because the bulk of the content could be 10 years old and out of date, but a recent insignificant edit (maybe a broken URL) caused the last modified date to be updated. Such a single value really tells you nothing about how current the information is. This is clearly the case right now as we just started to update the guide after many years, but I do hope that we manage to get this up to date and keep it up to date. If not this project would need more attention. So if we assume that a page has information that is a few years old but which is still up to date, and that page is updated to fix a broken link, the updated date could be seen as an indication that the page is alive and has been verified to still be up to date. I know it's impossible to tell the difference, but in the end I guess it's about how much trust one has in the maintainers of the guide. That's something I and others will have to work on earning. For the version number to be a trustworthy reference in discussions and references to the guide, it basically has to be updated for every "release". As we don't have scheduled releases, and I really hope to update the online document as frequently as we make changes in the repo, this would be quite often. Even though the effort of updating the version number could be reduced (it's currently hard-coded in two places on every page) by using a similar header/footer as I introduce in this change, there would still be a manual task required for every release. I envision this to become one of those "you forgot to update the copyright header"-type of issues :-) Also, in the end I really hope that no-one (except maintainers of course) will have their own local copy of the guide. It's an online document and it's not distributed in any bundles or release artifacts. So the value of both a version number and a date is in my opinion very limited. But having the date adds value to some and it requires no maintenance, so I don't see any harm in adding it. ?? /Jesper > Cheers, > David > >> /Jesper >>> >>> Thanks, >>> David >>> >>>> ------------- >>>> Commit messages: >>>> - Remove version numbering >>>> Changes: https://git.openjdk.java.net/guide/pull/9/files >>>> Webrev: https://webrevs.openjdk.java.net/guide/9/webrev.00 >>>> Stats: 158 lines in 20 files changed: 5 ins; 152 del; 1 mod >>>> Patch: https://git.openjdk.java.net/guide/pull/9.diff >>>> Fetch: git fetch https://git.openjdk.java.net/guide pull/9/head:pull/9 >>>> PR: https://git.openjdk.java.net/guide/pull/9 From jwilhelm at openjdk.java.net Tue May 26 21:13:05 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 26 May 2020 21:13:05 GMT Subject: RFR: Usign perl instead of sed Message-ID: It turns out that different common versions of sed behaves differently so the suggestion here is to replace it with perl. ------------- Commit messages: - Usign perl instead of sed Changes: https://git.openjdk.java.net/guide/pull/10/files Webrev: https://webrevs.openjdk.java.net/guide/10/webrev.00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/10/head:pull/10 PR: https://git.openjdk.java.net/guide/pull/10 From jwilhelm at openjdk.java.net Tue May 26 23:34:42 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 26 May 2020 23:34:42 GMT Subject: [Rev 01] RFR: Usign perl instead of sed In-Reply-To: References: Message-ID: <0zP-EDaYMtWQHv4GHxbzvBtGq8qm-RvDJCgwdOxEmIc=.d9205d65-7344-41f8-a2f1-27338ec7de71@github.com> > It turns out that different common versions of sed behaves differently so the suggestion here is to replace it with > perl. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Use html4 ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/10/files - new: https://git.openjdk.java.net/guide/pull/10/files/09f7c72f..13785f12 Webrevs: - full: https://webrevs.openjdk.java.net/guide/10/webrev.01 - incr: https://webrevs.openjdk.java.net/guide/10/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/guide/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/10/head:pull/10 PR: https://git.openjdk.java.net/guide/pull/10 From jwilhelm at openjdk.java.net Tue May 26 23:34:47 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 26 May 2020 23:34:47 GMT Subject: RFR: Usign perl instead of sed In-Reply-To: References: Message-ID: On Tue, 26 May 2020 21:06:32 GMT, Jesper Wilhelmsson wrote: > It turns out that different common versions of sed behaves differently so the suggestion here is to replace it with > perl. Added a change to use html 4 as pandoc output. There were issues validating the html 5 output. ------------- PR: https://git.openjdk.java.net/guide/pull/10 From iris at openjdk.java.net Wed May 27 07:21:34 2020 From: iris at openjdk.java.net (Iris Clark) Date: Wed, 27 May 2020 07:21:34 GMT Subject: [Rev 01] RFR: Usign perl instead of sed In-Reply-To: <0zP-EDaYMtWQHv4GHxbzvBtGq8qm-RvDJCgwdOxEmIc=.d9205d65-7344-41f8-a2f1-27338ec7de71@github.com> References: <0zP-EDaYMtWQHv4GHxbzvBtGq8qm-RvDJCgwdOxEmIc=.d9205d65-7344-41f8-a2f1-27338ec7de71@github.com> Message-ID: <20oUnSBbHOQtLkoJ8MNGo6K19OsuPqqKfbb-NeNpHss=.74493106-bf5d-432e-a589-1be1fcde36b3@github.com> On Tue, 26 May 2020 23:34:42 GMT, Jesper Wilhelmsson wrote: >> It turns out that different common versions of sed behaves differently so the suggestion here is to replace it with >> perl. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Use html4 Looks good. ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/10 From iris at openjdk.java.net Wed May 27 07:25:54 2020 From: iris at openjdk.java.net (Iris Clark) Date: Wed, 27 May 2020 07:25:54 GMT Subject: RFR: Remove version numbering In-Reply-To: References: Message-ID: On Mon, 25 May 2020 21:56:46 GMT, Jesper Wilhelmsson wrote: > Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time > instead. The modification time is currently only placed at the bottom of each file, while the version number was > present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that > decision. It's a simple makefile change to add it at the top as well. Good to see that adding a footer time/date stamp is straight-forward. ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/9 From iris at openjdk.java.net Wed May 27 08:03:00 2020 From: iris at openjdk.java.net (Iris Clark) Date: Wed, 27 May 2020 08:03:00 GMT Subject: RFR: Cleaned up the noreg table In-Reply-To: References: Message-ID: On Mon, 25 May 2020 08:50:26 GMT, Jesper Wilhelmsson wrote: > Added link targets for all noreg-labels. Looks good. ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/7 From iris at openjdk.java.net Wed May 27 08:14:16 2020 From: iris at openjdk.java.net (Iris Clark) Date: Wed, 27 May 2020 08:14:16 GMT Subject: [Rev 01] RFR: Created README for the project In-Reply-To: References: Message-ID: On Tue, 26 May 2020 00:19:30 GMT, Jesper Wilhelmsson wrote: >> A readme file that will serve as the GitHub front page for the project. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fixed typos README.md line 3: > 2: > 3: This project maintains the [OpenJDK Developers' Guide](https://openjdk.java.net/guide/). > 4: The goal of this guide is to answer questions that the developers of the JDK might have around Capitalize "Project" ------------- PR: https://git.openjdk.java.net/guide/pull/8 From iris at openjdk.java.net Wed May 27 08:18:49 2020 From: iris at openjdk.java.net (Iris Clark) Date: Wed, 27 May 2020 08:18:49 GMT Subject: [Rev 01] RFR: Created README for the project In-Reply-To: References: Message-ID: On Tue, 26 May 2020 00:19:30 GMT, Jesper Wilhelmsson wrote: >> A readme file that will serve as the GitHub front page for the project. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fixed typos Nice start on an informative README. README.md line 27: > 26: > 27: To engage in the development of the guide itself create a private fork of the guide and join > 28: the dedicated [guide-dev mail list](https://mail.openjdk.java.net/mailman/listinfo/guide-dev). I would capitalize "Guide" when used as a shortened form of the "Developers' Guide." ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/8 From magnus.ihse.bursie at oracle.com Wed May 27 12:20:05 2020 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Wed, 27 May 2020 14:20:05 +0200 Subject: RFR: Remove version numbering In-Reply-To: <31237917-2FFA-4C95-A105-E3DFF16AF225@oracle.com> References: <2353958e-ce1c-cbfa-3723-77caf7aecc1a@oracle.com> <89D9649C-2513-4DAA-B1D5-0EF4E3AE2620@oracle.com> <31237917-2FFA-4C95-A105-E3DFF16AF225@oracle.com> Message-ID: <2cfd8d6a-59b9-0ef2-e5d0-ce8c0cc33943@oracle.com> I don't think version numbers are any good, on the same ground that Jesper argues against them. And I don't think a timestamp is a good idea, on the same ground that David argues against them. If the intention here is to keep a living, correct, up to date document, timestamps and versions are of no use. If we change our process or tools, we change the document. If a specific page has not been changed for a long time, it just means that it is still valid, given that we take responsibility of keeping the entire guide up to date. Just remove the distraction and boilerplate! /Magnus On 2020-05-26 19:42, Jesper Wilhelmsson wrote: >> On 26 May 2020, at 02:58, David Holmes wrote: >> On 26/05/2020 10:28 am, Jesper Wilhelmsson wrote: >>>> On 26 May 2020, at 02:01, David Holmes wrote: >>>> >>>> Hi Jesper, >>>> >>>> On 26/05/2020 8:01 am, Jesper Wilhelmsson wrote: >>>>> Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time >>>>> instead. The modification time is currently only placed at the bottom of each file, while the version number was >>>>> present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that >>>>> decision. It's a simple makefile change to add it at the top as well. >>>> Seems okay, but do we want any kind of change history in the documents themselves? I find a last modified date of little use in general. >>> The complete change history is available in the GitHub repo: https://github.com/openjdk/guide/commits/master >>> You can also see history for individual files: https://github.com/openjdk/guide/commits/master/src/changePlanning.md >> Sure but I don't expect people to have to go to the repo to check the history. Version numbers indicate relative significance of changes, so if discussing something and you have version 2 while someone else references version 3, then you know you have to update and see what changed. Without a version number there is no direct indication of any significant changes. A change history captures that as part of the visible document. > I'm not sure why the average reader would care about the history of this document at all. They just want to find the answer to their current question and have presumably little interest in knowing how that question was answered in the past. The change history is of more importance to maintainers of the guide, and as such I would expect people to go to the repo. > > The version number as it looks right now has both a major and a minor part. Deciding if a change is major or not is a difficult task, and may be cause for friction within the project if someone think they did a huge job while others don't see the importance of that work. Where do we draw the line between a major change and a minor change? This is especially difficult in a living document where many small changes are expected frequently, and the major change might evolve through many smaller changes. It's basically the same problem as with the JEP process - If a number of smaller changes over several releases turns out to sum up to a new feature - would the last small change get a JEP? > >>> Adding the date was suggested in a previous thread. To me it serves as a way to at least get an impression of how current some information is. In this case it also serves as a tag on the document to refer to in discussions where the version number was previously used. Since the date is kept up to date automatically it's a more convenient way to tag the document. >> I find such a date of little use because the bulk of the content could be 10 years old and out of date, but a recent insignificant edit (maybe a broken URL) caused the last modified date to be updated. Such a single value really tells you nothing about how current the information is. > This is clearly the case right now as we just started to update the guide after many years, but I do hope that we manage to get this up to date and keep it up to date. If not this project would need more attention. So if we assume that a page has information that is a few years old but which is still up to date, and that page is updated to fix a broken link, the updated date could be seen as an indication that the page is alive and has been verified to still be up to date. I know it's impossible to tell the difference, but in the end I guess it's about how much trust one has in the maintainers of the guide. That's something I and others will have to work on earning. > > For the version number to be a trustworthy reference in discussions and references to the guide, it basically has to be updated for every "release". As we don't have scheduled releases, and I really hope to update the online document as frequently as we make changes in the repo, this would be quite often. Even though the effort of updating the version number could be reduced (it's currently hard-coded in two places on every page) by using a similar header/footer as I introduce in this change, there would still be a manual task required for every release. I envision this to become one of those "you forgot to update the copyright header"-type of issues :-) > > Also, in the end I really hope that no-one (except maintainers of course) will have their own local copy of the guide. It's an online document and it's not distributed in any bundles or release artifacts. So the value of both a version number and a date is in my opinion very limited. But having the date adds value to some and it requires no maintenance, so I don't see any harm in adding it. > > ?? > /Jesper > >> Cheers, >> David >> >>> /Jesper >>>> Thanks, >>>> David >>>> >>>>> ------------- >>>>> Commit messages: >>>>> - Remove version numbering >>>>> Changes: https://git.openjdk.java.net/guide/pull/9/files >>>>> Webrev: https://webrevs.openjdk.java.net/guide/9/webrev.00 >>>>> Stats: 158 lines in 20 files changed: 5 ins; 152 del; 1 mod >>>>> Patch: https://git.openjdk.java.net/guide/pull/9.diff >>>>> Fetch: git fetch https://git.openjdk.java.net/guide pull/9/head:pull/9 >>>>> PR: https://git.openjdk.java.net/guide/pull/9 From magnus.ihse.bursie at oracle.com Wed May 27 12:21:32 2020 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Wed, 27 May 2020 14:21:32 +0200 Subject: [Rev 01] RFR: Created README for the project In-Reply-To: References: Message-ID: <315e2773-b8b4-e601-9b8b-e4d3f2129b5c@oracle.com> On 2020-05-26 02:19, Jesper Wilhelmsson wrote: >> A readme file that will serve as the GitHub front page for the project. > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fixed typos Looks good. /Magnus > > ------------- > > Changes: > - all: https://git.openjdk.java.net/guide/pull/8/files > - new: https://git.openjdk.java.net/guide/pull/8/files/31896379..07449ce7 > > Webrevs: > - full: https://webrevs.openjdk.java.net/guide/8/webrev.01 > - incr: https://webrevs.openjdk.java.net/guide/8/webrev.00-01 > > Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod > Patch: https://git.openjdk.java.net/guide/pull/8.diff > Fetch: git fetch https://git.openjdk.java.net/guide pull/8/head:pull/8 > > PR: https://git.openjdk.java.net/guide/pull/8 From jwilhelm at openjdk.java.net Wed May 27 12:47:21 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 27 May 2020 12:47:21 GMT Subject: [Integrated] RFR: Usign perl instead of sed In-Reply-To: References: Message-ID: On Tue, 26 May 2020 21:06:32 GMT, Jesper Wilhelmsson wrote: > It turns out that different common versions of sed behaves differently so the suggestion here is to replace it with > perl. This pull request has now been integrated. Changeset: 09cf9bc8 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/09cf9bc8 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Usign perl instead of sed Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/10 From jwilhelm at openjdk.java.net Wed May 27 13:49:44 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 27 May 2020 13:49:44 GMT Subject: [Rev 01] RFR: Cleaned up the noreg table In-Reply-To: References: Message-ID: > Added link targets for all noreg-labels. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Usign perl instead of sed Reviewed-by: iris This pull request has now been integrated. Changeset: 76b8f4aa Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/76b8f4aa Stats: 19 lines in 1 file changed: 0 ins; 0 del; 19 mod Cleaned up the noreg table Reviewed-by: iris ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/7/files - new: https://git.openjdk.java.net/guide/pull/7/files/e96c818f..da865689 Webrevs: - full: https://webrevs.openjdk.java.net/guide/7/webrev.01 - incr: https://webrevs.openjdk.java.net/guide/7/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/guide/pull/7.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/7/head:pull/7 PR: https://git.openjdk.java.net/guide/pull/7 From jwilhelm at openjdk.java.net Wed May 27 16:06:43 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 27 May 2020 16:06:43 GMT Subject: [Rev 02] RFR: Created README for the project In-Reply-To: References: Message-ID: > A readme file that will serve as the GitHub front page for the project. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Updated after review comments This pull request has now been integrated. Changeset: 5bdfab11 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/5bdfab11 Stats: 38 lines in 1 file changed: 0 ins; 38 del; 0 mod Created README for the project Reviewed-by: iris ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/8/files - new: https://git.openjdk.java.net/guide/pull/8/files/07449ce7..4297b0e8 Webrevs: - full: https://webrevs.openjdk.java.net/guide/8/webrev.02 - incr: https://webrevs.openjdk.java.net/guide/8/webrev.01-02 Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/guide/pull/8.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/8/head:pull/8 PR: https://git.openjdk.java.net/guide/pull/8 From jwilhelm at openjdk.java.net Thu May 28 04:26:02 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 28 May 2020 04:26:02 GMT Subject: [Rev 01] RFR: Remove version numbering In-Reply-To: References: Message-ID: <_67-X9AATUCa4RCJ1QmzDknxRnoInAJh56lS869JEOY=.80f50027-ab20-4441-8131-02a16221ddaf@github.com> > Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time > instead. The modification time is currently only placed at the bottom of each file, while the version number was > present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that > decision. It's a simple makefile change to add it at the top as well. Jesper Wilhelmsson has updated the pull request incrementally with four additional commits since the last revision: - Use change hash instead of date in footer - Created README for the project Reviewed-by: iris - Cleaned up the noreg table Reviewed-by: iris - Usign perl instead of sed Reviewed-by: iris ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/9/files - new: https://git.openjdk.java.net/guide/pull/9/files/d6cf9f1b..7c465a48 Webrevs: - full: https://webrevs.openjdk.java.net/guide/9/webrev.01 - incr: https://webrevs.openjdk.java.net/guide/9/webrev.00-01 Stats: 66 lines in 4 files changed: 42 ins; 2 del; 22 mod Patch: https://git.openjdk.java.net/guide/pull/9.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/9/head:pull/9 PR: https://git.openjdk.java.net/guide/pull/9 From jwilhelm at openjdk.java.net Thu May 28 04:29:24 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 28 May 2020 04:29:24 GMT Subject: [Rev 02] RFR: Remove version numbering In-Reply-To: References: Message-ID: On Wed, 27 May 2020 07:23:41 GMT, Iris Clark wrote: >> Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now >> contains six commits: >> - Merge branch 'master' into updates >> - Use change hash instead of date in footer >> - Created README for the project >> >> Reviewed-by: iris >> - Cleaned up the noreg table >> >> Reviewed-by: iris >> - Usign perl instead of sed >> >> Reviewed-by: iris >> - Remove version numbering > > Good to see that adding a footer time/date stamp is straight-forward. Since there is reluctance to add the date to the files I have updated the patch. The original discussion that lead to adding the date actually suggested adding the date or the change hash of each file. This new patch adds the change hash instead. It also adds a link to the change history for each file. ------------- PR: https://git.openjdk.java.net/guide/pull/9 From jwilhelm at openjdk.java.net Thu May 28 04:29:19 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 28 May 2020 04:29:19 GMT Subject: [Rev 02] RFR: Remove version numbering In-Reply-To: References: Message-ID: > Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time > instead. The modification time is currently only placed at the bottom of each file, while the version number was > present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that > decision. It's a simple makefile change to add it at the top as well. Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge branch 'master' into updates - Use change hash instead of date in footer - Created README for the project Reviewed-by: iris - Cleaned up the noreg table Reviewed-by: iris - Usign perl instead of sed Reviewed-by: iris - Remove version numbering ------------- Changes: https://git.openjdk.java.net/guide/pull/9/files Webrev: https://webrevs.openjdk.java.net/guide/9/webrev.02 Stats: 160 lines in 20 files changed: 7 ins; 152 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/9.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/9/head:pull/9 PR: https://git.openjdk.java.net/guide/pull/9 From iris at openjdk.java.net Thu May 28 04:40:06 2020 From: iris at openjdk.java.net (Iris Clark) Date: Thu, 28 May 2020 04:40:06 GMT Subject: [Rev 02] RFR: Remove version numbering In-Reply-To: References: Message-ID: On Thu, 28 May 2020 04:29:19 GMT, Jesper Wilhelmsson wrote: >> Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time >> instead. The modification time is currently only placed at the bottom of each file, while the version number was >> present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that >> decision. It's a simple makefile change to add it at the top as well. > > Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now > contains six commits: > - Merge branch 'master' into updates > - Use change hash instead of date in footer > - Created README for the project > > Reviewed-by: iris > - Cleaned up the noreg table > > Reviewed-by: iris > - Usign perl instead of sed > > Reviewed-by: iris > - Remove version numbering A reasonable alternative to the date. Consider adding a note somewhere (maybe the Guild introduction?) describing where the changehash comes from. ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/9 From david.holmes at oracle.com Thu May 28 04:46:52 2020 From: david.holmes at oracle.com (David Holmes) Date: Thu, 28 May 2020 14:46:52 +1000 Subject: [Rev 02] RFR: Remove version numbering In-Reply-To: References: Message-ID: <83b7aed6-9e4b-0472-eefd-aae11538af7d@oracle.com> On 28/05/2020 2:29 pm, Jesper Wilhelmsson wrote: > On Wed, 27 May 2020 07:23:41 GMT, Iris Clark wrote: > >>> Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now >>> contains six commits: >>> - Merge branch 'master' into updates >>> - Use change hash instead of date in footer >>> - Created README for the project >>> >>> Reviewed-by: iris >>> - Cleaned up the noreg table >>> >>> Reviewed-by: iris >>> - Usign perl instead of sed >>> >>> Reviewed-by: iris >>> - Remove version numbering >> >> Good to see that adding a footer time/date stamp is straight-forward. > > Since there is reluctance to add the date to the files I have updated the patch. The original discussion that lead to > adding the date actually suggested adding the date or the change hash of each file. This new patch adds the change hash > instead. It also adds a link to the change history for each file. I think this is a good compromise. Thanks, David > ------------- > > PR: https://git.openjdk.java.net/guide/pull/9 > From jwilhelm at openjdk.java.net Thu May 28 10:18:18 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 28 May 2020 10:18:18 GMT Subject: RFR: Add gitignore for build directory In-Reply-To: References: Message-ID: On Wed, 27 May 2020 14:11:21 GMT, Martijn Verburg wrote: > Add gitignore for build directory Looks good. Thanks for adding this! I've been meaning to :-) I'll sponsor this as you are not an author in this project yet. ------------- PR: https://git.openjdk.java.net/guide/pull/12 From jwilhelm at openjdk.java.net Thu May 28 10:18:18 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 28 May 2020 10:18:18 GMT Subject: RFR: Add gitignore for build directory In-Reply-To: References: Message-ID: On Wed, 27 May 2020 14:30:39 GMT, Martijn Verburg wrote: >> Looks good. Thanks for adding this! I've been meaning to :-) >> I'll sponsor this as you are not an author in this project yet. > >> Looks good. Thanks for adding this! I've been meaning to :-) >> I'll sponsor this as you are not an author in this project yet. > > Thanks. Any way of getting the bot to recognize that I _have_ signed the OCA already? Please follow the instruction above to open an issue in JBS to get your user name tied to your GitHub account. Robin is standing by to approve it ?? ------------- PR: https://git.openjdk.java.net/guide/pull/12 From martijnverburg at gmail.com Thu May 28 12:22:49 2020 From: martijnverburg at gmail.com (Martijn Verburg) Date: Thu, 28 May 2020 13:22:49 +0100 Subject: RFR: Add gitignore for build directory In-Reply-To: References: Message-ID: Hi Jesper, sadly I'm only a Contributor, not an Author, and therefore cannot open an issue in JBS... Cheers, Martijn On Thu, 28 May 2020 at 11:21, Jesper Wilhelmsson wrote: > On Wed, 27 May 2020 14:30:39 GMT, Martijn Verburg 180840+karianna at openjdk.org> wrote: > > >> Looks good. Thanks for adding this! I've been meaning to :-) > >> I'll sponsor this as you are not an author in this project yet. > > > >> Looks good. Thanks for adding this! I've been meaning to :-) > >> I'll sponsor this as you are not an author in this project yet. > > > > Thanks. Any way of getting the bot to recognize that I _have_ signed > the OCA already? > > Please follow the instruction above to open an issue in JBS to get your > user name tied to your GitHub account. Robin is > standing by to approve it ?? > > ------------- > > PR: https://git.openjdk.java.net/guide/pull/12 > From ihse at openjdk.java.net Thu May 28 12:39:03 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 28 May 2020 12:39:03 GMT Subject: [Rev 02] RFR: Remove version numbering In-Reply-To: References: Message-ID: On Thu, 28 May 2020 04:29:19 GMT, Jesper Wilhelmsson wrote: >> Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time >> instead. The modification time is currently only placed at the bottom of each file, while the version number was >> present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that >> decision. It's a simple makefile change to add it at the top as well. > > Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now > contains six commits: > - Merge branch 'master' into updates > - Use change hash instead of date in footer > - Created README for the project > > Reviewed-by: iris > - Cleaned up the noreg table > > Reviewed-by: iris > - Usign perl instead of sed > > Reviewed-by: iris > - Remove version numbering Looks good. ------------- Marked as reviewed by ihse (no project role). PR: https://git.openjdk.java.net/guide/pull/9 From github.com+180840+karianna at openjdk.java.net Thu May 28 10:18:18 2020 From: github.com+180840+karianna at openjdk.java.net (Martijn Verburg) Date: Thu, 28 May 2020 10:18:18 GMT Subject: RFR: Add gitignore for build directory Message-ID: Add gitignore for build directory ------------- Commit messages: - Adding .gitignore from a branch - Add gitignore for build directory Changes: https://git.openjdk.java.net/guide/pull/12/files Webrev: https://webrevs.openjdk.java.net/guide/12/webrev.00 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/12.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/12/head:pull/12 PR: https://git.openjdk.java.net/guide/pull/12 From github.com+180840+karianna at openjdk.java.net Thu May 28 10:18:18 2020 From: github.com+180840+karianna at openjdk.java.net (Martijn Verburg) Date: Thu, 28 May 2020 10:18:18 GMT Subject: RFR: Add gitignore for build directory In-Reply-To: References: Message-ID: On Wed, 27 May 2020 14:21:38 GMT, Jesper Wilhelmsson wrote: > Looks good. Thanks for adding this! I've been meaning to :-) > I'll sponsor this as you are not an author in this project yet. Thanks. Any way of getting the bot to recognize that I _have_ signed the OCA already? ------------- PR: https://git.openjdk.java.net/guide/pull/12 From github.com+180840+karianna at openjdk.java.net Thu May 28 10:18:18 2020 From: github.com+180840+karianna at openjdk.java.net (Martijn Verburg) Date: Thu, 28 May 2020 10:18:18 GMT Subject: RFR: Add gitignore for build directory In-Reply-To: References: Message-ID: On Wed, 27 May 2020 14:36:11 GMT, Jesper Wilhelmsson wrote: > Please follow the instruction above to open an issue in JBS to get your user name tied to your GitHub account. Robin is > standing by to approve it ?? Hi Jesper, sadly I'm only a Contributor, not an Author, and therefore cannot open an issue in JBS... ------------- PR: https://git.openjdk.java.net/guide/pull/12 From jesper.wilhelmsson at oracle.com Thu May 28 14:56:24 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 28 May 2020 16:56:24 +0200 Subject: RFR: Add gitignore for build directory In-Reply-To: References: Message-ID: <5EF1D616-02C2-4EC3-8A9C-200264791F9C@oracle.com> You are Author in two OpenJDK projects, Amber and Valhalla: http://openjdk.java.net/census#karianna And you do have an JBS account: https://bugs.openjdk.java.net/secure/ViewProfile.jspa?name=karianna Are you logged in to JBS when trying to create the issue? Anyhow, your OCA was recognized and everything seems to be ok for the fix to be pushed now :-) /Jesper > On 28 May 2020, at 14:22, Martijn Verburg wrote: > > Hi Jesper, sadly I'm only a Contributor, not an Author, and therefore > cannot open an issue in JBS... > > Cheers, > Martijn > > > On Thu, 28 May 2020 at 11:21, Jesper Wilhelmsson > wrote: > >> On Wed, 27 May 2020 14:30:39 GMT, Martijn Verburg > 180840+karianna at openjdk.org> wrote: >> >>>> Looks good. Thanks for adding this! I've been meaning to :-) >>>> I'll sponsor this as you are not an author in this project yet. >>> >>>> Looks good. Thanks for adding this! I've been meaning to :-) >>>> I'll sponsor this as you are not an author in this project yet. >>> >>> Thanks. Any way of getting the bot to recognize that I _have_ signed >> the OCA already? >> >> Please follow the instruction above to open an issue in JBS to get your >> user name tied to your GitHub account. Robin is >> standing by to approve it ?? >> >> ------------- >> >> PR: https://git.openjdk.java.net/guide/pull/12 >> From jwilhelm at openjdk.java.net Thu May 28 14:56:37 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 28 May 2020 14:56:37 GMT Subject: RFR: Add gitignore for build directory In-Reply-To: References: Message-ID: <56ZM0m7mLIEuyDLYaGrwDV677-FXPannoToTagGYrhM=.49262535-fa05-430d-a8dc-e5d21f0c378d@github.com> On Wed, 27 May 2020 14:11:21 GMT, Martijn Verburg wrote: > Add gitignore for build directory Marked as reviewed by jwilhelm (Lead). ------------- PR: https://git.openjdk.java.net/guide/pull/12 From martijnverburg at gmail.com Thu May 28 15:19:56 2020 From: martijnverburg at gmail.com (Martijn Verburg) Date: Thu, 28 May 2020 16:19:56 +0100 Subject: RFR: Add gitignore for build directory In-Reply-To: <5EF1D616-02C2-4EC3-8A9C-200264791F9C@oracle.com> References: <5EF1D616-02C2-4EC3-8A9C-200264791F9C@oracle.com> Message-ID: Thanks, and ah yes, I have 'author' status on those projects because I was helping update their wikis on behalf of Brian. I don't think that bit flag propagates to JBS though :-). I still need to submit some patches :-) Cheers, Martijn On Thu, 28 May 2020 at 15:56, Jesper Wilhelmsson < jesper.wilhelmsson at oracle.com> wrote: > You are Author in two OpenJDK projects, Amber and Valhalla: > http://openjdk.java.net/census#karianna > And you do have an JBS account: > https://bugs.openjdk.java.net/secure/ViewProfile.jspa?name=karianna > Are you logged in to JBS when trying to create the issue? > > Anyhow, your OCA was recognized and everything seems to be ok for the fix > to be pushed now :-) > /Jesper > > > > On 28 May 2020, at 14:22, Martijn Verburg > wrote: > > > > Hi Jesper, sadly I'm only a Contributor, not an Author, and therefore > > cannot open an issue in JBS... > > > > Cheers, > > Martijn > > > > > > On Thu, 28 May 2020 at 11:21, Jesper Wilhelmsson < > jwilhelm at openjdk.java.net> > > wrote: > > > >> On Wed, 27 May 2020 14:30:39 GMT, Martijn Verburg >> 180840+karianna at openjdk.org> wrote: > >> > >>>> Looks good. Thanks for adding this! I've been meaning to :-) > >>>> I'll sponsor this as you are not an author in this project yet. > >>> > >>>> Looks good. Thanks for adding this! I've been meaning to :-) > >>>> I'll sponsor this as you are not an author in this project yet. > >>> > >>> Thanks. Any way of getting the bot to recognize that I _have_ signed > >> the OCA already? > >> > >> Please follow the instruction above to open an issue in JBS to get your > >> user name tied to your GitHub account. Robin is > >> standing by to approve it ?? > >> > >> ------------- > >> > >> PR: https://git.openjdk.java.net/guide/pull/12 > >> > > From jesper.wilhelmsson at oracle.com Thu May 28 20:18:59 2020 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 28 May 2020 22:18:59 +0200 Subject: RFR: Add gitignore for build directory In-Reply-To: References: <5EF1D616-02C2-4EC3-8A9C-200264791F9C@oracle.com> Message-ID: <867A2A0C-B0CF-4472-BBD7-980DDE950F54@oracle.com> There was a bug in the configuration of your JBS account. It has been fixed now. Now you should be able to create issues :-) To get your change integrated, just type /integrate in a comment in the review thread on GitHub. /Jesper > On 28 May 2020, at 17:19, Martijn Verburg wrote: > > Thanks, and ah yes, I have 'author' status on those projects because I was helping update their wikis on behalf of Brian. I don't think that bit flag propagates to JBS though :-). I still need to submit some patches :-) > > Cheers, > Martijn > > > On Thu, 28 May 2020 at 15:56, Jesper Wilhelmsson > wrote: > You are Author in two OpenJDK projects, Amber and Valhalla: http://openjdk.java.net/census#karianna > And you do have an JBS account: https://bugs.openjdk.java.net/secure/ViewProfile.jspa?name=karianna > Are you logged in to JBS when trying to create the issue? > > Anyhow, your OCA was recognized and everything seems to be ok for the fix to be pushed now :-) > /Jesper > > > > On 28 May 2020, at 14:22, Martijn Verburg > wrote: > > > > Hi Jesper, sadly I'm only a Contributor, not an Author, and therefore > > cannot open an issue in JBS... > > > > Cheers, > > Martijn > > > > > > On Thu, 28 May 2020 at 11:21, Jesper Wilhelmsson > > > wrote: > > > >> On Wed, 27 May 2020 14:30:39 GMT, Martijn Verburg + > >> 180840+karianna at openjdk.org > wrote: > >> > >>>> Looks good. Thanks for adding this! I've been meaning to :-) > >>>> I'll sponsor this as you are not an author in this project yet. > >>> > >>>> Looks good. Thanks for adding this! I've been meaning to :-) > >>>> I'll sponsor this as you are not an author in this project yet. > >>> > >>> Thanks. Any way of getting the bot to recognize that I _have_ signed > >> the OCA already? > >> > >> Please follow the instruction above to open an issue in JBS to get your > >> user name tied to your GitHub account. Robin is > >> standing by to approve it ?? > >> > >> ------------- > >> > >> PR: https://git.openjdk.java.net/guide/pull/12 > >> > From jwilhelm at openjdk.java.net Thu May 28 20:22:37 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 28 May 2020 20:22:37 GMT Subject: [Integrated] RFR: Remove version numbering In-Reply-To: References: Message-ID: On Mon, 25 May 2020 21:56:46 GMT, Jesper Wilhelmsson wrote: > Removed release notes and version numbers from all pages. Added a footer which displays file modification date and time > instead. The modification time is currently only placed at the bottom of each file, while the version number was > present both at the top and at the bottom. This was made on purpose. Please leave a comment if you disagree with that > decision. It's a simple makefile change to add it at the top as well. This pull request has now been integrated. Changeset: 0b28107f Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/0b28107f Stats: 160 lines in 20 files changed: 152 ins; 7 del; 1 mod Remove version numbering Reviewed-by: iris, ihse ------------- PR: https://git.openjdk.java.net/guide/pull/9 From martijnverburg at gmail.com Thu May 28 22:11:18 2020 From: martijnverburg at gmail.com (Martijn Verburg) Date: Thu, 28 May 2020 23:11:18 +0100 Subject: RFR: Add gitignore for build directory In-Reply-To: <867A2A0C-B0CF-4472-BBD7-980DDE950F54@oracle.com> References: <5EF1D616-02C2-4EC3-8A9C-200264791F9C@oracle.com> <867A2A0C-B0CF-4472-BBD7-980DDE950F54@oracle.com> Message-ID: Perfect thank you! Cheers, Martijn On Thu, 28 May 2020 at 21:19, Jesper Wilhelmsson < jesper.wilhelmsson at oracle.com> wrote: > There was a bug in the configuration of your JBS account. It has been > fixed now. Now you should be able to create issues :-) > > To get your change integrated, just type /integrate in a comment in the > review thread on GitHub. > /Jesper > > > On 28 May 2020, at 17:19, Martijn Verburg > wrote: > > Thanks, and ah yes, I have 'author' status on those projects because I was > helping update their wikis on behalf of Brian. I don't think that bit flag > propagates to JBS though :-). I still need to submit some patches :-) > > Cheers, > Martijn > > > On Thu, 28 May 2020 at 15:56, Jesper Wilhelmsson < > jesper.wilhelmsson at oracle.com> wrote: > >> You are Author in two OpenJDK projects, Amber and Valhalla: >> http://openjdk.java.net/census#karianna >> And you do have an JBS account: >> https://bugs.openjdk.java.net/secure/ViewProfile.jspa?name=karianna >> Are you logged in to JBS when trying to create the issue? >> >> Anyhow, your OCA was recognized and everything seems to be ok for the fix >> to be pushed now :-) >> /Jesper >> >> >> > On 28 May 2020, at 14:22, Martijn Verburg >> wrote: >> > >> > Hi Jesper, sadly I'm only a Contributor, not an Author, and therefore >> > cannot open an issue in JBS... >> > >> > Cheers, >> > Martijn >> > >> > >> > On Thu, 28 May 2020 at 11:21, Jesper Wilhelmsson < >> jwilhelm at openjdk.java.net> >> > wrote: >> > >> >> On Wed, 27 May 2020 14:30:39 GMT, Martijn Verburg > >> 180840+karianna at openjdk.org> wrote: >> >> >> >>>> Looks good. Thanks for adding this! I've been meaning to :-) >> >>>> I'll sponsor this as you are not an author in this project yet. >> >>> >> >>>> Looks good. Thanks for adding this! I've been meaning to :-) >> >>>> I'll sponsor this as you are not an author in this project yet. >> >>> >> >>> Thanks. Any way of getting the bot to recognize that I _have_ signed >> >> the OCA already? >> >> >> >> Please follow the instruction above to open an issue in JBS to get your >> >> user name tied to your GitHub account. Robin is >> >> standing by to approve it ?? >> >> >> >> ------------- >> >> >> >> PR: https://git.openjdk.java.net/guide/pull/12 >> >> >> >> > From github.com+180840+karianna at openjdk.java.net Fri May 29 04:44:30 2020 From: github.com+180840+karianna at openjdk.java.net (Martijn Verburg) Date: Fri, 29 May 2020 04:44:30 GMT Subject: [Integrated] RFR: Add gitignore for build directory In-Reply-To: References: Message-ID: <-CBy6jY9sMfmsmv0rYe8v_OsiE1Elwwr1iNM8wKunFM=.2696f0fe-7cf2-4646-a82f-d2e5a1886005@github.com> On Wed, 27 May 2020 14:11:21 GMT, Martijn Verburg wrote: > Add gitignore for build directory This pull request has now been integrated. Changeset: 05e6cbb5 Author: Martijn Verburg Committer: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/05e6cbb5 Stats: 8 lines in 1 file changed: 0 ins; 8 del; 0 mod Add gitignore for build directory Reviewed-by: jwilhelm ------------- PR: https://git.openjdk.java.net/guide/pull/12 From jwilhelm at openjdk.java.net Fri May 29 11:56:27 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 29 May 2020 11:56:27 GMT Subject: RFR: Markdown anchors Message-ID: Found how to do link anchors in markdown. Added anchors in the glossary as well. Also changed to short hash in the footer, the long hash took over the whole page in the final published version. ------------- Commit messages: - Markdown anchors Changes: https://git.openjdk.java.net/guide/pull/13/files Webrev: https://webrevs.openjdk.java.net/guide/13/webrev.00 Stats: 28 lines in 4 files changed: 0 ins; 0 del; 28 mod Patch: https://git.openjdk.java.net/guide/pull/13.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/13/head:pull/13 PR: https://git.openjdk.java.net/guide/pull/13 From ihse at openjdk.java.net Fri May 29 12:11:48 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Fri, 29 May 2020 12:11:48 GMT Subject: RFR: Markdown anchors In-Reply-To: References: Message-ID: On Fri, 29 May 2020 11:50:04 GMT, Jesper Wilhelmsson wrote: > Found how to do link anchors in markdown. Added anchors in the glossary as well. Also changed to short hash in the > footer, the long hash took over the whole page in the final published version. Marked as reviewed by ihse (no project role). ------------- PR: https://git.openjdk.java.net/guide/pull/13 From iris at openjdk.java.net Fri May 29 14:50:41 2020 From: iris at openjdk.java.net (Iris Clark) Date: Fri, 29 May 2020 14:50:41 GMT Subject: RFR: Markdown anchors In-Reply-To: References: Message-ID: <9sW5bX7oPXksvvQJ0x0A0NuXeZ04ENou663lLUxlWeQ=.6cd1e81a-d14f-4913-9622-a6c7281f51a2@github.com> On Fri, 29 May 2020 11:50:04 GMT, Jesper Wilhelmsson wrote: > Found how to do link anchors in markdown. Added anchors in the glossary as well. Also changed to short hash in the > footer, the long hash took over the whole page in the final published version. Looks good. ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/13 From jwilhelm at openjdk.java.net Fri May 29 16:21:29 2020 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 29 May 2020 16:21:29 GMT Subject: [Integrated] RFR: Markdown anchors In-Reply-To: References: Message-ID: <1pMfv5LZDvdpxweseXWHU-0S_I3mwS4PL3ZBLLOgFmQ=.dc18550d-76c4-4020-89c6-94b87b63a03a@github.com> On Fri, 29 May 2020 11:50:04 GMT, Jesper Wilhelmsson wrote: > Found how to do link anchors in markdown. Added anchors in the glossary as well. Also changed to short hash in the > footer, the long hash took over the whole page in the final published version. This pull request has now been integrated. Changeset: 211220f0 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/211220f0 Stats: 28 lines in 4 files changed: 0 ins; 0 del; 28 mod Markdown anchors Reviewed-by: ihse, iris ------------- PR: https://git.openjdk.java.net/guide/pull/13