RFR: Added section for newcomers [v5]
Stuart Marks
smarks at openjdk.java.net
Thu Nov 19 04:37:15 UTC 2020
On Thu, 19 Nov 2020 04:20:23 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:
>> Added a section to the introduction to set the expectations for new developers in the OpenJDK.
>>
>> I also moved the mail list section up since it's also relevant in this context and should (imho) be the first thing to learn about when thinking about joining the community.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>
> sponsor role and github username
Marked as reviewed by smarks (no project role).
src/index.md line 29:
> 27: ### 1. Sign the OCA
> 28:
> 29: Oracle is the stewards of the OpenJDK project, and owns the Java brand. In order to make your patch available for review you must first sign the [Oracle Contributor Agreement](https://www.oracle.com/technical-resources/oracle-contributor-agreement.html) (OCA). This agreement gives Oracle and you as a contributor joint copyright interests in the code. You will retain your copyright while also granting those rights to Oracle.
OK, now it's American/British usage (whether a company name is singular or plural) vs. noun-verb agreement. I thought "Oracle are the stewards..." was ok for British usage (but as an American, what do I know). I'm also OK with making "Oracle" singular but then "steward" should be singular too. That is, "Oracle is the steward of the OpenJDK project, ...."
src/index.md line 65:
> 63: * **Hidden constraints and assumptions**. Many sections of code have constraints and assumptions that aren't necessarily visible at first glance. This might preclude certain changes, even those that might seem obvious.
> 64:
> 65: * **Stability and quality**. The JDK is used by millions of developers and as a widely deployed commercial product, it is held to a high standard of quality. Changes should include tests where practical, and core tests should pass at all times. The value of the change should outweigh the risk of introducing a bug, or performance regression.
Remove comma before "or performance regression." But yes, mentioning performance is very important.
-------------
PR: https://git.openjdk.java.net/guide/pull/38
More information about the guide-dev
mailing list