RFR: Added section for newcomers [v6]
Magnus Ihse Bursie
ihse at openjdk.java.net
Thu Nov 19 14:08:10 UTC 2020
On Thu, 19 Nov 2020 13:25:23 GMT, Marius Volkhart <github.com+1709517+MariusVolkhart at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed typos
>
> src/index.md line 35:
>
>> 33: ### 2. Socialize your change
>> 34:
>> 35: Once the OCA is signed, please restrain your urge to create a PR just a little while longer. In order to prepare the community for your patch, please socialize your idea on the relevant [mailing lists](#mailing-lists). To understand the criteria by which your patch is going to be judged, please read [_Why is My Change Rejected?_](#why-is-my-change-rejected) below. In short, hidden constraints and assumptions, stability and quality, maintainability, compatibility, and conformance to specifications must be considered before your PR is ready to be submitted. If you don't understand the constraints for acceptance, you might be surprised when your PR is rejected.
>
> One of the benefits of making the PR is that the openjdk bot tags the PR with the appropriate mailing list. Being a first time contributor, finding the relevant mailing list was not easy (there are just a lot of lists! �� ) - I was very relieved when the PR bot added the tag. I'm not suggesting this text be changed, just adding my experience.
Maybe a better suggestion is to open the PR in draft mode? This means tthere is no requirement for a JBS issue number, and no RFR mail will be sent out -- but the bot still populates the proper tags, if I recall correctly.
I agree that getting assistance from the bot in finding a reasonable starting set of lists is good support for newcomers (even if it might need adjustment; but someone on the targeted lists can certainly help with that).
-------------
PR: https://git.openjdk.java.net/guide/pull/38
More information about the guide-dev
mailing list