RFR: Initial section on testing [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.java.net
Mon Oct 19 22:14:17 UTC 2020
On Mon, 19 Oct 2020 21:17:35 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updates suggested by Phil and Igor
>
> src/index.md line 441:
>
>> 439: EXPECT_GT(val1, val2);
>> 440: EXPECT_GE(val1, val2);
>> 441: EXPECT_STREQ(expected_str, actual_str);
>
> do we really need to list these guys here? referring to google test documentations seems to be enough.
>
> in case there is a good reason to have this list here, `ASSERT_TRUE` and `ASSERT_FALSE` can be removed b/c the
> following paragraph explains that all these macros have an `ASSERT` variant.
Agreed. I wanted to have just a couple but couldn't choose which ones :-)
I have removed most but kept a few just to have some examples to talk about.
-------------
PR: https://git.openjdk.java.net/guide/pull/30
More information about the guide-dev
mailing list