RFR: Initial section on testing [v6]

Lance Andersen lancea at openjdk.java.net
Thu Oct 22 15:21:18 UTC 2020


On Tue, 20 Oct 2020 10:50:28 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> It's a start.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Link to html version of testing docs

src/index.md line 350:

> 348: * The test should pass reliably on all supported platforms - watch out for platform-specific differences such as path separators
> 349: 
> 350: The JTReg documentation has a section on [how to write good JTReg tests](https://openjdk.java.net/jtreg/writetests.html).

Perhaps include a comment to indicate that binary files should not be checked into the workspace and if the test needs to use one, the test should create it in some fashion.

Also if possible avoid shell scripts and relying on external commands as much as necessary.

src/index.md line 370:

> 368:             }
> 369:         }
> 370:     }

Should there be a mention of trying to be consistent with other tests in a test folder, that is if they are using TestNG,  follow that pattern

Should we indicate when to use a TEST.properties file vs. including the properties within the test?

-------------

PR: https://git.openjdk.java.net/guide/pull/30


More information about the guide-dev mailing list