RFR: Initial section on testing [v6]

Igor Ignatyev iignatyev at openjdk.java.net
Thu Oct 22 16:33:22 UTC 2020


On Wed, 21 Oct 2020 03:46:41 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Link to html version of testing docs
>
> I think the addition of some conceptual testing information is sufficient for now, with the possibility of adding more discussion later.

> _Mailing list message from [Lance Andersen](mailto:LANCE.ANDERSEN at ORACLE.COM) on [guide-dev](mailto:guide-dev at openjdk.java.net):_
> 
> Understand, and I guess my point was should the use of TEST.properties be covered in the dev guide of just left to the JTREG pages. It would be nice to have best practices flushed out.
> 
> Best
> Lance

Hi Lance,

I agree that we need to write down the best practices and have them easily available and discoverable, but I don't think that the Guide is the right place for them. I see the Guide as a QuickStart or How To Start Hacking OpenJDK In 5 Minutes (as opposed to The Comprehension OpenJDK Guide: How To Do All Possible Things Right And What Things Not To Do).  if we start to add all best practices to the guide, inevitably they will either be superficially covered or we end up with lots of information and overwhelm readers, both cases will result in poor comprehension and I'd argue would undermine the purpose of this document and will cause more confusion.

so I'd prefer not to cover `TEST.properties` here, instead, I suggest creating a ticket to document common best practices in `/doc/jtreg-tests.md` in the jdk repo, and list `TEST.properties` as one of the things we need to document.

Cheers,
-- Igor

-------------

PR: https://git.openjdk.java.net/guide/pull/30


More information about the guide-dev mailing list