RFR: Adding mapping from source to mail list [v2]

[Jesper Wilhelmsson]

On Fri, 28 Aug 2020 19:40:27 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated with Iris' additions
>
> How much of this is replicated by the similar list which Skara will use to generate the mailing list for pull request
> notifications?  If the Skara version is expected to be maintained more closely because of use, then perhaps the Guide
> should just reference it after it appears in jdk/jdk?  On the topic of pr notifications, I think that this mail,
> providing details for how the mailing list for pull requests is created and may be modified is Guide-worthy either as a
> direct reference or as a copy and modify to handle evolution:
> https://mail.openjdk.java.net/pipermail/jdk-dev/2020-August/004677.html

Thank you for the review Iris!  All additions have been made.
As for the file added by Skara I'm not sure how easy that one will be for new developers to access and read. We should
definitely mention it once it's in place. One difference with the current list is that I've included directories from
older JDK versions as well, it's not only mainline. I'm not sure how Skara will handle older releases in this regard.

Anyhow, we can remove/update the list later should it turn out to be duplicated information.

> src/codeowners.md line 110:
> 
>> 109:     * `libverify` –
>> 110:     * `libzip` –
>> 111: * `java.compiler` – LangTools
> 
> Core Libs

Fixed.

> src/codeowners.md line 109:
> 
>> 108:     * `libosxsecurity` �� Security
>> 109:     * `libverify` –
>> 110:     * `libzip` –
> 
> LangTools

Fixed.

> src/codeowners.md line 101:
> 
>> 100:     * `launcher` – Langtools
>> 101:     * `libfdlibm` –
>> 102:     * `libjava` – Core Libs
> 
> Core Libs

Fixed.

> src/codeowners.md line 95:
> 
>> 94:   * `lib/security` – Security
>> 95:   * `man` –
>> 96:   * `native`
> 
> This depends on who owns the tool.  I believe that this entry corresponds to this part of the repo:
> 
> https://hg.openjdk.java.net/jdk/jdk/file/ec0cabbc527f/src/java.base/share/man
> 
> I see that there are man pages for java, jfr, and keytool.
> 
> Further down in this list I see that mail for the launcher is being directed to LangTools, so that's where I'd send
> changes for the java man page.
> Changes to the jdk.jfr module are being sent to Runtime, so that's where changes to the corresponding man page should
> be sent.
> keytool is owned by Security.

Fixed.

> src/codeowners.md line 100:
> 
>> 99:     * `jspawnhelper` – LangTools
>> 100:     * `launcher` – Langtools
>> 101:     * `libfdlibm` –
> 
> "LangTools" instead of "Langtools"?  (capitalization)  Check for other occurrences.

Fixed.

> src/codeowners.md line 74:
> 
>> 73: * `java.base`
>> 74:   * Core Libs should almost always be included but Langtools, HotSpot, and/or Security may also be involved.
>> 75:   * `classes`
> 
> I18n also owns code in java.base.

Fixed.

> src/codeowners.md line 87:
> 
>> 86:     * `security` – Security
>> 87:     * `text` – Core Libs
>> 88:     * `time` – Core Libs
> 
> I18n owns the java.text package.

Fixed.

-------------

PR: https://git.openjdk.java.net/guide/pull/25