RFR: Added JBS Label Dictionary

[David Holmes]

On 1/09/2020 11:32 pm, Jesper Wilhelmsson wrote:
>> On 1 Sep 2020, at 15:08, David Holmes <david.holmes at oracle.com> wrote:
>>
>> On 1/09/2020 9:40 pm, Jesper Wilhelmsson wrote:
>>>> On 1 Sep 2020, at 09:30, David Holmes <david.holmes at oracle.com> wrote:
>>>>
>>>> On 1/09/2020 3:41 pm, Jesper Wilhelmsson wrote:
>>>>> Hi David.
>>>>> I think the easiest way is to pull the branch from the PR and build it locally. There are additional fonts and stylesheets that will be in use once the page hits the webserver, but the local result is good enough to get a sense of the page I think.
>>>>
>>>> Took longer than anticipated due to pandoc issues :)
>>> Is there anything we can to update in the instructions in the readme to avoid that others run into the same issues?
>>
>> Version requirements for pandoc would be good. I installed pandoc via yum install on my OEL7.4 system and it didn't support the flags the makefile was using. So then I had to tweak things so that make found the pandoc that was installed by jib and which did work.
> 
> Do you happen to have the version numbers for the two versions you tried?  I started to look through the pandoc source history but it was fairly time consuming to find where all flags were introduced :-)

Working version: 2.3.1
Bad version: 1.12.3.1

Cheers,
David

> Thanks,
> /Jesper
> 
>>
>> Cheers,
>> David
>>
>>>> Typo: pahes
>>> Fixed.
>>>> Does "integration-blocker" have any meaning now?
>>> It can still be used in project repos and the client repo. Don't think anyone actually use it right now though. But I think we will see more shared workspaces as we move to git since it's so much easier to just share a fork or a branch so it may come back :-)
>>>> The font/formatting for foo-bar-(Rel) doesn't look good as the "(Rel)" part seems much bigger than the monospaced font used for the foo-bar- part. But that may just be a stylesheet issue with the local view.
>>> Yes I see that too. Looking at the final web version of the Guide tt-text has the same size as normal text, so I hope that will look better once published. If not I will adress it in a separate change.
>>>> Otherwise seems okay to me.
>>> Thank you!
>>> /Jesper
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>>> /Jesper
>>>>>> On 1 Sep 2020, at 06:49, David Holmes <david.holmes at oracle.com> wrote:
>>>>>>
>>>>>> Hi Jesper,
>>>>>>
>>>>>> How do we actually view this in a readable format?
>>>>>>
>>>>>> Thanks,
>>>>>> David
>>>>>>
>>>>>> On 1/09/2020 2:26 pm, Jesper Wilhelmsson wrote:
>>>>>>> Moving the JBS label Dictionary from the OpenJDK wiki into the Guide. Did some updates of the text.
>>>>>>> I'm guessing this dictionary is missing several labels used by libraries and client since it has a hotspot background.
>>>>>>> Please let me know what labels to add (or just add them).
>>>>>>> I also moved the noreg-* description from "Change Planning" into this dictionary as I think it fits better here. All
>>>>>>> labels have anchors so you can link directly to any label in the dictionary.
>>>>>>> -------------
>>>>>>> Commit messages:
>>>>>>>   - Added JBS Label Dictionary
>>>>>>> Changes: https://git.openjdk.java.net/guide/pull/26/files
>>>>>>>   Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=26&range=00
>>>>>>>    Stats: 616 lines in 3 files changed: 493 ins; 95 del; 28 mod
>>>>>>>    Patch: https://git.openjdk.java.net/guide/pull/26.diff
>>>>>>>    Fetch: git fetch https://git.openjdk.java.net/guide pull/26/head:pull/26
>>>>>>> PR: https://git.openjdk.java.net/guide/pull/26
>