RFR: Section on cloning [v3]

Jesper Wilhelmsson jwilhelm at openjdk.java.net
Thu Aug 12 23:06:37 UTC 2021


On Thu, 12 Aug 2021 20:01:37 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates after review
>
> src/index.md line 999:
> 
>> 997: 
>> 998:     $ git clone git at github.com:JesperIRL/jdk.git
>> 999:     $ git remote add upstream git at github.com:openjdk/jdk.git
> 
> I typically recommend using https for the "fetch" URL and "ssh" (i.e., `git@`) for the push URL. More importantly, I don't recommend using ssh at all for the upstream repo, since it is read-only for developers. Here is my suggestion:
> 
> 
> $ git clone https://github.com/JesperIRL/jdk.git
> $ cd jdk
> $ git remote set-url origin --push git at github.com:JesperIRL/jdk.git
> $ git remote add upstream https://github.com/openjdk/jdk.git
> 
> 
> If you prefer not to introduce the complexity of separate fetch and push URLs for `origin`, I at least would like to see an `https` URL for the upstream.

How do we motivate recommending https for upstream? I mean it's not as if people can push regardless. Is there a git convention to use https for read only repos?

-------------

PR: https://git.openjdk.java.net/guide/pull/59


More information about the guide-dev mailing list