RFR: Cleanup contractions [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.java.net
Thu Feb 4 04:07:45 UTC 2021
On Sat, 30 Jan 2021 06:43:37 GMT, Stuart Marks <smarks at openjdk.org> wrote:
>> I'm fine with doing more changes to this paragraph in this change. Better that than the changes not happening because it's too much work to create a new PR. In my opinion it's not as important to have an easy way to track down changes in a document like this as it is with source code.
>>
>> If you use the GitHub Web UI for review you can edit the file directly here in the PR and suggest a change.
>
> Hm, I couldn't figure out how to edit in-place, so I just copied the text and made the edits below:
>
> A change that is small, well contained, and that makes no semantic changes. Typical examples are fixing obvious typos or renaming a local identifier. A trivial change can also be pushing an already-reviewed change that was missed in an earlier push (e.g., forgot to add a file) or generated changes like an [`hg backout`](#backing-out-a-change). It's up to the author of a change to claim that the change is trivial in the RFR, and it's up to the Reviewer whether to approve such a claim. A change is trivial only if the Reviewer agrees that it is. A trivial change doesn't need to wait 24 hours before being pushed, and it only needs one Reviewer, even in areas where stricter rules for pushing normally apply.
If you go to "Files changed". There are three dots in the upper right corner, click them to display a menu with the option to edit the file.
-------------
PR: https://git.openjdk.java.net/guide/pull/42
More information about the guide-dev
mailing list