RFR: Cleanup contractions
Stuart Marks
smarks at openjdk.java.net
Fri Jan 29 00:02:48 UTC 2021
On Thu, 28 Jan 2021 21:49:35 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:
> An attempt to unify the language in the guide with regards to contractions. There was a (very brief) discussion on this on the mailing list: https://mail.openjdk.java.net/pipermail/guide-dev/2020-December/000444.html
>
> is not --> isn't
> do not --> don't
> are not --> aren't
> etc
Marked as reviewed by smarks (Author).
src/index.md line 917:
> 915:
> 916: **Yes**
> 917: : It's often sufficient to build and test on a single platform, but sometimes it's not. Use discretion.
Possibly change to "... but sometimes it isn't." This might read a bit more smoothly, though it might be TOO informal.
src/index.md line 1789:
> 1787:
> 1788: [**trivial**]{#trivial}
> 1789: : A change that is small, well contained, and makes no semantic changes. Typically fixing obvious typos or renaming some local identifier. Trivial changes can also be pushing an already reviewed change that was missed in an earlier push (e.g. forgot to add a file) or generated changes like an [`hg backout`](#backing-out-a-change). It's up to the author of a change to claim that the change is trivial in the RFR, and it's up to the Reviewer whether to approve such a claim. A change is only trivial if the Reviewer says so. Trivial changes doesn't have to wait 24 hours before being pushed, and only needs one Reviewer, even in areas where stricter rules for pushing normally applies.
Unrelated to contractions, but I happened to notice this.... The last sentence needs to be either singular or plural. Either "Trivial changes don't have to wait..." or "A trivial change doesn't need to wait..." and similar for need/needs in the second half of the sentence.
This paragraph flips between singular and plural a couple times. I think I prefer singular. Or maybe this is better left to a separate editing pass, as this paragraph would benefit from other adjustments as well.
-------------
PR: https://git.openjdk.java.net/guide/pull/42
More information about the guide-dev
mailing list