RFR: Section on PRs
Jesper Wilhelmsson
jwilhelm at openjdk.java.net
Wed Apr 6 19:16:01 UTC 2022
On Wed, 6 Apr 2022 17:15:21 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> Some tips for creating pull requests.
>
> 1. Do we need to say anything about testing? For example, we might want to say that each commit into a PR branch should compile and pass tests.
> 2. Do we need to add more rationale why PR should be generally kept up to date with respect to mainline, and especially just before they are integrated?
@pavelrappo
1. I think the section on testing should cover these parts. Me may want to say something about the PR specific testing though, like GHA. Could you please provide an example of what you want to add?
2. Maybe :-) Any specific phrasing you would like to see?
-------------
PR: https://git.openjdk.java.net/guide/pull/79
More information about the guide-dev
mailing list