RFR: Section on PRs [v2]

[Phil Race]

On Wed, 6 Apr 2022 19:25:48 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Some tips for creating pull requests.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added sentence about keeping PR up to date

src/index.md line 1457:

> 1455: 
> 1456: Once you have made a change that you want to integrate into an OpenJDK code base you need to create a _Pull Request_ (PR) on GitHub. This guide assumes that you have previous experience from using git and GitHub and won't go into details of how things work. Still, the aim is of course to provide a useful guide, so speak up if more details are needed.
> 1457: 

of how things work ->  of how those work 

so speak up if more details are needed.

"so send email to  guide dot dev at openjdk dot java net if ..." ?

src/index.md line 1473:

> 1471: 
> 1472:    The description of the PR should state what problem is being solved and shortly describe how it's solved. Reviewers and other interested readers are referred to the text in the JBS issue for details, but the description should be enough to give an overview.
> 1473: 

This means the JBS issue should have an evaluation so you may want to explicitly say so.

src/index.md line 1481:

> 1479: 
> 1480:    In general all PRs should be open for at least 24 hours to allow for reviewers in all time zones to get a chance to see it. In some areas [trivial](#trivial) changes are allowed to be pushed without the 24 hour delay. Ask your reviewers if you think this applies to your change.
> 1481: 

Also at least one reviewer should be knowledgeable in the area being changed.
And some areas (eg client) require two reviewers except for safe changes  such as tests and docs. So be sure to read the relevant openjdk group pages for any advice.

-------------

PR: https://git.openjdk.java.net/guide/pull/79