RFR: Section on PRs [v2]

[Phil Race]

On Thu, 7 Apr 2022 17:56:42 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added sentence about keeping PR up to date
>
> src/index.md line 1484:
> 
>> 1482: #. **Merge the latest changes**
>> 1483: 
>> 1484:    Before pushing you should always fetch and merge the latest changes from the target repository. If your PR is out for review for a longer time it is a good habit to pull from the target repository regularly to keep the change up to date.
> 
> While the advice to keep up to date is good, the "Before pushing you should always" admonition is too strong. The vast majority of PRs are integrated without being exactly at the latest HEAD of master, and I can't recall the last time it was a problem. If your PR was merged (or created) yesterday, and the only changes that have gone in since then were a few unrelated fixes, it seems like unnecessary churn to ask them to merge right before integrating (especially since unless they are willing to rebuild and test, it is pointless). I do recommend encouraging merging, especially if you are too many commits out of date, or if there has been a significant change that might affect your fix. You might also add a note that a reviewer can always ask for the PR author to merge if they feel it would be wise.

Yeah I don't agree with what was written. There's always changes in the upstream repo. Unless it relates to what I am changing I don't see the need. There can be 100 changes in hotspot and I don't care because it doesn't affect my change to Linux X11 code ..

-------------

PR: https://git.openjdk.java.net/guide/pull/79