RFR: Section on PRs [v2]
Jesper Wilhelmsson
jwilhelm at openjdk.java.net
Sat Apr 9 01:41:48 UTC 2022
On Thu, 7 Apr 2022 19:26:49 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Mostly the above test covers it. Remembering that the description is included in many emails.
>>
>> Two things bug me about some PR descriptions; those that are too long and too short.
>> The too long ones I've seen can Include extensive performance before/after information.
>> They should be added in a separate comment after the description.
>> The too short ones are the lazy ones that just refer to the bugid.
>>
>> I'm not sure where to suggest notes to this effect are inserted.
>>
>> I'd also prefer to see PRs that are complete when they are created.
>> Code changes, test additions, copyrights updated, all done.
>> It is annoying to see a dribble of minor updates and accompanying emails
>> while the developer works through their own thought processes.
>> And even updating minor changes due to comments should be batched.
>> But this may be a developer style issue, to each their own, but why should I witness every change.
>
> Maybe suggest that the PR is created in `Draft` if it isn't yet complete? It won't be `rfr` and won't be sent to any manling list until it is taken out of Draft.
I've added a sub-section to talk about things to think about before creating the PR. Feel free to add more items to that list.
-------------
PR: https://git.openjdk.java.net/guide/pull/79
More information about the guide-dev
mailing list