RFR: Section on PRs [v2]

Jesper Wilhelmsson jwilhelm at openjdk.java.net
Sat Apr 9 01:41:52 UTC 2022


On Thu, 7 Apr 2022 19:57:16 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Yeah I don't agree with what was written. There's always changes in the upstream repo. Unless it relates to what I am changing I don't see the need. There can be 100 changes in hotspot and I don't care because it doesn't affect my change to Linux X11 code ..
>
>> Unless it relates to what I am changing I don't see the need. There can be 100 changes in hotspot and I don't care because it doesn't affect my change to Linux X11 code ..
> 
> Maybe it should be a suggestion?
> 
> If one is an experienced contributor, which is unlikely to be true for all the contributors reading the guide, one has good judgement on what is acceptable and what isn't. Because in general, until one runs tests for A+B, one cannot be sure that those tests will pass if they pass for A and B individually.

Re-phrased.

-------------

PR: https://git.openjdk.java.net/guide/pull/79


More information about the guide-dev mailing list