Text about not using rebase/force-push in PRs..?

David Holmes david.holmes at oracle.com
Fri Jan 28 13:31:55 UTC 2022


On 28/01/2022 6:46 pm, Magnus Ihse Bursie wrote:
> Didn't we have some text saying not to use rebase, but use merge 
> instead, in PRs? I wanted to send a link to a contributor that did this, 
> but I can't find it. I could have sworn it was discussed here; did it 
> end up never getting pushed to the guide?

It is in the Skara FAQ:

https://wiki.openjdk.java.net/display/SKARA/FAQ

How do I modify the changes in a pull request?

To modify your patch in a pull request, just push more changes to the 
branch the pull request is based on. Avoid modifying changes that are 
already part of the pull request branch or force pushing unrelated 
changes as that will mess up the pull request and make it hard for 
reviewers to make sense of it. When Skara integrates the pull request, 
all the changes will be squashed into a single change anyway.

--

David

> /Magnus


More information about the guide-dev mailing list