From jwilhelm at openjdk.java.net Thu May 5 23:05:29 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 5 May 2022 23:05:29 GMT Subject: RFR: GitHub Actions Message-ID: Encouraging developers to enable GHA on their personal forks. ------------- Commit messages: - GitHub Actions Changes: https://git.openjdk.java.net/guide/pull/80/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=00 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/80.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/80/head:pull/80 PR: https://git.openjdk.java.net/guide/pull/80 From kcr at openjdk.java.net Thu May 5 23:34:12 2022 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Thu, 5 May 2022 23:34:12 GMT Subject: RFR: GitHub Actions In-Reply-To: References: Message-ID: On Thu, 5 May 2022 23:00:06 GMT, Jesper Wilhelmsson wrote: > Encouraging developers to enable GHA on their personal forks. src/index.md line 1303: > 1301: ## GitHub Actions > 1302: > 1303: GitHub has a feature called **GitHub Actions** (GHA) that can be used to automate testing. The GHA is executed whenever a PR is created or updated in the repository. The GHA in the JDK project is configured to run a set of tests that is commonly known as **tier 1**. This is a relatively fast, small set of tests that tries to verify that your change didn't break the JDK completely. In tier 1 the JDK is built on a small set of platforms including (but not necessarily limited to) Linux, Windows, and MacOS, and a few tests are executed using these builds. One correction: Once enabled in your repo it runs on a push to a branch in your repo, not just when you create a PR. Skara will show the results of the test run when you create or update a PR. ------------- PR: https://git.openjdk.java.net/guide/pull/80 From jwilhelm at openjdk.java.net Fri May 6 00:42:57 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 6 May 2022 00:42:57 GMT Subject: RFR: GitHub Actions [v2] In-Reply-To: References: Message-ID: > Encouraging developers to enable GHA on their personal forks. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Fix ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/80/files - new: https://git.openjdk.java.net/guide/pull/80/files/c52f302d..d2df771a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=01 - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/80.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/80/head:pull/80 PR: https://git.openjdk.java.net/guide/pull/80 From jwilhelm at openjdk.java.net Fri May 6 00:42:59 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 6 May 2022 00:42:59 GMT Subject: RFR: GitHub Actions [v2] In-Reply-To: References: Message-ID: On Thu, 5 May 2022 23:28:15 GMT, Kevin Rushforth wrote: >> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix > > src/index.md line 1303: > >> 1301: ## GitHub Actions >> 1302: >> 1303: GitHub has a feature called **GitHub Actions** (GHA) that can be used to automate testing. The GHA is executed whenever a PR is created or updated in the repository. The GHA in the JDK project is configured to run a set of tests that is commonly known as **tier 1**. This is a relatively fast, small set of tests that tries to verify that your change didn't break the JDK completely. In tier 1 the JDK is built on a small set of platforms including (but not necessarily limited to) Linux, Windows, and MacOS, and a few tests are executed using these builds. > > One correction: Once enabled in your repo it runs on a push to a branch in your repo, not just when you create a PR. Skara will show the results of the test run when you create or update a PR. Thanks for this clarification! ------------- PR: https://git.openjdk.java.net/guide/pull/80 From magnus.ihse.bursie at oracle.com Fri May 6 13:18:23 2022 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Fri, 6 May 2022 15:18:23 +0200 Subject: RFR: GitHub Actions [v2] In-Reply-To: References: Message-ID: <208ed86e-8dd3-ec98-457e-a4aa387e7b91@oracle.com> I'd like to see some mention of the fickleness of the GHA testing. That it is prone to breakage that is not caused by changes in the JDK, but in the GHA runtime environment. And some emphasis that we do not control this environment, and that debugging this is hard. (Perhaps a recommendation that if any error pops up in GHA, that you try to reproduce it on an environment where you have better control; both if there is an actual bug, since it is easier to debug, and to verify if it really is an issue with the code and not the GHA environment.) Or, to phrase it differently: by all means let people know how to enable it, but help them set reasonable expectations -- not just for how much (or rather, how little) is tested, but also for how stable the testing is. /Magnus On 2022-05-06 02:42, Jesper Wilhelmsson wrote: >> Encouraging developers to enable GHA on their personal forks. > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fix > > ------------- > > Changes: > - all: https://git.openjdk.java.net/guide/pull/80/files > - new: https://git.openjdk.java.net/guide/pull/80/files/c52f302d..d2df771a > > Webrevs: > - full: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=01 > - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=00-01 > > Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod > Patch: https://git.openjdk.java.net/guide/pull/80.diff > Fetch: git fetch https://git.openjdk.java.net/guide pull/80/head:pull/80 > > PR: https://git.openjdk.java.net/guide/pull/80 From kcr at openjdk.java.net Fri May 6 13:48:02 2022 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 6 May 2022 13:48:02 GMT Subject: RFR: GitHub Actions [v2] In-Reply-To: References: Message-ID: On Fri, 6 May 2022 00:42:57 GMT, Jesper Wilhelmsson wrote: >> Encouraging developers to enable GHA on their personal forks. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fix Looks good. Magnus has a fair point about GHA runs being prone to things like external updates (although there are usually folks in the community who will jump on those and get our GHA scripts fixed pretty quickly when needed, they do cause spurious errors for a while when it happens). I think his recommendation to try to reproduce failures on an environment you control is a good one. ------------- Marked as reviewed by kcr (no project role). PR: https://git.openjdk.java.net/guide/pull/80 From jwilhelm at openjdk.java.net Fri May 6 18:30:02 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 6 May 2022 18:30:02 GMT Subject: RFR: GitHub Actions [v3] In-Reply-To: References: Message-ID: > Encouraging developers to enable GHA on their personal forks. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: reproduce locally ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/80/files - new: https://git.openjdk.java.net/guide/pull/80/files/d2df771a..ad7c5916 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=02 - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=01-02 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/80.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/80/head:pull/80 PR: https://git.openjdk.java.net/guide/pull/80 From jwilhelm at openjdk.java.net Fri May 6 18:30:05 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 6 May 2022 18:30:05 GMT Subject: RFR: GitHub Actions [v2] In-Reply-To: References: Message-ID: On Fri, 6 May 2022 00:42:57 GMT, Jesper Wilhelmsson wrote: >> Encouraging developers to enable GHA on their personal forks. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fix Thanks for these comments. I have added a few sentences to highlight this. ------------- PR: https://git.openjdk.java.net/guide/pull/80 From kcr at openjdk.java.net Fri May 6 21:31:00 2022 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 6 May 2022 21:31:00 GMT Subject: RFR: GitHub Actions [v3] In-Reply-To: References: Message-ID: On Fri, 6 May 2022 18:30:02 GMT, Jesper Wilhelmsson wrote: >> Encouraging developers to enable GHA on their personal forks. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > reproduce locally The new sentence look good to me with two wording comments inline. src/index.md line 1307: > 1305: In addition to the testing you run manually before publishing your changes, it's recommended that you take advantage of this automated testing that the GHA offers. To enable this on your personal fork of the JDK on GitHub go to the "Actions" tab and click the big green button saying "I understand my workflows, go ahead and enable them". If you don't understand these workflows there's a link to the actual file that describes them right below the green button. > 1306: > 1307: In case of failures in the GHA it's always a good start to try to reproduce the failure locally on a machine where you have better control and easier access to a debug environment. There has been cases where the GHA has failed due to issues unrelated to the change being tested, e.g. because the GHA environment was updated and changes was needed to the JDK GHA configuration. The configuration is in general updated fairly quickly, so in cases were you can't reproduce the failure locally, consider re-running the GHA later. Minor: that should be "There _have_ been cases where..." and later "and changes _were_ needed to the JDK GHA" ------------- Marked as reviewed by kcr (no project role). PR: https://git.openjdk.java.net/guide/pull/80 From jwilhelm at openjdk.java.net Fri May 6 22:19:48 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 6 May 2022 22:19:48 GMT Subject: RFR: GitHub Actions [v4] In-Reply-To: References: Message-ID: <1eu-ZfgjlI7LH2iJQO6FGNwKJ3cLcW1eZ5y_RX5fcUY=.23703f78-ed18-44a5-87d5-089aec9cf6d2@github.com> > Encouraging developers to enable GHA on their personal forks. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Fix ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/80/files - new: https://git.openjdk.java.net/guide/pull/80/files/ad7c5916..69ae1fa4 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=03 - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/guide/pull/80.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/80/head:pull/80 PR: https://git.openjdk.java.net/guide/pull/80 From jwilhelm at openjdk.java.net Fri May 6 22:19:49 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Fri, 6 May 2022 22:19:49 GMT Subject: RFR: GitHub Actions [v3] In-Reply-To: References: Message-ID: On Fri, 6 May 2022 21:25:33 GMT, Kevin Rushforth wrote: >> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: >> >> reproduce locally > > src/index.md line 1307: > >> 1305: In addition to the testing you run manually before publishing your changes, it's recommended that you take advantage of this automated testing that the GHA offers. To enable this on your personal fork of the JDK on GitHub go to the "Actions" tab and click the big green button saying "I understand my workflows, go ahead and enable them". If you don't understand these workflows there's a link to the actual file that describes them right below the green button. >> 1306: >> 1307: In case of failures in the GHA it's always a good start to try to reproduce the failure locally on a machine where you have better control and easier access to a debug environment. There has been cases where the GHA has failed due to issues unrelated to the change being tested, e.g. because the GHA environment was updated and changes was needed to the JDK GHA configuration. The configuration is in general updated fairly quickly, so in cases were you can't reproduce the failure locally, consider re-running the GHA later. > > Minor: that should be "There _have_ been cases where..." and later "and changes _were_ needed to the JDK GHA" Good catch! Fixed. ------------- PR: https://git.openjdk.java.net/guide/pull/80 From kcr at openjdk.java.net Fri May 6 22:32:07 2022 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Fri, 6 May 2022 22:32:07 GMT Subject: RFR: GitHub Actions [v4] In-Reply-To: <1eu-ZfgjlI7LH2iJQO6FGNwKJ3cLcW1eZ5y_RX5fcUY=.23703f78-ed18-44a5-87d5-089aec9cf6d2@github.com> References: <1eu-ZfgjlI7LH2iJQO6FGNwKJ3cLcW1eZ5y_RX5fcUY=.23703f78-ed18-44a5-87d5-089aec9cf6d2@github.com> Message-ID: On Fri, 6 May 2022 22:19:48 GMT, Jesper Wilhelmsson wrote: >> Encouraging developers to enable GHA on their personal forks. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fix Marked as reviewed by kcr (no project role). ------------- PR: https://git.openjdk.java.net/guide/pull/80 From jesper.wilhelmsson at oracle.com Fri May 6 23:08:39 2022 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Fri, 6 May 2022 23:08:39 +0000 Subject: Dividing the guide source file by section Message-ID: Hi all, Most of the shuffling around and major cleanups in the Guide should be done by now and I think it's time to perform a division of the source file as proposed by Magnus in PR#47. https://github.com/openjdk/guide/pull/47 I do have a few requests for such a split and this mail is sent to gather any other such requests before the work on the makefile starts. My thinking so far: * Each source file should be named more or less the same as the section it contains. I don't want to say exactly the same because eventually some typo is found or a section is renamed slightly and I don't want that to enforce a rename of the file. I'll quantify it by saying that the section name and the file name should be 80% the same. Obviously that's just a random number that seems fine for now. * There should not be any serial numbers in the file names. It must be simple to add new sections in the middle of the guide, and to move a section to a different place. This implies that there must be a separate file that contains the order of the sections. I'm fine with this file to be of any readable, easy editable format. Plain text, XML, markdown - whatever makes it easy to use. * All section files in the src directory must be included in the composed guide file. If a section file on disk is not present in the index, a build error should be generated. I don't want to have section files that are place holders or things that maybe should be included at some point in there. We could have a separate directory for such files if anyone think that is a good idea. There are currently a couple of files in there that aren't part of the guide today, these must be taken care of before this can be a reality. I'll leave it here for now. Any other suggestions are welcome! /Jesper From prr at openjdk.java.net Fri May 6 23:15:09 2022 From: prr at openjdk.java.net (Phil Race) Date: Fri, 6 May 2022 23:15:09 GMT Subject: RFR: GitHub Actions [v4] In-Reply-To: <1eu-ZfgjlI7LH2iJQO6FGNwKJ3cLcW1eZ5y_RX5fcUY=.23703f78-ed18-44a5-87d5-089aec9cf6d2@github.com> References: <1eu-ZfgjlI7LH2iJQO6FGNwKJ3cLcW1eZ5y_RX5fcUY=.23703f78-ed18-44a5-87d5-089aec9cf6d2@github.com> Message-ID: <3cKG4-TOXb9H-_MAscP6WXvbVfRuao3EBdI5ZteBp4U=.9d913f51-6b63-419b-b072-239faea6923d@github.com> On Fri, 6 May 2022 22:19:48 GMT, Jesper Wilhelmsson wrote: >> Encouraging developers to enable GHA on their personal forks. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Fix 1) Conversely to Magnus' point it might build with GHA but not with OpenJDK recommended tool chains. Still this is STREETS ahead of you not building at all on Windows (say) since you don't have access. 2) You could say that you can get *some* idea of what tier1 means for hotspot and libraries by looking at the jtreg TEST.groups files in the repo (you can provide links) and you'll quickly see that many important tests and whole areas are not covered at all by tier1. ------------- PR: https://git.openjdk.java.net/guide/pull/80 From magnus.ihse.bursie at oracle.com Mon May 9 13:37:14 2022 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Mon, 9 May 2022 15:37:14 +0200 Subject: Dividing the guide source file by section In-Reply-To: References: Message-ID: On 2022-05-07 01:08, Jesper Wilhelmsson wrote: > Hi all, > > Most of the shuffling around and major cleanups in the Guide should be done by now and I think it's time to perform a division of the source file as proposed by Magnus in PR#47. > > https://github.com/openjdk/guide/pull/47 Would you like me to refresh my PR with the current up-to-date contents of the guide? /Magnus > > I do have a few requests for such a split and this mail is sent to gather any other such requests before the work on the makefile starts. > > My thinking so far: > > * Each source file should be named more or less the same as the section it contains. I don't want to say exactly the same because eventually some typo is found or a section is renamed slightly and I don't want that to enforce a rename of the file. I'll quantify it by saying that the section name and the file name should be 80% the same. Obviously that's just a random number that seems fine for now. > > * There should not be any serial numbers in the file names. It must be simple to add new sections in the middle of the guide, and to move a section to a different place. This implies that there must be a separate file that contains the order of the sections. I'm fine with this file to be of any readable, easy editable format. Plain text, XML, markdown - whatever makes it easy to use. > > * All section files in the src directory must be included in the composed guide file. If a section file on disk is not present in the index, a build error should be generated. I don't want to have section files that are place holders or things that maybe should be included at some point in there. We could have a separate directory for such files if anyone think that is a good idea. There are currently a couple of files in there that aren't part of the guide today, these must be taken care of before this can be a reality. > > > I'll leave it here for now. Any other suggestions are welcome! > /Jesper > From jesper.wilhelmsson at oracle.com Mon May 9 15:04:30 2022 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Mon, 9 May 2022 15:04:30 +0000 Subject: Dividing the guide source file by section In-Reply-To: References: Message-ID: > 9 maj 2022 kl. 15:37 skrev Magnus Ihse Bursie : > > ?On 2022-05-07 01:08, Jesper Wilhelmsson wrote: > >> Hi all, >> >> Most of the shuffling around and major cleanups in the Guide should be done by now and I think it's time to perform a division of the source file as proposed by Magnus in PR#47. >> >> https://github.com/openjdk/guide/pull/47 > > Would you like me to refresh my PR with the current up-to-date contents of the guide? Either that or create a new PR. Whichever you think is the easiest. The version in PR#47 do have the chapter numbers in the file names, so it will need some more work though. /Jesper > > /Magnus > >> >> I do have a few requests for such a split and this mail is sent to gather any other such requests before the work on the makefile starts. >> >> My thinking so far: >> >> * Each source file should be named more or less the same as the section it contains. I don't want to say exactly the same because eventually some typo is found or a section is renamed slightly and I don't want that to enforce a rename of the file. I'll quantify it by saying that the section name and the file name should be 80% the same. Obviously that's just a random number that seems fine for now. >> >> * There should not be any serial numbers in the file names. It must be simple to add new sections in the middle of the guide, and to move a section to a different place. This implies that there must be a separate file that contains the order of the sections. I'm fine with this file to be of any readable, easy editable format. Plain text, XML, markdown - whatever makes it easy to use. >> >> * All section files in the src directory must be included in the composed guide file. If a section file on disk is not present in the index, a build error should be generated. I don't want to have section files that are place holders or things that maybe should be included at some point in there. We could have a separate directory for such files if anyone think that is a good idea. There are currently a couple of files in there that aren't part of the guide today, these must be taken care of before this can be a reality. >> >> >> I'll leave it here for now. Any other suggestions are welcome! >> /Jesper >> From jwilhelm at openjdk.java.net Tue May 10 22:20:41 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 10 May 2022 22:20:41 GMT Subject: RFR: Links and lists Message-ID: Stylistic changes in lists. Fixed some links. Clarified wording in JBS label dictionary and added a label. ------------- Commit messages: - Links and tables Changes: https://git.openjdk.java.net/guide/pull/81/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=81&range=00 Stats: 46 lines in 2 files changed: 29 ins; 0 del; 17 mod Patch: https://git.openjdk.java.net/guide/pull/81.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/81/head:pull/81 PR: https://git.openjdk.java.net/guide/pull/81 From iris at openjdk.java.net Tue May 10 22:27:10 2022 From: iris at openjdk.java.net (Iris Clark) Date: Tue, 10 May 2022 22:27:10 GMT Subject: RFR: Links and lists In-Reply-To: References: Message-ID: On Tue, 10 May 2022 22:15:12 GMT, Jesper Wilhelmsson wrote: > Stylistic changes in lists. > Fixed some links. > Clarified wording in JBS label dictionary and added a label. Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/guide/pull/81 From jwilhelm at openjdk.java.net Wed May 11 08:33:02 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 11 May 2022 08:33:02 GMT Subject: RFR: Links and lists In-Reply-To: References: Message-ID: On Tue, 10 May 2022 22:15:12 GMT, Jesper Wilhelmsson wrote: > Stylistic changes in lists. > Fixed some links. > Clarified wording in JBS label dictionary and added a label. Thank you Iris! ------------- PR: https://git.openjdk.java.net/guide/pull/81 From jwilhelm at openjdk.java.net Wed May 11 08:33:02 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 11 May 2022 08:33:02 GMT Subject: Integrated: Links and lists In-Reply-To: References: Message-ID: On Tue, 10 May 2022 22:15:12 GMT, Jesper Wilhelmsson wrote: > Stylistic changes in lists. > Fixed some links. > Clarified wording in JBS label dictionary and added a label. This pull request has now been integrated. Changeset: 18330fe3 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/18330fe38670f848a59b78f3069d498e11cb7ef9 Stats: 46 lines in 2 files changed: 29 ins; 0 del; 17 mod Links and lists Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/81 From jwilhelm at openjdk.java.net Wed May 11 22:30:46 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 11 May 2022 22:30:46 GMT Subject: RFR: GitHub Actions [v5] In-Reply-To: References: Message-ID: > Encouraging developers to enable GHA on their personal forks. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Link to jdk/test ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/80/files - new: https://git.openjdk.java.net/guide/pull/80/files/69ae1fa4..64afe49b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=04 - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=80&range=03-04 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/guide/pull/80.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/80/head:pull/80 PR: https://git.openjdk.java.net/guide/pull/80 From jwilhelm at openjdk.java.net Wed May 11 22:30:46 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Wed, 11 May 2022 22:30:46 GMT Subject: RFR: GitHub Actions [v4] In-Reply-To: <3cKG4-TOXb9H-_MAscP6WXvbVfRuao3EBdI5ZteBp4U=.9d913f51-6b63-419b-b072-239faea6923d@github.com> References: <1eu-ZfgjlI7LH2iJQO6FGNwKJ3cLcW1eZ5y_RX5fcUY=.23703f78-ed18-44a5-87d5-089aec9cf6d2@github.com> <3cKG4-TOXb9H-_MAscP6WXvbVfRuao3EBdI5ZteBp4U=.9d913f51-6b63-419b-b072-239faea6923d@github.com> Message-ID: On Fri, 6 May 2022 23:11:21 GMT, Phil Race wrote: >> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix > > 1) Conversely to Magnus' point it might build with GHA but not with OpenJDK recommended tool chains. > Still this is STREETS ahead of you not building at all on Windows (say) since you don't have access. > > 2) You could say that you can get *some* idea of what tier1 means for hotspot and libraries by looking at the jtreg TEST.groups files in the repo (you can provide links) and you'll quickly see that many important tests and whole areas are not covered at all by tier1. Yes, I think you have a good point here @prrace. I've added a note about running platforms one may not otherwise have access to and mentioned the TEST.groups files with a link. ------------- PR: https://git.openjdk.java.net/guide/pull/80 From iris at openjdk.java.net Thu May 12 01:56:10 2022 From: iris at openjdk.java.net (Iris Clark) Date: Thu, 12 May 2022 01:56:10 GMT Subject: RFR: GitHub Actions [v5] In-Reply-To: References: Message-ID: On Wed, 11 May 2022 22:30:46 GMT, Jesper Wilhelmsson wrote: >> Encouraging developers to enable GHA on their personal forks. > > Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: > > Link to jdk/test Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/guide/pull/80 From jwilhelm at openjdk.java.net Thu May 12 06:29:07 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 12 May 2022 06:29:07 GMT Subject: Integrated: GitHub Actions In-Reply-To: References: Message-ID: On Thu, 5 May 2022 23:00:06 GMT, Jesper Wilhelmsson wrote: > Encouraging developers to enable GHA on their personal forks. This pull request has now been integrated. Changeset: d6aa238c Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/d6aa238cf1cfedb6881a9ff7798288bf8d107256 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod GitHub Actions Reviewed-by: kcr, iris ------------- PR: https://git.openjdk.java.net/guide/pull/80 From ihse at openjdk.java.net Thu May 12 13:57:50 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 12 May 2022 13:57:50 GMT Subject: RFR: Split up the monolithic index.md, take two Message-ID: Here's a resurrection of my old code to split up the monolithic index.md. I have fully recreated the per-chapter files based on the current content of index.md. I have removed the number prefix and instead the order of the files are determined by `src/toc.conf`. By my quick inspection, the generated index.html looks identical to the one before. I found some inconsistencies when doing this. For instance most, but not all, chapters end with a ::: {.box} [To the top](#){.boxheader} ::: footer. A reasonable follow-up is to move these per-chapter footers out of the actual markdown, and inject them when combining the file instead. This means less redundancy, and no more inconsistencies. ;-) ------------- Commit messages: - Code conventions mistakenly slipped into Mailing lists as well - Add build support for combining split-up markdown files - Split index.md into per-chapter files Changes: https://git.openjdk.java.net/guide/pull/82/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=82&range=00 Stats: 4808 lines in 22 files changed: 2386 ins; 2418 del; 4 mod Patch: https://git.openjdk.java.net/guide/pull/82.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/82/head:pull/82 PR: https://git.openjdk.java.net/guide/pull/82 From magnus.ihse.bursie at oracle.com Thu May 12 14:09:19 2022 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Thu, 12 May 2022 16:09:19 +0200 Subject: Dividing the guide source file by section In-Reply-To: References: Message-ID: On 2022-05-07 01:08, Jesper Wilhelmsson wrote: > Hi all, > > Most of the shuffling around and major cleanups in the Guide should be done by now and I think it's time to perform a division of the source file as proposed by Magnus in PR#47. > > https://github.com/openjdk/guide/pull/47 > > I do have a few requests for such a split and this mail is sent to gather any other such requests before the work on the makefile starts. > > My thinking so far: > > * Each source file should be named more or less the same as the section it contains. I don't want to say exactly the same because eventually some typo is found or a section is renamed slightly and I don't want that to enforce a rename of the file. I'll quantify it by saying that the section name and the file name should be 80% the same. Obviously that's just a random number that seems fine for now. I don't think you should be so afraid of renames. Just trust your feelings Luke. And Git rename functionality. > > * There should not be any serial numbers in the file names. It must be simple to add new sections in the middle of the guide, and to move a section to a different place. This implies that there must be a separate file that contains the order of the sections. I'm fine with this file to be of any readable, easy editable format. Plain text, XML, markdown - whatever makes it easy to use. > > * All section files in the src directory must be included in the composed guide file. Note that the src directory contains more files than index.md. I'm not sure what the purpose of these files are. But to make this work, I needed to put the chapters in a separate folder. If we ever remove those extra files, we could presumably move the chapters up to the "src" level. Not sure it's worth it, though. > If a section file on disk is not present in the index, a build error should be generated. Missed that part, fixed now. /Magnus > I don't want to have section files that are place holders or things that maybe should be included at some point in there. We could have a separate directory for such files if anyone think that is a good idea. There are currently a couple of files in there that aren't part of the guide today, these must be taken care of before this can be a reality. > > > I'll leave it here for now. Any other suggestions are welcome! > /Jesper > From magnus.ihse.bursie at oracle.com Thu May 12 14:10:39 2022 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Thu, 12 May 2022 16:10:39 +0200 Subject: Dividing the guide source file by section In-Reply-To: References: Message-ID: <1d020091-18d4-15c6-6ada-f0d3c81eb744@oracle.com> On 2022-05-12 16:09, Magnus Ihse Bursie wrote: > > > On 2022-05-07 01:08, Jesper Wilhelmsson wrote: >> Hi all, >> >> Most of the shuffling around and major cleanups in the Guide should >> be done by now and I think it's time to perform a division of the >> source file as proposed by Magnus in PR#47. >> >> https://github.com/openjdk/guide/pull/47 >> >> I do have a few requests for such a split and this mail is sent to >> gather any other such requests before the work on the makefile starts. >> >> My thinking so far: >> >> * Each source file should be named more or less the same as the >> section it contains. I don't want to say exactly the same because >> eventually some typo is found or a section is renamed slightly and I >> don't want that to enforce a rename of the file. I'll quantify it by >> saying that the section name and the file name should be 80% the >> same. Obviously that's just a random number that seems fine for now. > I don't think you should be so afraid of renames. Just trust your > feelings Luke. And Git rename functionality. .. but I named each file using the corresponding kebab-case version of it's title anyway. I think that is a good convention to keep. /Magnus >> >> * There should not be any serial numbers in the file names. It must >> be simple to add new sections in the middle of the guide, and to move >> a section to a different place. This implies that there must be a >> separate file that contains the order of the sections. I'm fine with >> this file to be of any readable, easy editable format. Plain text, >> XML, markdown - whatever makes it easy to use. >> >> * All section files in the src directory must be included in the >> composed guide file. > > Note that the src directory contains more files than index.md. I'm not > sure what the purpose of these files are. But to make this work, I > needed to put the chapters in a separate folder. If we ever remove > those extra files, we could presumably move the chapters up to the > "src" level. Not sure it's worth it, though. >> If a section file on disk is not present in the index, a build error >> should be generated. > Missed that part, fixed now. > > /Magnus > >> I don't want to have section files that are place holders or things >> that maybe should be included at some point in there. We could have a >> separate directory for such files if anyone think that is a good >> idea. There are currently a couple of files in there that aren't part >> of the guide today, these must be taken care of before this can be a >> reality. >> >> >> I'll leave it here for now. Any other suggestions are welcome! >> /Jesper >> > From ihse at openjdk.java.net Thu May 12 14:11:06 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 12 May 2022 14:11:06 GMT Subject: RFR: Split up the monolithic index.md, take two [v2] In-Reply-To: References: Message-ID: > Here's a resurrection of my old code to split up the monolithic index.md. > > I have fully recreated the per-chapter files based on the current content of index.md. I have removed the number prefix and instead the order of the files are determined by `src/toc.conf`. > > By my quick inspection, the generated index.html looks identical to the one before. > > I found some inconsistencies when doing this. For instance most, but not all, chapters end with a > > ::: {.box} > [To the top](#){.boxheader} > ::: > > footer. A reasonable follow-up is to move these per-chapter footers out of the actual markdown, and inject them when combining the file instead. This means less redundancy, and no more inconsistencies. ;-) Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: If the TOC does not match reality, fail with a build error ------------- Changes: - all: https://git.openjdk.java.net/guide/pull/82/files - new: https://git.openjdk.java.net/guide/pull/82/files/6e63ebe1..585911cb Webrevs: - full: https://webrevs.openjdk.java.net/?repo=guide&pr=82&range=01 - incr: https://webrevs.openjdk.java.net/?repo=guide&pr=82&range=00-01 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/82.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/82/head:pull/82 PR: https://git.openjdk.java.net/guide/pull/82 From jwilhelm at openjdk.java.net Thu May 12 15:15:19 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 12 May 2022 15:15:19 GMT Subject: RFR: Split up the monolithic index.md, take two [v2] In-Reply-To: References: Message-ID: On Thu, 12 May 2022 14:11:06 GMT, Magnus Ihse Bursie wrote: >> Here's a resurrection of my old code to split up the monolithic index.md. >> >> I have fully recreated the per-chapter files based on the current content of index.md. I have removed the number prefix and instead the order of the files are determined by `src/toc.conf`. >> >> By my quick inspection, the generated index.html looks identical to the one before. >> >> I found some inconsistencies when doing this. For instance most, but not all, chapters end with a >> >> ::: {.box} >> [To the top](#){.boxheader} >> ::: >> >> footer. A reasonable follow-up is to move these per-chapter footers out of the actual markdown, and inject them when combining the file instead. This means less redundancy, and no more inconsistencies. ;-) > > Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: > > If the TOC does not match reality, fail with a build error Thanks for doing this Magnus! Looks good! Makefile line 12: > 10: LEGACY_MD := $(wildcard src/*.md) > 11: LEGACY_FOOTER := $(patsubst src/%.md, build/support/footers/%.html, $(LEGACY_MD)) > 12: LEGACY_RESULT := $(patsubst src/%.md, build/dist/%.html, $(LEGACY_MD)) Why legacy? ------------- Marked as reviewed by jwilhelm (Lead). PR: https://git.openjdk.java.net/guide/pull/82 From jesper.wilhelmsson at oracle.com Thu May 12 15:30:46 2022 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 12 May 2022 15:30:46 +0000 Subject: Dividing the guide source file by section In-Reply-To: References: Message-ID: > On 12 May 2022, at 16:09, Magnus Ihse Bursie wrote: > On 2022-05-07 01:08, Jesper Wilhelmsson wrote: >> Hi all, >> >> Most of the shuffling around and major cleanups in the Guide should be done by now and I think it's time to perform a division of the source file as proposed by Magnus in PR#47. >> >> https://github.com/openjdk/guide/pull/47 >> >> I do have a few requests for such a split and this mail is sent to gather any other such requests before the work on the makefile starts. >> >> My thinking so far: >> >> * Each source file should be named more or less the same as the section it contains. I don't want to say exactly the same because eventually some typo is found or a section is renamed slightly and I don't want that to enforce a rename of the file. I'll quantify it by saying that the section name and the file name should be 80% the same. Obviously that's just a random number that seems fine for now. > I don't think you should be so afraid of renames. Just trust your feelings Luke. And Git rename functionality. I'm not afraid of renames, I'm just too lazy to perform them. >> * There should not be any serial numbers in the file names. It must be simple to add new sections in the middle of the guide, and to move a section to a different place. This implies that there must be a separate file that contains the order of the sections. I'm fine with this file to be of any readable, easy editable format. Plain text, XML, markdown - whatever makes it easy to use. >> >> * All section files in the src directory must be included in the composed guide file. > > Note that the src directory contains more files than index.md. I'm not sure what the purpose of these files are. But to make this work, I needed to put the chapters in a separate folder. If we ever remove those extra files, we could presumably move the chapters up to the "src" level. Not sure it's worth it, though. Those extra files can be removed. They provide no value anymore. /Jesper >> If a section file on disk is not present in the index, a build error should be generated. > Missed that part, fixed now. > > /Magnus > >> I don't want to have section files that are place holders or things that maybe should be included at some point in there. We could have a separate directory for such files if anyone think that is a good idea. There are currently a couple of files in there that aren't part of the guide today, these must be taken care of before this can be a reality. >> >> >> I'll leave it here for now. Any other suggestions are welcome! >> /Jesper >> > From ihse at openjdk.java.net Thu May 12 17:17:01 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 12 May 2022 17:17:01 GMT Subject: RFR: Split up the monolithic index.md, take two [v2] In-Reply-To: References: Message-ID: <-0UR14NgXO3egf6FjQHZE8tFY8Qs94crt4wnJCo9fRY=.beaf97b0-36e0-4951-aef0-d2140bd4224f@github.com> On Thu, 12 May 2022 15:11:14 GMT, Jesper Wilhelmsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: >> >> If the TOC does not match reality, fail with a build error > > Makefile line 12: > >> 10: LEGACY_MD := $(wildcard src/*.md) >> 11: LEGACY_FOOTER := $(patsubst src/%.md, build/support/footers/%.html, $(LEGACY_MD)) >> 12: LEGACY_RESULT := $(patsubst src/%.md, build/dist/%.html, $(LEGACY_MD)) > > Why legacy? I dunno. I needed to call it something. :-) If you explain to me the purpose of `codeReview.md`, `jckAcquisition.md`, `reviewBodies.md` and `webrevHelp.md`, I can give it a better name. My impression was that this was some old files that will be replaced by the guide in the fullness of time. ------------- PR: https://git.openjdk.java.net/guide/pull/82 From jwilhelm at openjdk.java.net Thu May 12 19:06:19 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 12 May 2022 19:06:19 GMT Subject: RFR: Split up the monolithic index.md, take two [v2] In-Reply-To: <-0UR14NgXO3egf6FjQHZE8tFY8Qs94crt4wnJCo9fRY=.beaf97b0-36e0-4951-aef0-d2140bd4224f@github.com> References: <-0UR14NgXO3egf6FjQHZE8tFY8Qs94crt4wnJCo9fRY=.beaf97b0-36e0-4951-aef0-d2140bd4224f@github.com> Message-ID: On Thu, 12 May 2022 17:14:14 GMT, Magnus Ihse Bursie wrote: >> Makefile line 12: >> >>> 10: LEGACY_MD := $(wildcard src/*.md) >>> 11: LEGACY_FOOTER := $(patsubst src/%.md, build/support/footers/%.html, $(LEGACY_MD)) >>> 12: LEGACY_RESULT := $(patsubst src/%.md, build/dist/%.html, $(LEGACY_MD)) >> >> Why legacy? > > I dunno. I needed to call it something. :-) If you explain to me the purpose of `codeReview.md`, `jckAcquisition.md`, > `reviewBodies.md` and `webrevHelp.md`, I can give it a better name. My impression was that this was some old files that will be replaced by the guide in the fullness of time. Oh, I replied in the other mail thread :-) Those files can be removed. ------------- PR: https://git.openjdk.java.net/guide/pull/82 From ihse at openjdk.java.net Thu May 12 19:48:08 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 12 May 2022 19:48:08 GMT Subject: RFR: Split up the monolithic index.md, take two [v2] In-Reply-To: References: <-0UR14NgXO3egf6FjQHZE8tFY8Qs94crt4wnJCo9fRY=.beaf97b0-36e0-4951-aef0-d2140bd4224f@github.com> Message-ID: <105LjUpusbPzDhmciFwf7kaD89NnUByY1ssWQHGoCes=.1b6d6ccb-34a9-4ba1-8532-23d44005d4c3@github.com> On Thu, 12 May 2022 19:02:49 GMT, Jesper Wilhelmsson wrote: >> I dunno. I needed to call it something. :-) If you explain to me the purpose of `codeReview.md`, `jckAcquisition.md`, >> `reviewBodies.md` and `webrevHelp.md`, I can give it a better name. My impression was that this was some old files that will be replaced by the guide in the fullness of time. > > Oh, I replied in the other mail thread :-) Those files can be removed. I'll do that first, then. ------------- PR: https://git.openjdk.java.net/guide/pull/82 From ihse at openjdk.java.net Thu May 12 20:02:47 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 12 May 2022 20:02:47 GMT Subject: RFR: Remove unused files Message-ID: Jesper asked me to remove those files :). If I do this before splitting index.md, that patch gets easier. ------------- Commit messages: - Remove unused files. Changes: https://git.openjdk.java.net/guide/pull/83/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=83&range=00 Stats: 187 lines in 4 files changed: 0 ins; 187 del; 0 mod Patch: https://git.openjdk.java.net/guide/pull/83.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/83/head:pull/83 PR: https://git.openjdk.java.net/guide/pull/83 From iris at openjdk.java.net Thu May 12 20:18:05 2022 From: iris at openjdk.java.net (Iris Clark) Date: Thu, 12 May 2022 20:18:05 GMT Subject: RFR: Remove unused files In-Reply-To: References: Message-ID: On Thu, 12 May 2022 19:57:18 GMT, Magnus Ihse Bursie wrote: > Jesper asked me to remove those files :). If I do this before splitting index.md, that patch gets easier. src/codeReview.md line 1: > 1: % Community Code Review The contents of this file was never integrated into the Guide so I don't think it should be removed quite yet. ------------- PR: https://git.openjdk.java.net/guide/pull/83 From jwilhelm at openjdk.java.net Thu May 12 20:22:08 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 12 May 2022 20:22:08 GMT Subject: RFR: Remove unused files In-Reply-To: References: Message-ID: On Thu, 12 May 2022 20:14:39 GMT, Iris Clark wrote: >> Jesper asked me to remove those files :). If I do this before splitting index.md, that patch gets easier. > > src/codeReview.md line 1: > >> 1: % Community Code Review > > The contents of this file was never integrated into the Guide so I don't think it should be removed quite yet. I have a local copy of that content that I'll be integrating shortly so removing the file now is fine. I did however notice that the URL cr.openjdk.java.net is redirected to this file, so before we push this change to the web server we need to change that to point into the guide. ------------- PR: https://git.openjdk.java.net/guide/pull/83 From ihse at openjdk.java.net Thu May 12 20:54:18 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 12 May 2022 20:54:18 GMT Subject: RFR: Remove unused files In-Reply-To: References: Message-ID: On Thu, 12 May 2022 19:57:18 GMT, Magnus Ihse Bursie wrote: > Jesper asked me to remove those files :). If I do this before splitting index.md, that patch gets easier. Sounds like it's better to push the split as it is now, and remove these files later, after you've updated the cr link and pushed your local copy. Withdrawing for now. Let's revisit this cleanup later. ------------- PR: https://git.openjdk.java.net/guide/pull/83 From ihse at openjdk.java.net Thu May 12 20:54:18 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 12 May 2022 20:54:18 GMT Subject: Withdrawn: Remove unused files In-Reply-To: References: Message-ID: On Thu, 12 May 2022 19:57:18 GMT, Magnus Ihse Bursie wrote: > Jesper asked me to remove those files :). If I do this before splitting index.md, that patch gets easier. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/guide/pull/83 From ihse at openjdk.java.net Thu May 12 20:55:23 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 12 May 2022 20:55:23 GMT Subject: RFR: Split up the monolithic index.md, take two [v2] In-Reply-To: References: Message-ID: On Thu, 12 May 2022 14:11:06 GMT, Magnus Ihse Bursie wrote: >> Here's a resurrection of my old code to split up the monolithic index.md. >> >> I have fully recreated the per-chapter files based on the current content of index.md. I have removed the number prefix and instead the order of the files are determined by `src/toc.conf`. >> >> By my quick inspection, the generated index.html looks identical to the one before. >> >> I found some inconsistencies when doing this. For instance most, but not all, chapters end with a >> >> ::: {.box} >> [To the top](#){.boxheader} >> ::: >> >> footer. A reasonable follow-up is to move these per-chapter footers out of the actual markdown, and inject them when combining the file instead. This means less redundancy, and no more inconsistencies. ;-) > > Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: > > If the TOC does not match reality, fail with a build error I'll push this change now. We can clean up the rest later, when the legacy files can be fully removed. ------------- PR: https://git.openjdk.java.net/guide/pull/82 From ihse at openjdk.java.net Thu May 12 20:55:24 2022 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 12 May 2022 20:55:24 GMT Subject: Integrated: Split up the monolithic index.md, take two In-Reply-To: References: Message-ID: On Thu, 12 May 2022 13:50:45 GMT, Magnus Ihse Bursie wrote: > Here's a resurrection of my old code to split up the monolithic index.md. > > I have fully recreated the per-chapter files based on the current content of index.md. I have removed the number prefix and instead the order of the files are determined by `src/toc.conf`. > > By my quick inspection, the generated index.html looks identical to the one before. > > I found some inconsistencies when doing this. For instance most, but not all, chapters end with a > > ::: {.box} > [To the top](#){.boxheader} > ::: > > footer. A reasonable follow-up is to move these per-chapter footers out of the actual markdown, and inject them when combining the file instead. This means less redundancy, and no more inconsistencies. ;-) This pull request has now been integrated. Changeset: 6f2d4414 Author: Magnus Ihse Bursie URL: https://git.openjdk.java.net/guide/commit/6f2d44146b606c7e8a2275eb07a0a6a91f190993 Stats: 4813 lines in 22 files changed: 2391 ins; 2418 del; 4 mod Split up the monolithic index.md, take two Reviewed-by: jwilhelm ------------- PR: https://git.openjdk.java.net/guide/pull/82 From prr at openjdk.java.net Sat May 14 23:07:25 2022 From: prr at openjdk.java.net (Phil Race) Date: Sat, 14 May 2022 23:07:25 GMT Subject: RFR: update code-owners Message-ID: I just happened to notice the guide still has the old 5 retired client mailing lists instead of the client-libs-dev replacement Then I noticed the code area assignments were out of date too. ------------- Commit messages: - update code-owners Changes: https://git.openjdk.java.net/guide/pull/84/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=84&range=00 Stats: 19 lines in 1 file changed: 0 ins; 13 del; 6 mod Patch: https://git.openjdk.java.net/guide/pull/84.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/84/head:pull/84 PR: https://git.openjdk.java.net/guide/pull/84 From prr at openjdk.java.net Sat May 14 23:12:59 2022 From: prr at openjdk.java.net (Phil Race) Date: Sat, 14 May 2022 23:12:59 GMT Subject: Withdrawn: update code-owners In-Reply-To: References: Message-ID: <8gAvlaBjxKk7jr-nsDgweOZNYzD_k-q7r3ilG4pP4b0=.29532c9a-8834-4bcc-8c42-8f4428e0726f@github.com> On Sat, 14 May 2022 23:02:22 GMT, Phil Race wrote: > I just happened to notice the guide still has the old 5 retired client mailing lists instead of the client-libs-dev replacement > > Then I noticed the code area assignments were out of date too. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/guide/pull/84 From prr at openjdk.java.net Sat May 14 23:20:31 2022 From: prr at openjdk.java.net (Phil Race) Date: Sat, 14 May 2022 23:20:31 GMT Subject: RFR: Update owners Message-ID: I noticed that code-owners still had the 5 old client mailing lists replaced by client-libs-dev last year. Also the code assignments were out of date ------------- Commit messages: - Update owners Changes: https://git.openjdk.java.net/guide/pull/85/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=85&range=00 Stats: 19 lines in 1 file changed: 0 ins; 13 del; 6 mod Patch: https://git.openjdk.java.net/guide/pull/85.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/85/head:pull/85 PR: https://git.openjdk.java.net/guide/pull/85 From prr at openjdk.java.net Sat May 14 23:22:07 2022 From: prr at openjdk.java.net (Phil Race) Date: Sat, 14 May 2022 23:22:07 GMT Subject: RFR: update code-owners In-Reply-To: References: Message-ID: On Sat, 14 May 2022 23:02:22 GMT, Phil Race wrote: > I just happened to notice the guide still has the old 5 retired client mailing lists instead of the client-libs-dev replacement > > Then I noticed the code area assignments were out of date too. Accidentally forgot to create a branch - so closed this one and submitted a new one https://github.com/openjdk/guide/pull/85 ------------- PR: https://git.openjdk.java.net/guide/pull/84 From jwilhelm at openjdk.java.net Sun May 15 12:12:00 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Sun, 15 May 2022 12:12:00 GMT Subject: RFR: Update owners In-Reply-To: References: Message-ID: On Sat, 14 May 2022 23:16:22 GMT, Phil Race wrote: > I noticed that code-owners still had the 5 old client mailing lists replaced by > client-libs-dev last year. > > Also the code assignments were out of date Thanks for noticing and making these changes! src/guide/code-owners.md line 155: > 153: * `jdk.incubator.foreign` ? LangTools > 154: * `jdk.incubator.httpclient` ? Net > 155: * `jdk.incubator.jpackage` ? Client I assume this directory remains in some of the update release trains still being maintained? If so it should still be in the list. src/guide/code-owners.md line 160: > 158: * `jdk.jfr` ? JFR > 159: * `jdk.jlink` ? LangTools > 160: * `jdk.jpackage` ? Client / jpackage Client Libs? ------------- Marked as reviewed by jwilhelm (Lead). PR: https://git.openjdk.java.net/guide/pull/85 From jwilhelm at openjdk.java.net Sun May 15 14:33:29 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Sun, 15 May 2022 14:33:29 GMT Subject: RFR: Clarifications and other changes Message-ID: Several unrelated commits here, but each diff should be straight forward on its own. 1. Fixed the commit message in the backout example to actually follow the structure described in that section. 2. A large part of the introduction was lost in the split into one file per chapter. Restored. 3. Added some more info to clarify the Author role and how to request it. 4. Added a small section describing the webrevs and the cr.openjdk.java.net server. 5. Removed the old files that hadn't been included into the guide earlier - the webrev and cr.ojn stuff was the last pice of info missing from those files. ------------- Commit messages: - Remove obsolete files - Webrevs and cr.ojn - Clarified Author role - Restored the OpenJDK section - Fixed commit message Changes: https://git.openjdk.java.net/guide/pull/86/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=86&range=00 Stats: 281 lines in 7 files changed: 88 ins; 188 del; 5 mod Patch: https://git.openjdk.java.net/guide/pull/86.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/86/head:pull/86 PR: https://git.openjdk.java.net/guide/pull/86 From prr at openjdk.java.net Mon May 16 16:53:57 2022 From: prr at openjdk.java.net (Phil Race) Date: Mon, 16 May 2022 16:53:57 GMT Subject: RFR: Update owners In-Reply-To: References: Message-ID: <_sF3JeBs_B2sfj1Nv3W5c3W0tydDPLJG79PsXulWvDg=.d51dce27-0456-445e-92ff-c138ca968fc3@github.com> On Sun, 15 May 2022 12:06:54 GMT, Jesper Wilhelmsson wrote: >> I noticed that code-owners still had the 5 old client mailing lists replaced by >> client-libs-dev last year. >> >> Also the code assignments were out of date > > src/guide/code-owners.md line 155: > >> 153: * `jdk.incubator.foreign` ? LangTools >> 154: * `jdk.incubator.httpclient` ? Net >> 155: * `jdk.incubator.jpackage` ? Client > > I assume this directory remains in some of the update release trains still being maintained? If so it should still be in the list. No. It was incubator only in JDK 14 and 15. I see no reason to continue to list it here. > src/guide/code-owners.md line 160: > >> 158: * `jdk.jfr` ? JFR >> 159: * `jdk.jlink` ? LangTools >> 160: * `jdk.jpackage` ? Client / jpackage > > Client Libs? No .- not the client-libs mailing list nor is it part of client libs, even if it is somewhat connected to client overall as it is primarily for creating client app installers. and jpackage is discussed on core-libs as already noted. ------------- PR: https://git.openjdk.java.net/guide/pull/85 From jwilhelm at openjdk.java.net Mon May 16 20:56:03 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Mon, 16 May 2022 20:56:03 GMT Subject: RFR: Update owners In-Reply-To: <_sF3JeBs_B2sfj1Nv3W5c3W0tydDPLJG79PsXulWvDg=.d51dce27-0456-445e-92ff-c138ca968fc3@github.com> References: <_sF3JeBs_B2sfj1Nv3W5c3W0tydDPLJG79PsXulWvDg=.d51dce27-0456-445e-92ff-c138ca968fc3@github.com> Message-ID: On Mon, 16 May 2022 16:49:31 GMT, Phil Race wrote: >> src/guide/code-owners.md line 155: >> >>> 153: * `jdk.incubator.foreign` ? LangTools >>> 154: * `jdk.incubator.httpclient` ? Net >>> 155: * `jdk.incubator.jpackage` ? Client >> >> I assume this directory remains in some of the update release trains still being maintained? If so it should still be in the list. > > No. It was incubator only in JDK 14 and 15. I see no reason to continue to list it here. It looks to me like both JDK 14 and JDK 15 is being actively maintained by the community. ------------- PR: https://git.openjdk.java.net/guide/pull/85 From dholmes at openjdk.java.net Wed May 18 22:26:54 2022 From: dholmes at openjdk.java.net (David Holmes) Date: Wed, 18 May 2022 22:26:54 GMT Subject: RFR: Clarifications and other changes In-Reply-To: References: Message-ID: On Sun, 15 May 2022 14:27:00 GMT, Jesper Wilhelmsson wrote: > Several unrelated commits here, but each diff should be straight forward on its own. > > 1. Fixed the commit message in the backout example to actually follow the structure described in that section. > 2. A large part of the introduction was lost in the split into one file per chapter. Restored. > 3. Added some more info to clarify the Author role and how to request it. > 4. Added a small section describing the webrevs and the cr.openjdk.java.net server. > 5. Removed the old files that hadn't been included into the guide earlier - the webrev and cr.ojn stuff was the last pice of info missing from those files. All seems fine to me. Thanks ------------- Marked as reviewed by dholmes (Author). PR: https://git.openjdk.java.net/guide/pull/86 From smarks at openjdk.java.net Wed May 18 23:04:54 2022 From: smarks at openjdk.java.net (Stuart Marks) Date: Wed, 18 May 2022 23:04:54 GMT Subject: RFR: Clarifications and other changes In-Reply-To: References: Message-ID: <2rgDUn3zEVXjXYFJbtKM2J5FMHLDc_y9_1NOdVv5-oU=.81b34b69-b199-49db-8a5a-7936b2e687cf@github.com> On Sun, 15 May 2022 14:27:00 GMT, Jesper Wilhelmsson wrote: > Several unrelated commits here, but each diff should be straight forward on its own. > > 1. Fixed the commit message in the backout example to actually follow the structure described in that section. > 2. A large part of the introduction was lost in the split into one file per chapter. Restored. > 3. Added some more info to clarify the Author role and how to request it. > 4. Added a small section describing the webrevs and the cr.openjdk.java.net server. > 5. Removed the old files that hadn't been included into the guide earlier - the webrev and cr.ojn stuff was the last pice of info missing from those files. Marked as reviewed by smarks (Committer). ------------- PR: https://git.openjdk.java.net/guide/pull/86 From iris at openjdk.java.net Tue May 24 08:28:16 2022 From: iris at openjdk.java.net (Iris Clark) Date: Tue, 24 May 2022 08:28:16 GMT Subject: RFR: Clarifications and other changes In-Reply-To: References: Message-ID: <0Axqp5_dQGBa74BrHd7pTkmO84tCzn3loFSuLXY0c-A=.8080c5ef-078e-4548-aa40-e07fe2c6d027@github.com> On Sun, 15 May 2022 14:27:00 GMT, Jesper Wilhelmsson wrote: > Several unrelated commits here, but each diff should be straight forward on its own. > > 1. Fixed the commit message in the backout example to actually follow the structure described in that section. > 2. A large part of the introduction was lost in the split into one file per chapter. Restored. > 3. Added some more info to clarify the Author role and how to request it. > 4. Added a small section describing the webrevs and the cr.openjdk.java.net server. > 5. Removed the old files that hadn't been included into the guide earlier - the webrev and cr.ojn stuff was the last pice of info missing from those files. Looks great! ------------- Marked as reviewed by iris (Reviewer). PR: https://git.openjdk.java.net/guide/pull/86 From jwilhelm at openjdk.java.net Tue May 24 11:51:15 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Tue, 24 May 2022 11:51:15 GMT Subject: Integrated: Clarifications and other changes In-Reply-To: References: Message-ID: On Sun, 15 May 2022 14:27:00 GMT, Jesper Wilhelmsson wrote: > Several unrelated commits here, but each diff should be straight forward on its own. > > 1. Fixed the commit message in the backout example to actually follow the structure described in that section. > 2. A large part of the introduction was lost in the split into one file per chapter. Restored. > 3. Added some more info to clarify the Author role and how to request it. > 4. Added a small section describing the webrevs and the cr.openjdk.java.net server. > 5. Removed the old files that hadn't been included into the guide earlier - the webrev and cr.ojn stuff was the last pice of info missing from those files. This pull request has now been integrated. Changeset: 6db73885 Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/6db7388579ad0f2d2f3021ebaa71e50e8fb34c4e Stats: 281 lines in 7 files changed: 88 ins; 188 del; 5 mod Clarifications and other changes Reviewed-by: dholmes, smarks, iris ------------- PR: https://git.openjdk.java.net/guide/pull/86 From jwilhelm at openjdk.java.net Thu May 26 17:29:29 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 26 May 2022 17:29:29 GMT Subject: RFR: Removed legacy stuff from Makefile Message-ID: When the old leftover files was removed the Makefile didn't work anymore since the build directory wasn't created. Fixed this and removed all handling of legacy stuff in the Makefile. ------------- Commit messages: - Removed legacy stuff from Makefile Changes: https://git.openjdk.java.net/guide/pull/87/files Webrev: https://webrevs.openjdk.java.net/?repo=guide&pr=87&range=00 Stats: 17 lines in 1 file changed: 1 ins; 14 del; 2 mod Patch: https://git.openjdk.java.net/guide/pull/87.diff Fetch: git fetch https://git.openjdk.java.net/guide pull/87/head:pull/87 PR: https://git.openjdk.java.net/guide/pull/87 From iris at openjdk.java.net Thu May 26 17:33:58 2022 From: iris at openjdk.java.net (Iris Clark) Date: Thu, 26 May 2022 17:33:58 GMT Subject: RFR: Removed legacy stuff from Makefile In-Reply-To: References: Message-ID: On Thu, 26 May 2022 17:23:38 GMT, Jesper Wilhelmsson wrote: > When the old leftover files was removed the Makefile didn't work anymore since the build directory wasn't created. Fixed this and removed all handling of legacy stuff in the Makefile. Marked as reviewed by iris (Reviewer). ------------- PR: https://git.openjdk.java.net/guide/pull/87 From jwilhelm at openjdk.java.net Thu May 26 20:35:58 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 26 May 2022 20:35:58 GMT Subject: RFR: Removed legacy stuff from Makefile In-Reply-To: References: Message-ID: On Thu, 26 May 2022 17:23:38 GMT, Jesper Wilhelmsson wrote: > When the old leftover files was removed the Makefile didn't work anymore since the build directory wasn't created. Fixed this and removed all handling of legacy stuff in the Makefile. Thanks Iris! ------------- PR: https://git.openjdk.java.net/guide/pull/87 From jwilhelm at openjdk.java.net Thu May 26 20:35:59 2022 From: jwilhelm at openjdk.java.net (Jesper Wilhelmsson) Date: Thu, 26 May 2022 20:35:59 GMT Subject: Integrated: Removed legacy stuff from Makefile In-Reply-To: References: Message-ID: On Thu, 26 May 2022 17:23:38 GMT, Jesper Wilhelmsson wrote: > When the old leftover files was removed the Makefile didn't work anymore since the build directory wasn't created. Fixed this and removed all handling of legacy stuff in the Makefile. This pull request has now been integrated. Changeset: ecc4f4ea Author: Jesper Wilhelmsson URL: https://git.openjdk.java.net/guide/commit/ecc4f4ea1784554a114738df819f3c7ba1688778 Stats: 17 lines in 1 file changed: 1 ins; 14 del; 2 mod Removed legacy stuff from Makefile Reviewed-by: iris ------------- PR: https://git.openjdk.java.net/guide/pull/87