RFR: Things to consider before PR

Phil Race prr at openjdk.org
Fri Apr 21 18:22:13 UTC 2023


On Fri, 21 Apr 2023 17:15:04 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> I like the tone of this advice, to be careful about what is proposed and thorough in the preparation.
> Possibly there can be guidance about being open to comments on the change and accepting of the recommendations including not pursuing it.

I agree on both counts, if by the 2nd comment you imply that if you decide the advice doesn't apply to you, others might not agree :-)

Regardless, this text is a good addition to the guide.

-------------

PR Comment: https://git.openjdk.org/guide/pull/101#issuecomment-1518186618


More information about the guide-dev mailing list