RFR: Things to consider before PR

Martin Desruisseaux duke at openjdk.org
Thu Apr 27 18:57:57 UTC 2023


On Fri, 21 Apr 2023 16:15:30 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Text about what kind of changes that may or may not be desired in OpenJDK. Based on @prrace's text on https://openjdk.org/groups/client-libs/

> > In the "What is the main intention of your change?" section, there is no item for "Reducing code size".

> Isn't this covered in the Refactoring/Cleanup bullet?

The Refactoring/Cleanup bullet seems to be about aesthetic improvements, which is difficult to quantify. Reducing the code size as a measurable benefit. Whether such benefit is worth a change, this is the question.

-------------

PR Comment: https://git.openjdk.org/guide/pull/101#issuecomment-1526168402


More information about the guide-dev mailing list