RFR: Removing a JBS Issue [v5]

[Jesper Wilhelmsson]

On Thu, 10 Aug 2023 18:50:16 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Considered
>
> src/guide/working-with-pull-requests.md line 15:
> 
>> 13: ## Think once more
>> 14: 
>> 15: All code reviews in OpenJDK are done in public. Once you open your PR for public review the internet can see it and comment on it. Make sure your code is ready for it. Look through your comments, make sure that temporary code is gone, and make sure you have sanitized your method and variable names. Also, make sure you understand your code. Why is it working? What are the potential pitfalls? What are the edge-cases? If you haven't already answered all these questions in the mail conversation that preceded this PR, it's likely that you will need to answer them during the review.
> 
> Suggestion:
> 
> All code reviews in OpenJDK are done in public. Once you open your PR for public review, the internet can see it and comment on it. Make sure your code is ready for it. Look through your comments, make sure that temporary code is gone, and make sure you have sanitized your method and variable names. Also, make sure you understand your code. Why is it working? What are the potential pitfalls? What are the edge-cases? If you haven't already answered all these questions in the mail conversation that preceded this PR, it's likely that you will need to answer them during the review.
> 
> Should we add a comma to separate the sentences?

That doesn't read right to me. Those aren't two different sentences.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/112#discussion_r1295567476