From jwilhelm at openjdk.org  Wed May  3 11:27:12 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 3 May 2023 11:27:12 GMT
Subject: RFR: Things to consider before PR [v7]
In-Reply-To: <Zwgj0eBPQ_qgTxtDF-Xvj11ftHV6tkvVHfDBVQKBRe8=.ad187c11-0505-489a-8eff-401c28d8635b@github.com>
References: <Zwgj0eBPQ_qgTxtDF-Xvj11ftHV6tkvVHfDBVQKBRe8=.ad187c11-0505-489a-8eff-401c28d8635b@github.com>
Message-ID: <RqqNHnFNH_VQKoUojdq8GqFMoXrIF3K0P7ZJ5Y6eysk=.f559bf70-f49f-44ab-9c58-da6dbd8b03a8@github.com>

> Text about what kind of changes that may or may not be desired in OpenJDK. Based on @prrace's text on https://openjdk.org/groups/client-libs/

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Final fixes

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/101/files
  - new: https://git.openjdk.org/guide/pull/101/files/2c2a0390..24408e23

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=101&range=06
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=101&range=05-06

  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/guide/pull/101.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/101/head:pull/101

PR: https://git.openjdk.org/guide/pull/101

From jwilhelm at openjdk.org  Wed May  3 11:27:15 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 3 May 2023 11:27:15 GMT
Subject: RFR: Things to consider before PR [v6]
In-Reply-To: <cTSzHcVMvaPM6i5mIAc_kkguFZgaMO61TYxcHqIwUWc=.c60bba46-3917-4ce8-bf41-486006e794c4@github.com>
References: <Zwgj0eBPQ_qgTxtDF-Xvj11ftHV6tkvVHfDBVQKBRe8=.ad187c11-0505-489a-8eff-401c28d8635b@github.com>
 <cTSzHcVMvaPM6i5mIAc_kkguFZgaMO61TYxcHqIwUWc=.c60bba46-3917-4ce8-bf41-486006e794c4@github.com>
Message-ID: <ONcbaXMjyRdCgdG2JfFAPwjE5juhDv05x9VI_MGzBlc=.5b47f793-b1b2-4ee3-95af-af87d7213b7e@github.com>

On Thu, 27 Apr 2023 22:21:24 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> Text about what kind of changes that may or may not be desired in OpenJDK. Based on @prrace's text on https://openjdk.org/groups/client-libs/
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Few more updates

Thank you all for your reviews!

-------------

PR Comment: https://git.openjdk.org/guide/pull/101#issuecomment-1532859254

From jwilhelm at openjdk.org  Wed May  3 11:27:18 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 3 May 2023 11:27:18 GMT
Subject: RFR: Things to consider before PR [v6]
In-Reply-To: <Div4ghqWnB6Ph59NodzfXV66c6FNZ4YMSq5KlfKb9fQ=.3869042b-03c8-401a-afd4-323ea4264410@github.com>
References: <Zwgj0eBPQ_qgTxtDF-Xvj11ftHV6tkvVHfDBVQKBRe8=.ad187c11-0505-489a-8eff-401c28d8635b@github.com>
 <cTSzHcVMvaPM6i5mIAc_kkguFZgaMO61TYxcHqIwUWc=.c60bba46-3917-4ce8-bf41-486006e794c4@github.com>
 <Div4ghqWnB6Ph59NodzfXV66c6FNZ4YMSq5KlfKb9fQ=.3869042b-03c8-401a-afd4-323ea4264410@github.com>
Message-ID: <U31A2izvsu0ujjBBLc-WK574fIv4nY2AlvvmuE8TuME=.60fcc123-66c8-4129-8cd9-94876d746c8f@github.com>

On Fri, 28 Apr 2023 14:52:42 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Few more updates
>
> src/guide/contributing-to-an-open-jdk-project.md line 13:
> 
>> 11: ## Things to consider before proposing changes to OpenJDK code
>> 12: 
>> 13: Every change in JDK code carries risk of changes in behavior which adversely affect applications. Generally we're looking to improve the functionality and capability and sometimes performance of the platform without that negative consequence. We do have many thousands of tests, but they're inevitably incomplete in coverage. So we need to ask ourselves whether each change is worthwhile - and some may not be no matter how well intentioned.
> 
> This sounds like all changes in behavior are negative, which is not true. I suggest inserting "may" before "adversely".
> 
> Some other wording suggestions in this paragraph:
> 
> "Every change to JDK code ..."
> "carries a risk .."

Fixed.

> src/guide/contributing-to-an-open-jdk-project.md line 13:
> 
>> 11: ## Things to consider before proposing changes to OpenJDK code
>> 12: 
>> 13: Every change in JDK code carries risk of changes in behavior which adversely affect applications. Generally we're looking to improve the functionality and capability and sometimes performance of the platform without that negative consequence. We do have many thousands of tests, but they're inevitably incomplete in coverage. So we need to ask ourselves whether each change is worthwhile - and some may not be no matter how well intentioned.
> 
>> We do have many thousands of tests, but they're inevitably incomplete in coverage.
> 
> This sentence needs more explanation, I think. If you are changing code, ideally you would provide tests that test that behavior change if the current tests are inadequate. Does this sentence add anything to the main points in this paragraph - otherwise, maybe it should be removed.

Agreed. Removed.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/101#discussion_r1183556680
PR Review Comment: https://git.openjdk.org/guide/pull/101#discussion_r1183556772

From jwilhelm at openjdk.org  Wed May  3 11:27:21 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 3 May 2023 11:27:21 GMT
Subject: RFR: Things to consider before PR [v6]
In-Reply-To: <QLl3072N9eBZy712GDkYAHMAxBj0KlslYATLGetnJ3M=.f0f384ee-e0f7-42b7-9d4e-69accd896051@github.com>
References: <Zwgj0eBPQ_qgTxtDF-Xvj11ftHV6tkvVHfDBVQKBRe8=.ad187c11-0505-489a-8eff-401c28d8635b@github.com>
 <cTSzHcVMvaPM6i5mIAc_kkguFZgaMO61TYxcHqIwUWc=.c60bba46-3917-4ce8-bf41-486006e794c4@github.com>
 <QLl3072N9eBZy712GDkYAHMAxBj0KlslYATLGetnJ3M=.f0f384ee-e0f7-42b7-9d4e-69accd896051@github.com>
Message-ID: <aTYCvzoq5fvg70xeCGofRmoeuL-FnzRH2EBCZsCZEaY=.903014ca-36f3-4923-8e6c-187686772cf0@github.com>

On Fri, 28 Apr 2023 13:54:53 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Few more updates
>
> src/guide/working-with-pull-requests.md line 17:
> 
>> 15: It's also worth taking the extra time to see if the change can be split into a few different separate changes. A large change will take more effort and thus attract fewer Reviewers. Smaller changes will get reviewed faster and get better quality reviews. You can compare proposing a single large change to proposing ten individual small unrelated changes. What happens in practice when all these ten changes are presented as one PR is that there's a focus on say 5-6 of these smaller changes and no one really looks hard at the other 4-5. For complexity, even small changes that are hard to understand and test may be risky.
>> 16: 
>> 17: The timing of your change will also affect the availability of reviewers. The JDK runs on a [six-months release cadence](#release-cycle). During the months around the start of the ramp down phase most area experts will be bussy working on their own changes and reviewing major features that are planned for the release. If you propose a change during this period (basically May-June, or November-December) it may take a long time before you get the required reviews.
> 
> typo "bussy" -> "busy'

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/101#discussion_r1183556611

From jwilhelm at openjdk.org  Wed May  3 11:27:21 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 3 May 2023 11:27:21 GMT
Subject: Integrated: Things to consider before PR
In-Reply-To: <Zwgj0eBPQ_qgTxtDF-Xvj11ftHV6tkvVHfDBVQKBRe8=.ad187c11-0505-489a-8eff-401c28d8635b@github.com>
References: <Zwgj0eBPQ_qgTxtDF-Xvj11ftHV6tkvVHfDBVQKBRe8=.ad187c11-0505-489a-8eff-401c28d8635b@github.com>
Message-ID: <satkrn8C4dkbk-iUDYGCSc7icY-j7JGYsi2hodzMYig=.4cfede7b-dff9-429d-b01a-12b8c289d5b0@github.com>

On Fri, 21 Apr 2023 16:15:30 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Text about what kind of changes that may or may not be desired in OpenJDK. Based on @prrace's text on https://openjdk.org/groups/client-libs/

This pull request has now been integrated.

Changeset: 3c273e22
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/3c273e227d59e3ec83a74853e1bdfbdff709c657
Stats:     38 lines in 3 files changed: 38 ins; 0 del; 0 mod

Things to consider before PR

Reviewed-by: prr, iris, rriggs

-------------

PR: https://git.openjdk.org/guide/pull/101

From jwilhelm at openjdk.org  Fri May  5 19:39:46 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 5 May 2023 19:39:46 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v2]
In-Reply-To: <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
Message-ID: <OZrxQBnEkcdS4kmtHr0qF5juO9TNMBlXuxKM7VE39Gg=.0399ffd2-5696-4a28-a7cf-57fa31b01a5d@github.com>

On Tue, 21 Mar 2023 05:33:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rewrite of the Issue Type table, minor updates, and changes for formatting consistency across the file
>
> src/guide/jbs-jdk-bug-system.md line 192:
> 
>> 190:     1. Only one fixversion should ever be set, if the issue is to be fixed in additional releases then a separate backport must be created (See Working with backports in JBS).  There are exceptions to this rule for: CSRs; and, Release Notes.
>> 191: 1. make sure the bug has all the required labels ? JBS Label Dictionary
>> 192:     1. bugs that are new in the current release: 'regression'
> 
> This is tricky. We don't generally use "regression" during active development of the current release, it tends to be used mainly for issues that are found after a release has been released e.g. if we release JDK 19 and then a bug report comes in because something that worked in 18 now doesn't, then it is a regression in 19. But if we are in the process of developing a release and we have added some new thing and then we find a bug in that then we don't mark that as a regression. And a lot of the time if we introduce a bug "by mistake" we don't tend to mark it as a regression.

We probably should be better at marking that last category as regressions though since there are special rules around deferring those.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1186441962

From jwilhelm at openjdk.org  Fri May  5 19:49:38 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Fri, 5 May 2023 19:49:38 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v2]
In-Reply-To: <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
Message-ID: <0E_PcehsvxkR9mwapXzKUyjKUWq14Op0FEa9-As1qoc=.4264b174-e71f-4977-834d-d6ed62c6f34f@github.com>

On Tue, 21 Mar 2023 05:35:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rewrite of the Issue Type table, minor updates, and changes for formatting consistency across the file
>
> src/guide/jbs-jdk-bug-system.md line 198:
> 
>> 196:     1. project specific issues usually have their own labels as well
>> 197: 
>> 198: At this point move the issue into the [Open]{.jbs-field} state, bring high priority (P1, P2) bugs to the attention of the team.
> 
> What "team"?

This section should probably start with a few sentences defining who is expected to perform triage. This is in general done by well defined triage teams who are part of the "team" that will work on the fix, so I would assume that it shouldn't be necessary to bring the bug to anyones attention. P1-P2 bugs are fairly visible anyway :-)
I would suggest to remove the part after the comma.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1186449143

From duke at openjdk.org  Mon May  8 22:39:48 2023
From: duke at openjdk.org (calnan)
Date: Mon, 8 May 2023 22:39:48 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v2]
In-Reply-To: <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
Message-ID: <yN5r4GB4F_4I0kYA-LEnukyc4FG1PMPl-yXfPyBKTSs=.82a5392e-1588-44ac-a840-2396b5c4deec@github.com>

On Tue, 21 Mar 2023 02:58:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rewrite of the Issue Type table, minor updates, and changes for formatting consistency across the file
>
> src/guide/jbs-jdk-bug-system.md line 25:
> 
>> 23: The most common Issue types are:
>> 24: <br />
>> 25: <table class="dictionary" summary="JBS Label Dictionary">
> 
> "label" ?? Copy'n'paste error?

Fixed

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1187960809

From duke at openjdk.org  Mon May  8 22:50:20 2023
From: duke at openjdk.org (calnan)
Date: Mon, 8 May 2023 22:50:20 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v3]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <t0Sg6LYA-6b8jX_9CAk0mQG1dkXnZUjLkwQW_PXvIis=.2f5a1872-6b5e-4a0a-b5d7-ca8ff55b4935@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  Updates to address current round of feedback

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/bba4d012..347aeeec

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=02
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=01-02

  Stats: 14 lines in 1 file changed: 5 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From duke at openjdk.org  Mon May  8 22:50:25 2023
From: duke at openjdk.org (calnan)
Date: Mon, 8 May 2023 22:50:25 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v3]
In-Reply-To: <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
Message-ID: <fQQlgOhWPhIk3izBtfvnVTpxrJo2AopO87C5qL_Zxxg=.f5940122-2345-4e01-8d2a-0606be7bfb8c@github.com>

On Tue, 21 Mar 2023 03:03:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates to address current round of feedback
>
> src/guide/jbs-jdk-bug-system.md line 29:
> 
>> 27: <tr>
>> 28:     <td class="dictionary">[Bug]{.jbs-field}</td>
>> 29:     <td class="dictionary">Used when reporting a problem: crashes; hangs; failures of functionality etc.</td>
> 
> The "etc" could be a bit too open to interpretation. A "bug" should relate to functional correctness - a deviation from behaviour that can be tied back to a specification. Anything else, including performance concerns, is generally not a bug but an enhancement. Though it is not clear cut as a significant performance regression may be classified as a "bug", for example.

updated description in line with above

> src/guide/jbs-jdk-bug-system.md line 34:
> 
>> 32:     <td class="dictionary"><i>Improvement</i></td>
>> 33:     <td class="dictionary">When requesting an improvement in the JDK, the issue type used depends on the size/scope of the improvement:<br />
>> 34:     ([Enhancement]{.jbs-field}) - for a small improvement to existing functionality<br />
> 
> "Enhancement" is used for improvements small and large - basically anything that is not a "bug". Perhaps we should say "small to medium" with the understanding that "large" implies big enough to be a JEP?

added "small to medium"

> src/guide/jbs-jdk-bug-system.md line 44:
> 
>> 42: <tr>
>> 43:     <td class="dictionary">[Task]{.jbs-field}</td>
>> 44:     <td class="dictionary">Where something needs to happen other than a code change - a request for a new JBS version value for example</td>
> 
> This one is very grey. "Task" does not get used much in the hotspot area, for example. I think a task may typically be something for which no changeset for the repo would be generated; though if you interpret "Task" as anything pertaining to a change other than to code, then the use of task could increase dramatically. But in the build area changes don't relate to "code" per-se, so would they all be tasks? I think not. In conclusion it is very hard to know when "Task" is suitable for use.

added new wording on tasks with a note at the end of the table to clarify that bugs and enhancements are the types that should be used to track changes to the repos

> src/guide/jbs-jdk-bug-system.md line 47:
> 
>> 45: </tr>
>> 46: <tr>
>> 47:     <td class="dictionary"><i>Vulnerability</i></td>
> 
> "Vulnerability" is not a JBS issue type, so I don't think this belongs in this table. 
> 
> Also general users may not understand what is meant by "vulnerability" here - perhaps "security vulnerability" would be better?

Removed from table and added as a note after table

> src/guide/jbs-jdk-bug-system.md line 171:
> 
>> 169: ## Triaging an issue
>> 170: 
>> 171: First give the issue a general [Review]{.jbs-field}
> 
> What does the formatting `[Review]{.jbs-field}` mean here? It is very hard to understand how this document is structured when it isn't actually using markdown as expected.

replaced with markdown formatting

> src/guide/jbs-jdk-bug-system.md line 189:
> 
>> 187:     1. if the bug also exists in older versions it may require backporting
>> 188:         * the decision to backport should be made inline with the guidelines of the lead for the release
>> 189:         * There are two options for creating backport issue(s) to track the backport: one is to create it manually once it is agreed that the bug should be backported; the second, is to let the bots create the backport issue once you push the fix to the repo.
> 
> "bots" needs some context here.

added a link to the section of the doc that better explains the "bots", will propose a follow-on update to link "bots" to the wiki page https://wiki.openjdk.org/display/SKARA

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1187962795
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1187962613
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1187963478
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1187963075
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1187963678
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1187964248

From duke at openjdk.org  Mon May  8 22:50:29 2023
From: duke at openjdk.org (calnan)
Date: Mon, 8 May 2023 22:50:29 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v3]
In-Reply-To: <OZrxQBnEkcdS4kmtHr0qF5juO9TNMBlXuxKM7VE39Gg=.0399ffd2-5696-4a28-a7cf-57fa31b01a5d@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
 <OZrxQBnEkcdS4kmtHr0qF5juO9TNMBlXuxKM7VE39Gg=.0399ffd2-5696-4a28-a7cf-57fa31b01a5d@github.com>
Message-ID: <ZViUUFaZpQzKE5AYKNidCXUzchUw9mBmgg-oMvpQX4I=.f22ac170-88ad-4f0e-be79-8b136f3e1ced@github.com>

On Fri, 5 May 2023 19:36:59 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> src/guide/jbs-jdk-bug-system.md line 192:
>> 
>>> 190:     1. Only one fixversion should ever be set, if the issue is to be fixed in additional releases then a separate backport must be created (See Working with backports in JBS).  There are exceptions to this rule for: CSRs; and, Release Notes.
>>> 191: 1. make sure the bug has all the required labels ? JBS Label Dictionary
>>> 192:     1. bugs that are new in the current release: 'regression'
>> 
>> This is tricky. We don't generally use "regression" during active development of the current release, it tends to be used mainly for issues that are found after a release has been released e.g. if we release JDK 19 and then a bug report comes in because something that worked in 18 now doesn't, then it is a regression in 19. But if we are in the process of developing a release and we have added some new thing and then we find a bug in that then we don't mark that as a regression. And a lot of the time if we introduce a bug "by mistake" we don't tend to mark it as a regression.
>
> We probably should be better at marking that last category as regressions though since there are special rules around deferring those.

Have left the text as-is for the moment - let me know if you feel changes are needed

>> src/guide/jbs-jdk-bug-system.md line 198:
>> 
>>> 196:     1. project specific issues usually have their own labels as well
>>> 197: 
>>> 198: At this point move the issue into the [Open]{.jbs-field} state, bring high priority (P1, P2) bugs to the attention of the team.
>> 
>> What "team"?
>
> This section should probably start with a few sentences defining who is expected to perform triage. This is in general done by well defined triage teams who are part of the "team" that will work on the fix, so I would assume that it shouldn't be necessary to bring the bug to anyones attention. P1-P2 bugs are fairly visible anyway :-)
> I would suggest to remove the part after the comma.

Added some text at the start from Jesper on the model of triage teams

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1187965035
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1187964591

From darcy at openjdk.org  Tue May  9 01:57:37 2023
From: darcy at openjdk.org (Joe Darcy)
Date: Tue, 9 May 2023 01:57:37 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v3]
In-Reply-To: <ZViUUFaZpQzKE5AYKNidCXUzchUw9mBmgg-oMvpQX4I=.f22ac170-88ad-4f0e-be79-8b136f3e1ced@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
 <OZrxQBnEkcdS4kmtHr0qF5juO9TNMBlXuxKM7VE39Gg=.0399ffd2-5696-4a28-a7cf-57fa31b01a5d@github.com>
 <ZViUUFaZpQzKE5AYKNidCXUzchUw9mBmgg-oMvpQX4I=.f22ac170-88ad-4f0e-be79-8b136f3e1ced@github.com>
Message-ID: <GTV-E-cGzvcDyJ88DQPDjeMzjLYPWX7p7VCuy7g74FI=.0428e81d-0c86-44fd-9182-a24379c27847@github.com>

On Mon, 8 May 2023 22:46:05 GMT, calnan <duke at openjdk.org> wrote:

>> We probably should be better at marking that last category as regressions though since there are special rules around deferring those.
>
> Have left the text as-is for the moment - let me know if you feel changes are needed

> This is tricky. We don't generally use "regression" during active development of the current release, it tends to be used mainly for issues that are found after a release has been released e.g. if we release JDK 19 and then a bug report comes in because something that worked in 18 now doesn't, then it is a regression in 19. But if we are in the process of developing a release and we have added some new thing and then we find a bug in that then we don't mark that as a regression. And a lot of the time if we introduce a bug "by mistake" we don't tend to mark it as a regression.

Right; if something didn't "work" in a shipped release, it can be a bug, but *not* a regression.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1188040542

From darcy at openjdk.org  Tue May  9 02:04:38 2023
From: darcy at openjdk.org (Joe Darcy)
Date: Tue, 9 May 2023 02:04:38 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v3]
In-Reply-To: <t0Sg6LYA-6b8jX_9CAk0mQG1dkXnZUjLkwQW_PXvIis=.2f5a1872-6b5e-4a0a-b5d7-ca8ff55b4935@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <t0Sg6LYA-6b8jX_9CAk0mQG1dkXnZUjLkwQW_PXvIis=.2f5a1872-6b5e-4a0a-b5d7-ca8ff55b4935@github.com>
Message-ID: <SYnbT_-Z_Q2mNDtE4Tprg5MzcMi7nA8wMCL7VMJCpq0=.3c0ee03f-8b17-4670-ad34-0a6fa864ad8c@github.com>

On Mon, 8 May 2023 22:50:20 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updates to address current round of feedback

src/guide/jbs-jdk-bug-system.md line 94:

> 92: To find out which component to use for different bugs, consult the [directory to area mapping](#directory-to-area-mapping).
> 93: 
> 94: ### Implementing a Large Change

Hmm. I don't think I entirely agree with the guidance here.

I've often used subtasks of a bug/enhancement to break the work into logical pieces (e.g. porting FDLIBM JDK-8171407) or partitioning work along review/maintenance domains (e.g. JDK-8231641: Suppress warnings on non-serializable non-transient instance fields in JDK libraries (umbrella)).

I think such usages work with the features of JBS in terms of allowing an easy estimate of how much of the umbrella bug is left to do and looser connections between the cloud of issues obscures the intent of what is going on.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1188043272

From iris at openjdk.org  Tue May  9 17:07:20 2023
From: iris at openjdk.org (Iris Clark)
Date: Tue, 9 May 2023 17:07:20 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v3]
In-Reply-To: <t0Sg6LYA-6b8jX_9CAk0mQG1dkXnZUjLkwQW_PXvIis=.2f5a1872-6b5e-4a0a-b5d7-ca8ff55b4935@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <t0Sg6LYA-6b8jX_9CAk0mQG1dkXnZUjLkwQW_PXvIis=.2f5a1872-6b5e-4a0a-b5d7-ca8ff55b4935@github.com>
Message-ID: <_MbpCkdFG8t1h_LHIQpz8WIozOz95d8e75gYoSyXIpQ=.90b6d684-0c44-4224-abbe-23a1aacad807@github.com>

On Mon, 8 May 2023 22:50:20 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updates to address current round of feedback

Mostly typographic suggestions...

src/guide/jbs-jdk-bug-system.md line 10:

> 8:   :::
> 9: 
> 10: [JBS](https://bugs.openjdk.org/) is a public issue tracker used by many OpenJDK projects and is open for anyone to read and search. In order to get write access you need to be registered in the [OpenJDK Census](https://openjdk.org/census) by becoming, for instance, an [Author](https://openjdk.org/bylaws#author) in an OpenJDK [Project](https://openjdk.org/bylaws#project).

Recommend dropping "In order".

src/guide/jbs-jdk-bug-system.md line 37:

> 35: <tr>
> 36:     <td class="dictionary">[New Feature]{.jbs-field}</td>
> 37:     <td class="dictionary">Not recommended to use<br /></td>

"**to** use" -> "**for** use"

src/guide/jbs-jdk-bug-system.md line 41:

> 39: <tr>
> 40:     <td class="dictionary">[JEP]{.jbs-field}</td>
> 41:     <td class="dictionary">For a proposal for a significant change or new feature which will take 4 weeks or more of work - see [JEP-1](https://openjdk.org/jeps/1)</td>

"For a proposal **for** a significant" -> "For a proposal **of** a significant"

src/guide/jbs-jdk-bug-system.md line 85:

> 83: * Including the java -fullversion is encouraged for bugs in the JVM, hangs, network issues where the exact version can be critical to determine what fixes may be missing from an older version.
> 84: * Always file separate bugs for different issues.
> 85:     * If two crashes looks related, but not similar enough to be sure they are the same, it's easier to later close a bug as a duplicate than it is to separate out one bug into two.

"looks" -> "look"

src/guide/jbs-jdk-bug-system.md line 227:

> 225: ## Resolving an issue
> 226: 
> 227: Once the work on an issue has been completed this should be indicated in JBS by moving the issue to a "closed" state.  There are two "closed" states: [Resolved]{.jbs-field} and [Closed]{.jbs-field} which can be used interchangeably except in the case of [Fixed]{.jbs-field}, or when flagged as  [Incomplete]{.jbs-field} (See Triaging).

Do you need to mention that "Resolved, fixed" is handled automatically when a PR is pushed to a repo?  The first sentence seems to imply that resolution always requires direct user interaction in JBS.  Hmm... I see that you address this later around line 233. Maybe just modify the first sentence to something slightly more generic, e.g. "Once the work on an issue has been complete the issue should be in a 'closed' state."?

src/guide/jbs-jdk-bug-system.md line 267:

> 265: <tr>
> 266:     <td class="dictionary">[External]{.jbs-field}</td>
> 267:     <td class="dictionary">Use where the issue is due to a problem in a Java library (not shipped with the JDK) or an IDE or other external tool</td>

Maybe also applicable for problems in the OS or other downstream users of OpenJDK source (e.g. another VM).  It would be friendly to provide advice for reporting the problem the responsible party if that information is known.

-------------

PR Review: https://git.openjdk.org/guide/pull/100#pullrequestreview-1419024444
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1188852500
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1188855869
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1188855344
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1188867488
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1188879445
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1188890552

From iris at openjdk.org  Tue May  9 17:07:23 2023
From: iris at openjdk.org (Iris Clark)
Date: Tue, 9 May 2023 17:07:23 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v3]
In-Reply-To: <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
Message-ID: <lU6BTodbvES3VbzppNajNWGqb3u37D6j0bZ_ao5WvOk=.df959bb1-30a9-4467-b034-0e52383b0dfc@github.com>

On Tue, 21 Mar 2023 04:55:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates to address current round of feedback
>
> src/guide/jbs-jdk-bug-system.md line 78:
> 
>> 76: * If the failure isn't reproducible with an existing OpenJDK test, attach a reproducer if possible, while in a number of cases it isn't possible, having a test case will decrease the time required to resolve the issue.
>> 77: * Only set [CPU]{.jbs-field} and/or [OS]{.jbs-field} fields if the bug **ONLY** happens on that particular platform or set of platforms.
>> 78: * Including the java -fullversion is encouraged for bugs in the JVM, hangs, network issues where the exact version can be critical to determine what fixes may be missing from an older version.
> 
> This sentence doesn't read well and I'm not sure what point it is trying to make. `java -version` is what is needed and that is a superset of `java -fullversion`.

Something like: "Provide the output of `java -version ` whenever possible.  This version information is particularly critical for hangs, JVM bugs, and network issues."

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1188866239

From duke at openjdk.org  Tue May  9 20:09:03 2023
From: duke at openjdk.org (calnan)
Date: Tue, 9 May 2023 20:09:03 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v4]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <LULBpSh2t6dX2mR3WhJXLzRfYH8AW6msNoUnU-suc3k=.d2b5e5ea-b2db-4d76-978e-1aa479e2cc1e@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  fixed typos and simplified a few sentences

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/347aeeec..7f838d22

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=03
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=02-03

  Stats: 8 lines in 1 file changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From duke at openjdk.org  Wed May 10 02:39:45 2023
From: duke at openjdk.org (calnan)
Date: Wed, 10 May 2023 02:39:45 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v5]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <qTjhV5elL0bwj4qF770Zz7tv7JEyk6rY2INJaR-rWtU=.9200ccc6-f468-44b8-ba21-643316481f12@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  updated the definition of a regression

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/7f838d22..3ab60291

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=04
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=03-04

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From duke at openjdk.org  Wed May 10 02:43:41 2023
From: duke at openjdk.org (calnan)
Date: Wed, 10 May 2023 02:43:41 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v3]
In-Reply-To: <_MbpCkdFG8t1h_LHIQpz8WIozOz95d8e75gYoSyXIpQ=.90b6d684-0c44-4224-abbe-23a1aacad807@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <t0Sg6LYA-6b8jX_9CAk0mQG1dkXnZUjLkwQW_PXvIis=.2f5a1872-6b5e-4a0a-b5d7-ca8ff55b4935@github.com>
 <_MbpCkdFG8t1h_LHIQpz8WIozOz95d8e75gYoSyXIpQ=.90b6d684-0c44-4224-abbe-23a1aacad807@github.com>
Message-ID: <bIyh5WTsUy6fzAoHRMLe5cX_56avjoBafPLHXuaiup8=.31b152aa-1e8a-4068-97b3-942228630a54@github.com>

On Tue, 9 May 2023 16:25:51 GMT, Iris Clark <iris at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates to address current round of feedback
>
> src/guide/jbs-jdk-bug-system.md line 10:
> 
>> 8:   :::
>> 9: 
>> 10: [JBS](https://bugs.openjdk.org/) is a public issue tracker used by many OpenJDK projects and is open for anyone to read and search. In order to get write access you need to be registered in the [OpenJDK Census](https://openjdk.org/census) by becoming, for instance, an [Author](https://openjdk.org/bylaws#author) in an OpenJDK [Project](https://openjdk.org/bylaws#project).
> 
> Recommend dropping "In order".

fixed

> src/guide/jbs-jdk-bug-system.md line 37:
> 
>> 35: <tr>
>> 36:     <td class="dictionary">[New Feature]{.jbs-field}</td>
>> 37:     <td class="dictionary">Not recommended to use<br /></td>
> 
> "**to** use" -> "**for** use"

fixed

> src/guide/jbs-jdk-bug-system.md line 41:
> 
>> 39: <tr>
>> 40:     <td class="dictionary">[JEP]{.jbs-field}</td>
>> 41:     <td class="dictionary">For a proposal for a significant change or new feature which will take 4 weeks or more of work - see [JEP-1](https://openjdk.org/jeps/1)</td>
> 
> "For a proposal **for** a significant" -> "For a proposal **of** a significant"

fixed

> src/guide/jbs-jdk-bug-system.md line 85:
> 
>> 83: * Including the java -fullversion is encouraged for bugs in the JVM, hangs, network issues where the exact version can be critical to determine what fixes may be missing from an older version.
>> 84: * Always file separate bugs for different issues.
>> 85:     * If two crashes looks related, but not similar enough to be sure they are the same, it's easier to later close a bug as a duplicate than it is to separate out one bug into two.
> 
> "looks" -> "look"

fixed

> src/guide/jbs-jdk-bug-system.md line 227:
> 
>> 225: ## Resolving an issue
>> 226: 
>> 227: Once the work on an issue has been completed this should be indicated in JBS by moving the issue to a "closed" state.  There are two "closed" states: [Resolved]{.jbs-field} and [Closed]{.jbs-field} which can be used interchangeably except in the case of [Fixed]{.jbs-field}, or when flagged as  [Incomplete]{.jbs-field} (See Triaging).
> 
> Do you need to mention that "Resolved, fixed" is handled automatically when a PR is pushed to a repo?  The first sentence seems to imply that resolution always requires direct user interaction in JBS.  Hmm... I see that you address this later around line 233. Maybe just modify the first sentence to something slightly more generic, e.g. "Once the work on an issue has been complete the issue should be in a 'closed' state."?

updated

> src/guide/jbs-jdk-bug-system.md line 267:
> 
>> 265: <tr>
>> 266:     <td class="dictionary">[External]{.jbs-field}</td>
>> 267:     <td class="dictionary">Use where the issue is due to a problem in a Java library (not shipped with the JDK) or an IDE or other external tool</td>
> 
> Maybe also applicable for problems in the OS or other downstream users of OpenJDK source (e.g. another VM).  It would be friendly to provide advice for reporting the problem the responsible party if that information is known.

I haven't put quite that wording as in the case of an OS issue it would seem the assignee would report it to the OS vendor

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1189299490
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1189299404
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1189299263
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1189299070
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1189299009
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1189300076

From duke at openjdk.org  Wed May 10 02:43:41 2023
From: duke at openjdk.org (calnan)
Date: Wed, 10 May 2023 02:43:41 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v5]
In-Reply-To: <GTV-E-cGzvcDyJ88DQPDjeMzjLYPWX7p7VCuy7g74FI=.0428e81d-0c86-44fd-9182-a24379c27847@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
 <OZrxQBnEkcdS4kmtHr0qF5juO9TNMBlXuxKM7VE39Gg=.0399ffd2-5696-4a28-a7cf-57fa31b01a5d@github.com>
 <ZViUUFaZpQzKE5AYKNidCXUzchUw9mBmgg-oMvpQX4I=.f22ac170-88ad-4f0e-be79-8b136f3e1ced@github.com>
 <GTV-E-cGzvcDyJ88DQPDjeMzjLYPWX7p7VCuy7g74FI=.0428e81d-0c86-44fd-9182-a24379c27847@github.com>
Message-ID: <ogeBA0SHNfHtT7Dd3pesTO1Vd7Rlvw_5_k6B8WQplGs=.cd7c22cd-2ace-4652-8a47-ff3e706f2bd7@github.com>

On Tue, 9 May 2023 01:55:07 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Have left the text as-is for the moment - let me know if you feel changes are needed
>
>> This is tricky. We don't generally use "regression" during active development of the current release, it tends to be used mainly for issues that are found after a release has been released e.g. if we release JDK 19 and then a bug report comes in because something that worked in 18 now doesn't, then it is a regression in 19. But if we are in the process of developing a release and we have added some new thing and then we find a bug in that then we don't mark that as a regression. And a lot of the time if we introduce a bug "by mistake" we don't tend to mark it as a regression.
> 
> Right; if something didn't "work" in a shipped release, it can be a bug, but *not* a regression.

updated the definition of a regression to be:

A bug is a regression when behavior has _incorrectly_ changed from a previous release.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1189298869

From duke at openjdk.org  Wed May 10 02:51:46 2023
From: duke at openjdk.org (calnan)
Date: Wed, 10 May 2023 02:51:46 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v6]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <BfK4aUB3PY7eu5yQXlGLx9PEsSiG-JhhoXaVvzcSYs4=.2e3259db-528f-4287-9e52-747e5c859c93@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  updated the Implementing a large change section

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/3ab60291..ae8baaae

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=05
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=04-05

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From duke at openjdk.org  Wed May 10 02:51:47 2023
From: duke at openjdk.org (calnan)
Date: Wed, 10 May 2023 02:51:47 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v3]
In-Reply-To: <SYnbT_-Z_Q2mNDtE4Tprg5MzcMi7nA8wMCL7VMJCpq0=.3c0ee03f-8b17-4670-ad34-0a6fa864ad8c@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <t0Sg6LYA-6b8jX_9CAk0mQG1dkXnZUjLkwQW_PXvIis=.2f5a1872-6b5e-4a0a-b5d7-ca8ff55b4935@github.com>
 <SYnbT_-Z_Q2mNDtE4Tprg5MzcMi7nA8wMCL7VMJCpq0=.3c0ee03f-8b17-4670-ad34-0a6fa864ad8c@github.com>
Message-ID: <bXdsGAqykcXdtfIsYuvL2AlA-zKrioOmbzZSA0uH2Ro=.cc24ea53-38e1-4fb9-967b-aaf28d5ca9d9@github.com>

On Tue, 9 May 2023 02:01:46 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates to address current round of feedback
>
> src/guide/jbs-jdk-bug-system.md line 94:
> 
>> 92: To find out which component to use for different bugs, consult the [directory to area mapping](#directory-to-area-mapping).
>> 93: 
>> 94: ### Implementing a Large Change
> 
> Hmm. I don't think I entirely agree with the guidance here.
> 
> I've often used subtasks of a bug/enhancement to break the work into logical pieces (e.g. porting FDLIBM JDK-8171407) or partitioning work along review/maintenance domains (e.g. JDK-8231641: Suppress warnings on non-serializable non-transient instance fields in JDK libraries (umbrella)).
> 
> I think such usages work with the features of JBS in terms of allowing an easy estimate of how much of the umbrella bug is left to do and looser connections between the cloud of issues obscures the intent of what is going on.

I believe that the examples you give are covered in the last sentence of that section, you examples are however good examples of where sub-tasks can be used to effect and so have included them as examples in that section

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1189302385

From duke at openjdk.org  Thu May 11 02:36:21 2023
From: duke at openjdk.org (calnan)
Date: Thu, 11 May 2023 02:36:21 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v7]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <VRJOaLQ9oMuiHruT4STY6JneOI4zD-lWdJvdq6dQjzg=.4be73653-eaea-4263-b870-efa0047e00c9@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  Updated the definition of a regression and a few other minor updates.

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/ae8baaae..4a650a6f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=06
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=05-06

  Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From jwilhelm at openjdk.org  Thu May 11 22:18:44 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 11 May 2023 22:18:44 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v7]
In-Reply-To: <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
Message-ID: <7zlj7lPAKRh-sNQKvd3dR2ehHGD-iqFVYpSB2diJ-Pk=.c9eb4a9e-a522-46db-95a2-c81f347f8165@github.com>

On Tue, 21 Mar 2023 04:53:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated the definition of a regression and a few other minor updates.
>
> src/guide/jbs-jdk-bug-system.md line 77:
> 
>> 75:     * logs which may include sensitive data
>> 76: * If the failure isn't reproducible with an existing OpenJDK test, attach a reproducer if possible, while in a number of cases it isn't possible, having a test case will decrease the time required to resolve the issue.
>> 77: * Only set [CPU]{.jbs-field} and/or [OS]{.jbs-field} fields if the bug **ONLY** happens on that particular platform or set of platforms.
> 
> This would be ideal but in practice very hard. Most people would set this to the platform they saw the problem on. There is very little chance they can know, or can find out, whether it only happens on that platform. The person later working on the bug can update these fields if needed, but in my experience very few people use these fields in a meaningful way.

I think that's why we want people to only set it if they know. Maybe it should even more clear. My initial intention when writing that sentence was to discourage people from using those fields for that very reason that you mention - they are almost never used in the right way.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1191742168

From duke at openjdk.org  Fri May 12 20:25:11 2023
From: duke at openjdk.org (calnan)
Date: Fri, 12 May 2023 20:25:11 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v7]
In-Reply-To: <lU6BTodbvES3VbzppNajNWGqb3u37D6j0bZ_ao5WvOk=.df959bb1-30a9-4467-b034-0e52383b0dfc@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
 <lU6BTodbvES3VbzppNajNWGqb3u37D6j0bZ_ao5WvOk=.df959bb1-30a9-4467-b034-0e52383b0dfc@github.com>
Message-ID: <fZpk8UNxyWn3bQoWiDPKF4wIvkiVKGepOlCBnOc9cNg=.b8bc2d76-2164-4207-9b93-453b3d92e979@github.com>

On Tue, 9 May 2023 16:38:31 GMT, Iris Clark <iris at openjdk.org> wrote:

>> src/guide/jbs-jdk-bug-system.md line 78:
>> 
>>> 76: * If the failure isn't reproducible with an existing OpenJDK test, attach a reproducer if possible, while in a number of cases it isn't possible, having a test case will decrease the time required to resolve the issue.
>>> 77: * Only set [CPU]{.jbs-field} and/or [OS]{.jbs-field} fields if the bug **ONLY** happens on that particular platform or set of platforms.
>>> 78: * Including the java -fullversion is encouraged for bugs in the JVM, hangs, network issues where the exact version can be critical to determine what fixes may be missing from an older version.
>> 
>> This sentence doesn't read well and I'm not sure what point it is trying to make. `java -version` is what is needed and that is a superset of `java -fullversion`.
>
> Something like: "Provide the output of `java -version ` whenever possible.  This version information is particularly critical for hangs, JVM bugs, and network issues."

updated

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1192763013

From duke at openjdk.org  Fri May 12 20:25:11 2023
From: duke at openjdk.org (calnan)
Date: Fri, 12 May 2023 20:25:11 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v7]
In-Reply-To: <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
Message-ID: <tPwO3r81CMAZpW5rlK8W8WTeDnc-kRCDhcRnTu-QZ1E=.d1f9994e-f0f2-4c5c-829f-6593f07a8a0c@github.com>

On Tue, 21 Mar 2023 03:24:08 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated the definition of a regression and a few other minor updates.
>
> src/guide/jbs-jdk-bug-system.md line 53:
> 
>> 51: 
>> 52: <br>
>> 53: A few things to keep in mind when filing an issue to report a problem:
> 
> "problem" here could mean "bug" or "enhancement" depending on the nature of the problem. But some of the below relates to filing an issue for non-problems too.

removed "to repot a problem"

> src/guide/jbs-jdk-bug-system.md line 76:
> 
>> 74:     * passwords, logins, machine names
>> 75:     * logs which may include sensitive data
>> 76: * If the failure isn't reproducible with an existing OpenJDK test, attach a reproducer if possible, while in a number of cases it isn't possible, having a test case will decrease the time required to resolve the issue.
> 
> I suggest splitting this into two sentences at "while".

it has been simplified a bit:
If the failure isn't reproducible with an existing OpenJDK test, attach a reproducer if possible, having a test case will decrease the time required to resolve the issue.

> src/guide/jbs-jdk-bug-system.md line 90:
> 
>> 88: 
>> 89: ### Implementing a Large Change
>> 90: When managing the work for a large change, especially when the work involves multiple engineers, it is recommended that the work is distributed across one or more "implementation" issues which should be linked to the main [Enhancement]{.jbs-field} with a "blocks" link along with any relevant CSRs. The [Enhancement]{.jbs-field} should not be considered done until all the blocking element are completed.  The use of subTasks for [Enhancement]{.jbs}s is not recommended unless all the [Sub-task]{.jbs-field}s are relevant to the fix, if it were to be backported.
> 
> To me this is exactly what sub-tasks should be used for. ???

see latest update

> src/guide/jbs-jdk-bug-system.md line 107:
> 
>> 105: <tr>
>> 106:     <td class="dictionary">Open</td>
>> 107:     <td class="dictionary">Most straightforward issues stay in this state until they are closed.  If the issue has some attention then use "In Progress" to show more clearly that the issue is being worked</td>
> 
> If you start working on an issue then you should mark it in-progress by selecting "Work started", not just leave it "open". This gives a clear indication that the assignee is actually working on something and it isn't just one of a dozen bugs assigned to someone that they may, or may not, eventually get around to looking at.

Fair point - have updated it to:
Once the issue has been triaged it will be in the [Open]{.jbs-field} state and will stay here until the assignee decides to work on it, at which point it is encouraged that the "Start Work" option be selected to move it to [In Progress]{.jbs-field}

> src/guide/jbs-jdk-bug-system.md line 110:
> 
>> 108: </tr>
>> 109: <tr>
>> 110:     <td class="dictionary">In Progress</td>
> 
> See above.

see above...

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1192765218
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1192764409
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1192762347
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1192761666
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1192761981

From duke at openjdk.org  Fri May 12 20:34:11 2023
From: duke at openjdk.org (calnan)
Date: Fri, 12 May 2023 20:34:11 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v7]
In-Reply-To: <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
Message-ID: <4zeWmOKtywWphZcR4H3GuMR32BiOLsi0Ls7tbIU6hqQ=.ffdaa28e-3fe2-418a-9a9e-e4ef27c20cd2@github.com>

On Tue, 21 Mar 2023 03:27:56 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated the definition of a regression and a few other minor updates.
>
> src/guide/jbs-jdk-bug-system.md line 55:
> 
>> 53: A few things to keep in mind when filing an issue to report a problem:
>> 54: 
>> 55: * Before filing, verify that there isn't an issue already filed.
> 
> Suggestion: "open issue". You may find dozens of resolved/closed issues if you search for something like the name of a failing tests. You may also find a closed issue that was "not reproducible" that it may be appropriate to re-open.
> 
> Also note that for those without direct JBS access this advice is somewhat moot because even if they find an existing issue, they can't tell anyone "hey I hit this problem too". Not sure what we can do there.

Made changes for your first comment.  You second is interesting - there is work happening to make it easier to add a comment to an existing bug via bugs.java.com and have added this for the case of reopening:

* if you find a similar issue that was closed as "not reproducible" then it may be appropriate to re-open that one - if you don't have direct access to JBS you can file a bug at [bugs.java.com](https://java.bugs.com) requesting that it be reopened.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1192770506

From duke at openjdk.org  Fri May 12 20:42:15 2023
From: duke at openjdk.org (calnan)
Date: Fri, 12 May 2023 20:42:15 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v7]
In-Reply-To: <7zlj7lPAKRh-sNQKvd3dR2ehHGD-iqFVYpSB2diJ-Pk=.c9eb4a9e-a522-46db-95a2-c81f347f8165@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
 <7zlj7lPAKRh-sNQKvd3dR2ehHGD-iqFVYpSB2diJ-Pk=.c9eb4a9e-a522-46db-95a2-c81f347f8165@github.com>
Message-ID: <B0oitB8qTAfXErrg1mIv1VxPkJR9rceFd-mGakYqpiw=.a9cb0a12-ddd2-4086-a344-cfc66ede6ddd@github.com>

On Thu, 11 May 2023 22:16:18 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> src/guide/jbs-jdk-bug-system.md line 77:
>> 
>>> 75:     * logs which may include sensitive data
>>> 76: * If the failure isn't reproducible with an existing OpenJDK test, attach a reproducer if possible, while in a number of cases it isn't possible, having a test case will decrease the time required to resolve the issue.
>>> 77: * Only set [CPU]{.jbs-field} and/or [OS]{.jbs-field} fields if the bug **ONLY** happens on that particular platform or set of platforms.
>> 
>> This would be ideal but in practice very hard. Most people would set this to the platform they saw the problem on. There is very little chance they can know, or can find out, whether it only happens on that platform. The person later working on the bug can update these fields if needed, but in my experience very few people use these fields in a meaningful way.
>
> I think that's why we want people to only set it if they know. Maybe it should even more clear. My initial intention when writing that sentence was to discourage people from using those fields for that very reason that you mention - they are almost never used in the right way.

Update it to
In general the [CPU]{.jbs-field} and/or [OS]{.jbs-field} fields should not be set. **ONLY** use them if you know that the issue is only relevant to a particular platform or set of platforms.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1192775884

From duke at openjdk.org  Fri May 12 20:42:15 2023
From: duke at openjdk.org (calnan)
Date: Fri, 12 May 2023 20:42:15 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v7]
In-Reply-To: <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
Message-ID: <slBbxiob1XUWHLR1XVLMQJCfKGHuw8aWZxwAaNUMs6w=.6e09b191-513d-465a-98d4-68f7765455f9@github.com>

On Tue, 21 Mar 2023 04:50:08 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated the definition of a regression and a few other minor updates.
>
> src/guide/jbs-jdk-bug-system.md line 68:
> 
>> 66:     * error messages
>> 67:     * assert messages
>> 68:     * stack trace
> 
> I'd qualify this by saying attach hs_err logs, or other log files, rather than putting the content of the log in the issue descriptions.

added a comment to that effect

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1192774027

From jwilhelm at openjdk.org  Tue May 16 14:42:37 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 16 May 2023 14:42:37 GMT
Subject: RFR: Clarifications on becoming an Author
Message-ID: <G6PQtcqXwvLvH18LA-bEjV6tLmtQCpAps2-2bQgJfKw=.74e359fc-b2c0-4fdd-9759-7f48ff7c534b@github.com>

Did a test run of the text with a new contributor who was trying to become Author. Some clarifications needed.

-------------

Commit messages:
 - Clarifications on becoming an Author

Changes: https://git.openjdk.org/guide/pull/102/files
 Webrev: https://webrevs.openjdk.org/?repo=guide&pr=102&range=00
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/guide/pull/102.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/102/head:pull/102

PR: https://git.openjdk.org/guide/pull/102

From duke at openjdk.org  Tue May 16 15:00:27 2023
From: duke at openjdk.org (calnan)
Date: Tue, 16 May 2023 15:00:27 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v8]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with two additional commits since the last revision:

 - Adjusted the wording on setting the priority
 - Updates to address additional comments

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/4a650a6f..39c42112

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=07
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=06-07

  Stats: 9 lines in 1 file changed: 3 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From iris at openjdk.org  Tue May 16 17:58:13 2023
From: iris at openjdk.org (Iris Clark)
Date: Tue, 16 May 2023 17:58:13 GMT
Subject: RFR: Clarifications on becoming an Author
In-Reply-To: <G6PQtcqXwvLvH18LA-bEjV6tLmtQCpAps2-2bQgJfKw=.74e359fc-b2c0-4fdd-9759-7f48ff7c534b@github.com>
References: <G6PQtcqXwvLvH18LA-bEjV6tLmtQCpAps2-2bQgJfKw=.74e359fc-b2c0-4fdd-9759-7f48ff7c534b@github.com>
Message-ID: <KT8_zfqPe288o1NDnjcSQppZmff85pLCykksL94HpS8=.2c895597-beb7-4d49-a281-3492119de5f9@github.com>

On Tue, 16 May 2023 14:36:13 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Did a test run of the text with a new contributor who was trying to become Author. Some clarifications needed.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/guide/pull/102#pullrequestreview-1429114101

From ehelin at openjdk.org  Tue May 16 19:16:10 2023
From: ehelin at openjdk.org (Erik Helin)
Date: Tue, 16 May 2023 19:16:10 GMT
Subject: RFR: Clarifications on becoming an Author
In-Reply-To: <G6PQtcqXwvLvH18LA-bEjV6tLmtQCpAps2-2bQgJfKw=.74e359fc-b2c0-4fdd-9759-7f48ff7c534b@github.com>
References: <G6PQtcqXwvLvH18LA-bEjV6tLmtQCpAps2-2bQgJfKw=.74e359fc-b2c0-4fdd-9759-7f48ff7c534b@github.com>
Message-ID: <1fPwdjMKCwnKGpHqtmnczGzO5AsVE0gu1C87qfbTGpY=.08070570-ec9b-4256-9605-ccca224f5428@github.com>

On Tue, 16 May 2023 14:36:13 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Did a test run of the text with a new contributor who was trying to become Author. Some clarifications needed.

src/guide/introduction.md line 42:

> 40: To see who the project lead is for your project, see the [OpenJDK Census](https://openjdk.org/census). The Census unfortunately doesn't provide email addresses for people, but assuming you have been active on the project mailing list (since you are applying for Author after all), you should be able to find the lead's email address in your local email archive, or ask your sponsor.
> 41: 
> 42: As an Author you will get your OpenJDK user name. Once you have gotten the user name, this should be associated with your GitHub account in order for the bots to be able to identify you on GitHub. See the [Skara documentation](https://wiki.openjdk.org/display/SKARA#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername) for more details on that. Once that's done you can create PRs and get them reviewed, but you will still need a sponsor to approve your change before it can be integrated. You'll also get write access to [JBS](#jbs---jdk-bug-system) and the [OpenJDK wiki](https://wiki.openjdk.org) related to the project in question, and to [cr.openjdk.java.net](https://cr.openjdk.java.net) via an SSH key provided at the time you accept your invitation.

Suggestion:

As an Author you will get your OpenJDK user name. Once you have gotten the user name, this should be associated with your GitHub account in order for the bots to be able to identify you on GitHub. See the [Skara documentation](https://wiki.openjdk.org/display/SKARA#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername) for more details on that. Once that's done you can create PRs and get them reviewed, but you will still need a sponsor to approve your change before it can be integrated. You'll also get write access to [JBS](#jbs---jdk-bug-system) and the [OpenJDK wiki](https://wiki.openjdk.org) related to the project in question, and to [cr.openjdk.org](https://cr.openjdk.org) via an SSH key provided at the time you accept your invitation.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/102#discussion_r1195591586

From duke at openjdk.org  Wed May 17 01:18:09 2023
From: duke at openjdk.org (calnan)
Date: Wed, 17 May 2023 01:18:09 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v8]
In-Reply-To: <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <Ge-TD4GO5UTx0atD7Y3q1GujMtDaYv4qONPqb9RfIPI=.957aceed-5688-48dc-b8e2-4bef742c5b4c@github.com>
 <9xqvkA2D3sUZ_m3on8hEGtWM1BLm8XCglqX72sDzPQQ=.8f8fa654-e557-4269-800e-c432756402ea@github.com>
Message-ID: <5YW3irTgedkPeKkYmC4q_ei1RuDUemp17uXvd95Qigo=.7110cbaa-1bdf-46fa-9bd0-48d3c8baed7e@github.com>

On Tue, 21 Mar 2023 04:48:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Adjusted the wording on setting the priority
>>  - Updates to address additional comments
>
> src/guide/jbs-jdk-bug-system.md line 63:
> 
>> 61:     * If the failure is found in an update train of the JDK (e.g. 11.0.x), please make an effort to see if it is also present in [mainline](https://github.com/openjdk/jdk).
>> 62: * Set the priority
>> 63:     * It's not the reporter's responsibility to set a correct priority, but a qualified guess is always better than the default.
> 
> I don't think this is useful unless we actually specify what P1-P5 should mean. Otherwise may as well take the default and let triage teams re-evaluate it.

Added text with a overview of the priorities and saying to leave it as the default unless the reporter feels that is not right

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1195297461

From dholmes at openjdk.org  Wed May 17 01:18:09 2023
From: dholmes at openjdk.org (David Holmes)
Date: Wed, 17 May 2023 01:18:09 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v8]
In-Reply-To: <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>
Message-ID: <mZeycPM4XX6MAzPaBEdB_NQmqTbIdGrc-PDwViIcUOU=.fa997ab8-1725-4042-912b-f3a35272dbb2@github.com>

On Tue, 16 May 2023 15:00:27 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Adjusted the wording on setting the priority
>  - Updates to address additional comments

src/guide/jbs-jdk-bug-system.md line 55:

> 53: 
> 54: * If you suspect that the issue is a vulnerability, **don't file a JBS issue**, instead send your report to [vuln-report at openjdk.org](mailto:vuln-report at openjdk.org), also use this alias if you find an existing report which may be a vulnerability. Please do *not* report or discuss potential vulnerabilities on any open lists or other public channels - see [OpenJDK Vulnerabilities](https://openjdk.org/groups/vulnerability/report) for more information.
> 55: * a [Bug]{.jbs} or [Enhancement]{.jbs-field} should only be used if the work is expected to result in a change in a code repository. A [Bug]{.jbs-field} or [Enhancement]{.jbs-field} with resolution Fixed is required to have a corresponding changeset in one of the OpenJDK repositories.

Sentence should start with capital A

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1195827644

From dholmes at openjdk.org  Wed May 17 01:22:08 2023
From: dholmes at openjdk.org (David Holmes)
Date: Wed, 17 May 2023 01:22:08 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v8]
In-Reply-To: <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>
Message-ID: <nzc1V1NS9Nr2aQEeTrNlZUgbl-CehFHGvpV-1bS2kwQ=.6a3253a9-509d-4232-bb26-63c5b3929293@github.com>

On Tue, 16 May 2023 15:00:27 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Adjusted the wording on setting the priority
>  - Updates to address additional comments

src/guide/jbs-jdk-bug-system.md line 179:

> 177: ## Triaging an issue
> 178: 
> 179: For the most OpenJDK groups Triage is performed on a regular basis (at least weekly) by triage teams. Each triage team consists of contributors who are area experts for that group of issues. If you haven't been selected to be part of a triage team for a specific area you shouldn't be triaging bugs in that area.

Typo s/For the most/For most/

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1195829503

From dholmes at openjdk.org  Wed May 17 01:28:11 2023
From: dholmes at openjdk.org (David Holmes)
Date: Wed, 17 May 2023 01:28:11 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v8]
In-Reply-To: <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>
Message-ID: <54PGdsGlWb5JRsliZCH1BL3RT0zqclQdp75k22ouZsI=.a73563ac-d756-487e-97e6-e2db67bae6cc@github.com>

On Tue, 16 May 2023 15:00:27 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Adjusted the wording on setting the priority
>  - Updates to address additional comments

src/guide/jbs-jdk-bug-system.md line 230:

> 228: ## Resolving an issue
> 229: 
> 230: Once the work on an issue has been completed the issue should be in a "closed" state.  There are two "closed" states: [Resolved]{.jbs-field} and [Closed]{.jbs-field} which can be used interchangeably except in the case of [Fixed]{.jbs-field}, or when flagged as  [Incomplete]{.jbs-field} (See Triaging).

There is also a discrepancy in terms of JBS operation when it comes to closing as a duplicate. If you use "Close" then you get the UI that allows you to set the Resolution as "Duplicate" and link to the issue which is duplicated. However, if you use Resolve then the ability to link in the UI is not there.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1195831948

From duke at openjdk.org  Wed May 17 13:59:15 2023
From: duke at openjdk.org (calnan)
Date: Wed, 17 May 2023 13:59:15 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v8]
In-Reply-To: <54PGdsGlWb5JRsliZCH1BL3RT0zqclQdp75k22ouZsI=.a73563ac-d756-487e-97e6-e2db67bae6cc@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>
 <54PGdsGlWb5JRsliZCH1BL3RT0zqclQdp75k22ouZsI=.a73563ac-d756-487e-97e6-e2db67bae6cc@github.com>
Message-ID: <U9_YtpQtoZROq0V_xGU9ed0caJQ1Y55eGV1yfdZ02zI=.56ada3f2-894b-46f4-adb9-9f3909e99716@github.com>

On Wed, 17 May 2023 01:25:23 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Adjusted the wording on setting the priority
>>  - Updates to address additional comments
>
> src/guide/jbs-jdk-bug-system.md line 230:
> 
>> 228: ## Resolving an issue
>> 229: 
>> 230: Once the work on an issue has been completed the issue should be in a "closed" state.  There are two "closed" states: [Resolved]{.jbs-field} and [Closed]{.jbs-field} which can be used interchangeably except in the case of [Fixed]{.jbs-field}, or when flagged as  [Incomplete]{.jbs-field} (See Triaging).
> 
> There is also a discrepancy in terms of JBS operation when it comes to closing as a duplicate. If you use "Close" then you get the UI that allows you to set the Resolution as "Duplicate" and link to the issue which is duplicated. However, if you use Resolve then the ability to link in the UI is not there.

That is a good point and leads to bugs being closed as duplicates without a duplicate link - I have a "filter" to look for these.

in the duplicate section of the following table it says:

Remember to add a [duplicates]{.jbs-field} link - not a [relates to]{.jbs-field} link</td>

Let me make that more explicit with the text you have above

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1196566108

From duke at openjdk.org  Wed May 17 15:05:17 2023
From: duke at openjdk.org (calnan)
Date: Wed, 17 May 2023 15:05:17 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  Fixed a couple of typos, made sure bullets start with a capital and end with a full stop - except for non-sentence bullets.  Clarified how to close a duplicate

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/39c42112..1c44aa9e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=08
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=07-08

  Stats: 39 lines in 1 file changed: 1 ins; 0 del; 38 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From duke at openjdk.org  Wed May 17 15:05:25 2023
From: duke at openjdk.org (calnan)
Date: Wed, 17 May 2023 15:05:25 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v8]
In-Reply-To: <nzc1V1NS9Nr2aQEeTrNlZUgbl-CehFHGvpV-1bS2kwQ=.6a3253a9-509d-4232-bb26-63c5b3929293@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>
 <nzc1V1NS9Nr2aQEeTrNlZUgbl-CehFHGvpV-1bS2kwQ=.6a3253a9-509d-4232-bb26-63c5b3929293@github.com>
Message-ID: <O7pdAqRnh3r3WyjGJ9CXCe52hZX39TcA6mNCZwhqOiE=.f1ad2b05-03f4-4ce3-85f2-1eeb51bf8aed@github.com>

On Wed, 17 May 2023 01:19:25 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Adjusted the wording on setting the priority
>>  - Updates to address additional comments
>
> src/guide/jbs-jdk-bug-system.md line 179:
> 
>> 177: ## Triaging an issue
>> 178: 
>> 179: For the most OpenJDK groups Triage is performed on a regular basis (at least weekly) by triage teams. Each triage team consists of contributors who are area experts for that group of issues. If you haven't been selected to be part of a triage team for a specific area you shouldn't be triaging bugs in that area.
> 
> Typo s/For the most/For most/

fixed

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1196662406

From jwilhelm at openjdk.org  Wed May 17 15:47:18 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 17 May 2023 15:47:18 GMT
Subject: RFR: Updated Code Owners for JDK 20
Message-ID: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>

This should be done after each release to make sure the list is kept up to date.

-------------

Commit messages:
 - Updated Code Owners for JDK 20

Changes: https://git.openjdk.org/guide/pull/103/files
 Webrev: https://webrevs.openjdk.org/?repo=guide&pr=103&range=00
  Stats: 136 lines in 1 file changed: 62 ins; 12 del; 62 mod
  Patch: https://git.openjdk.org/guide/pull/103.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/103/head:pull/103

PR: https://git.openjdk.org/guide/pull/103

From jwilhelm at openjdk.org  Wed May 17 15:48:13 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 17 May 2023 15:48:13 GMT
Subject: RFR: Clarifications on becoming an Author [v2]
In-Reply-To: <G6PQtcqXwvLvH18LA-bEjV6tLmtQCpAps2-2bQgJfKw=.74e359fc-b2c0-4fdd-9759-7f48ff7c534b@github.com>
References: <G6PQtcqXwvLvH18LA-bEjV6tLmtQCpAps2-2bQgJfKw=.74e359fc-b2c0-4fdd-9759-7f48ff7c534b@github.com>
Message-ID: <szbDYehIFV5GM-ngGLBaXHV6eXZ0DRXpaHnTnEvdtlk=.3621706d-db0e-4ab1-a102-6a9ea31a24f8@github.com>

> Did a test run of the text with a new contributor who was trying to become Author. Some clarifications needed.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Update src/guide/introduction.md
  
  Co-authored-by: Erik Duveblad <erik.helin at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/102/files
  - new: https://git.openjdk.org/guide/pull/102/files/4f65f465..52428cde

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=102&range=01
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=102&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/102.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/102/head:pull/102

PR: https://git.openjdk.org/guide/pull/102

From jwilhelm at openjdk.org  Wed May 17 15:48:15 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 17 May 2023 15:48:15 GMT
Subject: Integrated: Clarifications on becoming an Author
In-Reply-To: <G6PQtcqXwvLvH18LA-bEjV6tLmtQCpAps2-2bQgJfKw=.74e359fc-b2c0-4fdd-9759-7f48ff7c534b@github.com>
References: <G6PQtcqXwvLvH18LA-bEjV6tLmtQCpAps2-2bQgJfKw=.74e359fc-b2c0-4fdd-9759-7f48ff7c534b@github.com>
Message-ID: <H0lXpVQG6AtRus8EtD0kv2NKLNm9qIxIdDrKMftRzak=.66267bbc-2735-478a-bce5-c5b7f58661a7@github.com>

On Tue, 16 May 2023 14:36:13 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> Did a test run of the text with a new contributor who was trying to become Author. Some clarifications needed.

This pull request has now been integrated.

Changeset: f8ef1101
Author:    Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/f8ef1101596c2785a5fa275e419d3369e53d118d
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

Clarifications on becoming an Author

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/guide/pull/102

From stefank at openjdk.org  Wed May 17 15:55:55 2023
From: stefank at openjdk.org (Stefan Karlsson)
Date: Wed, 17 May 2023 15:55:55 GMT
Subject: RFR: Updated Code Owners for JDK 20
In-Reply-To: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
Message-ID: <D4seKJdf1b-oCfjvShfovuUj3mAr6_pxd5VV3wRAKLA=.90efe23c-9e60-47c2-abf0-3363b10d69ae@github.com>

On Wed, 17 May 2023 15:41:34 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> This should be done after each release to make sure the list is kept up to date.

Marked as reviewed by stefank (no project role).

src/guide/code-owners.md line 59:

> 57:     * `logging` ? Runtime
> 58:     * `memory` ? Runtime, GC
> 59:     * `metaprogramming` ? Runtime

metaprogramming should probably be HotSpot instead of Runtime. The rest of the HotSpot directories look fine to me.

-------------

PR Review: https://git.openjdk.org/guide/pull/103#pullrequestreview-1431049790
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196736754

From iris at openjdk.org  Wed May 17 15:58:41 2023
From: iris at openjdk.org (Iris Clark)
Date: Wed, 17 May 2023 15:58:41 GMT
Subject: RFR: Updated Code Owners for JDK 20
In-Reply-To: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
Message-ID: <vhywykOmqJRg1477QcdR17PeYxSdTVt2FfMA_C12IuE=.bfe7d7ea-197f-4aec-a651-cdbcf739ce8a@github.com>

On Wed, 17 May 2023 15:41:34 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> This should be done after each release to make sure the list is kept up to date.

Marked as reviewed by iris (Reviewer).

src/guide/code-owners.md line 84:

> 82:       * `loader` ? Core Libs
> 83:       * `logger` ? Core Libs
> 84:       * `math` ? Java Language

I think `java.math` should be Core Libraries.  I could perhaps see the argument that the wrapper classes are very close to the Java Language, but those are in `java.lang`.   `java.math` contains the floating-point implementation.

src/guide/code-owners.md line 101:

> 99:     * `java`
> 100:       * `lang` ? Core Libs
> 101:       * `math` ? Java Language

Same comment as line 84.

src/guide/code-owners.md line 107:

> 105:     * `net` ? Net
> 106:     * `nio` ? NIO
> 107:     * `reflect` ? Java Language

I'm not sure I agree with this change.  The reflection code is certainly discussed in core-lang-dev.

src/guide/code-owners.md line 119:

> 117:   * `lib/security` ? Security
> 118:   * `man`
> 119:     * `java.1` ? JDK Tools

I'd add Hotspot to this list.

-------------

PR Review: https://git.openjdk.org/guide/pull/103#pullrequestreview-1431040545
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196730797
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196734106
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196733781
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196736047

From stefank at openjdk.org  Wed May 17 16:08:21 2023
From: stefank at openjdk.org (Stefan Karlsson)
Date: Wed, 17 May 2023 16:08:21 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
Message-ID: <goztu8Oz6MFc7bQ9n4gSmbgFotqCm4iAJG8040GAwaA=.75a7960f-7b68-4573-9b28-340927d00d3e@github.com>

On Wed, 17 May 2023 15:05:17 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed a couple of typos, made sure bullets start with a capital and end with a full stop - except for non-sentence bullets.  Clarified how to close a duplicate

src/guide/jbs-jdk-bug-system.md line 101:

> 99: 
> 100: ### Implementing a JEP
> 101: It recommended that for [JEP]{.jbs-field}s that the implementation is spread across one or more [Enhancement]{.jbs-field}s as above.

It => It is?

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1196755391

From stefank at openjdk.org  Wed May 17 16:18:18 2023
From: stefank at openjdk.org (Stefan Karlsson)
Date: Wed, 17 May 2023 16:18:18 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
Message-ID: <-vF2vQz_Qw9xHlYnAy9HF6Q6Am3WDitrsAQHbYzetzA=.c6729f41-9847-4d5a-bfef-79bf555b0b05@github.com>

On Wed, 17 May 2023 15:05:17 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed a couple of typos, made sure bullets start with a capital and end with a full stop - except for non-sentence bullets.  Clarified how to close a duplicate

src/guide/jbs-jdk-bug-system.md line 205:

> 203:     1. Bugs that do not affect product code, but are only against the regression test: 'noreg-self'
> 204:     1. Issues that seem to be trivial to fix: 'starter'
> 205:     1. RFEs that are pure cleanups: 'noreg-cleanup'

As I understand it, the noreg- labels are there to indicate the reason why there is *no reg*ression test. So, pure cleanups are typically labeled with 'cleanup' and 'noreg-cleanup' is later used by SQE to note why there's no regression test for the pushed change.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1196771781

From stefank at openjdk.org  Wed May 17 16:22:15 2023
From: stefank at openjdk.org (Stefan Karlsson)
Date: Wed, 17 May 2023 16:22:15 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
Message-ID: <G2sCNjfilbueVfkLN8wjgCr19CWpBOg9CkLq1GX03p0=.0a639994-7ded-46bb-ae91-5fa1ac4799f8@github.com>

On Wed, 17 May 2023 15:05:17 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed a couple of typos, made sure bullets start with a capital and end with a full stop - except for non-sentence bullets.  Clarified how to close a duplicate

src/guide/jbs-jdk-bug-system.md line 238:

> 236:     <td class="dictionary">If a change is required in a repo to address an issue then the [Fixed]{.jbs-field} status should be used - for the JDK project in almost all cases the bots will transition the issue to [Fixed]{.jbs-field} when the changeset is pushed to the repo.<br />
> 237: <ul>
> 238:         <li>Once a bug is marked as fixed there is now the option of someone, other than the person that fixed it, marking it as [Verified]{.jbs-field} to confirm that the issue is fix after testing; marking it as [Fix Failed]{.jbs-field} if it did not solve the issue; or, [Not Verified]{.jbs-field} to indicate that it wasn't explicitly tested.  Note that the UI does not highlight when [Fix Failed]{.jbs-field} has been set, you need to look for the [Verification]{.jbs-label} Field at the bottom of the left-hand colum in the Details section.</li>

issue is fix => issue is fixed?

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1196776531

From stefank at openjdk.org  Wed May 17 16:27:10 2023
From: stefank at openjdk.org (Stefan Karlsson)
Date: Wed, 17 May 2023 16:27:10 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
Message-ID: <Nt9ct_ltyENmXefB1pTcmoDKCHfM67ia9BDBbDCykZQ=.b40cc16f-c902-4e67-b03a-01d864675095@github.com>

On Wed, 17 May 2023 15:05:17 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed a couple of typos, made sure bullets start with a capital and end with a full stop - except for non-sentence bullets.  Clarified how to close a duplicate

src/guide/jbs-jdk-bug-system.md line 668:

> 666:     <td class="dictionary">[[regression]{.jbs-label}]{#regression}</td>
> 667:     <td class="dictionary">
> 668:       Used to identify regressions. A regression is where behavior has _incorrectly_ changed from a previous build or release. Ideally all regressions must be fixed in the following release. All regressions must have the [Affects Version/s]{.jbs-field} set.

> Ideally all regressions must be fixed in the following release

This sounds weird. Ideally we identify and fix the regressions before they are released. We don't wait until the following release to fix them.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1196782400

From stefank at openjdk.org  Wed May 17 16:33:36 2023
From: stefank at openjdk.org (Stefan Karlsson)
Date: Wed, 17 May 2023 16:33:36 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
Message-ID: <OMAtYfDHVxB_xuyCNXPFyOQty3SvoAGj52g4VQ5MKhQ=.c127cab9-54c7-4503-9eda-c7670a676664@github.com>

On Wed, 17 May 2023 15:05:17 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed a couple of typos, made sure bullets start with a capital and end with a full stop - except for non-sentence bullets.  Clarified how to close a duplicate

src/guide/jbs-jdk-bug-system.md line 177:

> 175: :::
> 176: 
> 177: ## Triaging an issue

While reading this section I'm thinking about a common situation. One team performs the initial triage, including moving the issue to the Open state. Later that team realizes that another team should own the bug. If they just move it over to the other team, that team's triage team will not notice that issue while triaging bugs, and the bug goes undetected until much later. Therefore we typically change the state from Open to New when moving bugs across teams.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1196788973

From darcy at openjdk.org  Wed May 17 16:34:18 2023
From: darcy at openjdk.org (Joe Darcy)
Date: Wed, 17 May 2023 16:34:18 GMT
Subject: RFR: Updated Code Owners for JDK 20
In-Reply-To: <vhywykOmqJRg1477QcdR17PeYxSdTVt2FfMA_C12IuE=.bfe7d7ea-197f-4aec-a651-cdbcf739ce8a@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <vhywykOmqJRg1477QcdR17PeYxSdTVt2FfMA_C12IuE=.bfe7d7ea-197f-4aec-a651-cdbcf739ce8a@github.com>
Message-ID: <_7FnZ79Q7OJuUAQhrIyZ_6bgOoBiYfYbfv3p7-uGt-0=.ba997234-9d46-4f2f-a43d-33bf9b537317@github.com>

On Wed, 17 May 2023 15:48:13 GMT, Iris Clark <iris at openjdk.org> wrote:

> I think `java.math` should be Core Libraries. I could perhaps see the argument that the wrapper classes are very close to the Java Language, but those are in `java.lang`. `java.math` contains the floating-point implementation.

Yes, the directory "java/math" is for BigInteger and BigDecimal which are squarely in core-libs.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196789853

From darcy at openjdk.org  Wed May 17 16:41:16 2023
From: darcy at openjdk.org (Joe Darcy)
Date: Wed, 17 May 2023 16:41:16 GMT
Subject: RFR: Updated Code Owners for JDK 20
In-Reply-To: <vhywykOmqJRg1477QcdR17PeYxSdTVt2FfMA_C12IuE=.bfe7d7ea-197f-4aec-a651-cdbcf739ce8a@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <vhywykOmqJRg1477QcdR17PeYxSdTVt2FfMA_C12IuE=.bfe7d7ea-197f-4aec-a651-cdbcf739ce8a@github.com>
Message-ID: <bVVcspduTUDhsehYdv36QOvzdR762Vy7wQIP7pNHDcI=.d2fbb360-0a2f-4721-ac1f-719b252444d7@github.com>

On Wed, 17 May 2023 15:50:43 GMT, Iris Clark <iris at openjdk.org> wrote:

> I'm not sure I agree with this change. The reflection code is certainly discussed in core-lang-dev.

While reflection does at times need to bridge over to other areas, such as how a Java compiler implements a language construct, etc., the primary discussion should be on core libs with other areas involved as needed for a particular issue.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196796720

From jwilhelm at openjdk.org  Wed May 17 17:03:33 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 17 May 2023 17:03:33 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
Message-ID: <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>

> This should be done after each release to make sure the list is kept up to date.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Fixed comments

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/103/files
  - new: https://git.openjdk.org/guide/pull/103/files/dc48ab26..d33cceb7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=103&range=01
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=103&range=00-01

  Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/guide/pull/103.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/103/head:pull/103

PR: https://git.openjdk.org/guide/pull/103

From jwilhelm at openjdk.org  Wed May 17 17:03:36 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 17 May 2023 17:03:36 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <D4seKJdf1b-oCfjvShfovuUj3mAr6_pxd5VV3wRAKLA=.90efe23c-9e60-47c2-abf0-3363b10d69ae@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <D4seKJdf1b-oCfjvShfovuUj3mAr6_pxd5VV3wRAKLA=.90efe23c-9e60-47c2-abf0-3363b10d69ae@github.com>
Message-ID: <rI9-U4OakNAKoKWIXoCsgRFFPl2qgaaHL5b7pF49V8E=.95728541-8557-4d0d-bac7-b67face6c120@github.com>

On Wed, 17 May 2023 15:53:21 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed comments
>
> Marked as reviewed by stefank (no project role).

Updated according to comments. Thank you for reviewing @stefank @irisclark @jddarcy

-------------

PR Comment: https://git.openjdk.org/guide/pull/103#issuecomment-1551760524

From prr at openjdk.org  Wed May 17 18:04:15 2023
From: prr at openjdk.org (Phil Race)
Date: Wed, 17 May 2023 18:04:15 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
Message-ID: <GA-7b6Y-vqk3CWV0FAElu_fqYOoP_jARmPUIEHKHtAc=.76a8bf1f-67fd-45ec-8921-8988a8f6890a@github.com>

On Wed, 17 May 2023 17:03:33 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> This should be done after each release to make sure the list is kept up to date.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed comments

Changes requested by prr (Author).

src/guide/code-owners.md line 10:

> 8: * Client
> 9:   * Client Libs: [`client-libs-dev`](https://mail.openjdk.org/mailman/listinfo/client-libs-dev)
> 10:   * Project Wakefield: [`wakefield-dev`](https://mail.openjdk.org/mailman/listinfo/wakefield-dev)

I'm a bit surprised to see projects like Wakefield and Panama as "areas" .. not sure I understand the logic of including
these here at all.

src/guide/code-owners.md line 194:

> 192: * `jdk.jfr` ? JFR
> 193: * `jdk.jlink` ? JDK Tools
> 194: * `jdk.jpackage` ? Client Libs

"client libs" != "Client" 

Client libs is about the desktop APIs used at run time.
jpackage is an installer technology - for desktops and servers
jdk.jpackage would be better as Core Libs like you have for the jpackage tool, or left as is. Client Libs is definitely wrong.
The existing words try to say "this is the implementation of the jpackage tool, which happens to be owned by the client team but isn't at all a part of client desktop". 
The issue is that this is installer technology and historically all installers were owned by client, since the desktop installers were the main focus.
You should think of this as being a case of wearing two hats.

-------------

PR Review: https://git.openjdk.org/guide/pull/103#pullrequestreview-1431268322
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196878600
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196885379

From duke at openjdk.org  Wed May 17 20:53:21 2023
From: duke at openjdk.org (calnan)
Date: Wed, 17 May 2023 20:53:21 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <OMAtYfDHVxB_xuyCNXPFyOQty3SvoAGj52g4VQ5MKhQ=.c127cab9-54c7-4503-9eda-c7670a676664@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
 <OMAtYfDHVxB_xuyCNXPFyOQty3SvoAGj52g4VQ5MKhQ=.c127cab9-54c7-4503-9eda-c7670a676664@github.com>
Message-ID: <k4n2MyiQR9RwEoJu8iO42ECNK7c4M4_zleexPfyLQr0=.637d0784-1e2a-494d-92ac-880d9d0d7482@github.com>

On Wed, 17 May 2023 16:31:01 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed a couple of typos, made sure bullets start with a capital and end with a full stop - except for non-sentence bullets.  Clarified how to close a duplicate
>
> src/guide/jbs-jdk-bug-system.md line 177:
> 
>> 175: :::
>> 176: 
>> 177: ## Triaging an issue
> 
> While reading this section I'm thinking about a common situation. One team performs the initial triage, including moving the issue to the Open state. Later that team realizes that another team should own the bug. If they just move it over to the other team, that team's triage team will not notice that issue while triaging bugs, and the bug goes undetected until much later. Therefore we typically change the state from Open to New when moving bugs across teams.

Correct see line 184:
If the issue belongs to a different area (it was filed in libraries, but it is an HotSpot issue), transfer it to the correct component/subcomponent making sure that the state remains New.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1197041777

From mullan at openjdk.org  Wed May 17 21:00:15 2023
From: mullan at openjdk.org (Sean Mullan)
Date: Wed, 17 May 2023 21:00:15 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
Message-ID: <Tp3QUvavpfHJhzHRBYocNhoWZrDeAi8DxVLYunt3RSQ=.9d1ff0e4-80e8-4743-ae17-7bfb9bae981c@github.com>

On Wed, 17 May 2023 17:03:33 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> This should be done after each release to make sure the list is kept up to date.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed comments

src/guide/code-owners.md line 70:

> 68: * `java.base`
> 69:   * Core Libs should almost always be included but Java Language, HotSpot, Security and/or I18n may also be involved.
> 70:   * `classes`

Why isn't the `share` directory included here as in `hotspot`? Are these supposed to be full path names? It seems we should be consistent.

src/guide/code-owners.md line 72:

> 70:   * `classes`
> 71:     * `crypto` ? Security
> 72:     * `internal`

Should this be `jdk/internal`?

src/guide/code-owners.md line 99:

> 97:     * `invoke` ? Core Libs
> 98:     * `io` ? NIO
> 99:     * `java`

Missing `security` and several other directories under `java`.

src/guide/code-owners.md line 108:

> 106:     * `nio` ? NIO
> 107:     * `reflect` ? Java Language
> 108:     * `security` ? Security

Should be under `java`.

src/guide/code-owners.md line 109:

> 107:     * `reflect` ? Java Language
> 108:     * `security` ? Security
> 109:     * `sun/crypto` ? Security

There is no such directory named `sun/crypto` - you probably mean `com/sun/crypto` and `com/sun/security`.

src/guide/code-owners.md line 185:

> 183: * `jdk.internal.vm.compiler` ? Compiler
> 184: * `jdk.internal.vm.compiler.management` ? Compiler
> 185: * `jdk.jartool` ? JDK Tools

and Security because this includes `jarsigner`.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197039265
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197040362
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197042709
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197043059
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197043528
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197046002

From mullan at openjdk.org  Wed May 17 21:00:15 2023
From: mullan at openjdk.org (Sean Mullan)
Date: Wed, 17 May 2023 21:00:15 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <Tp3QUvavpfHJhzHRBYocNhoWZrDeAi8DxVLYunt3RSQ=.9d1ff0e4-80e8-4743-ae17-7bfb9bae981c@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
 <Tp3QUvavpfHJhzHRBYocNhoWZrDeAi8DxVLYunt3RSQ=.9d1ff0e4-80e8-4743-ae17-7bfb9bae981c@github.com>
Message-ID: <gBrExoe09n_m1CAdqz6xKtrdk1Qy0O4D58_dX55cI7o=.1031d70c-9387-4756-bd04-e18fe27333a1@github.com>

On Wed, 17 May 2023 20:53:00 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed comments
>
> src/guide/code-owners.md line 109:
> 
>> 107:     * `reflect` ? Java Language
>> 108:     * `security` ? Security
>> 109:     * `sun/crypto` ? Security
> 
> There is no such directory named `sun/crypto` - you probably mean `com/sun/crypto` and `com/sun/security`.

Missing several other directories under `sun`.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197044162

From duke at openjdk.org  Wed May 17 21:00:49 2023
From: duke at openjdk.org (calnan)
Date: Wed, 17 May 2023 21:00:49 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v10]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <CkfBYDCVaEmoWdruetWUgZtfrcGB1Z6XkT_EwSfN3F0=.9a0a0455-0f33-408d-9be8-528d602f729a@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  minor formatting changes, some typos fixed and clarification on fixing regressions

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/1c44aa9e..8e44a3ec

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=09
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=08-09

  Stats: 20 lines in 1 file changed: 0 ins; 0 del; 20 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From duke at openjdk.org  Wed May 17 21:00:53 2023
From: duke at openjdk.org (calnan)
Date: Wed, 17 May 2023 21:00:53 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <goztu8Oz6MFc7bQ9n4gSmbgFotqCm4iAJG8040GAwaA=.75a7960f-7b68-4573-9b28-340927d00d3e@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
 <goztu8Oz6MFc7bQ9n4gSmbgFotqCm4iAJG8040GAwaA=.75a7960f-7b68-4573-9b28-340927d00d3e@github.com>
Message-ID: <E7uCjHMk07uqTSoRoOSJaNF9xYYGJTQnsaSlkyfcKdI=.29d5c1e6-92df-4237-a6a9-42cecbb84afa@github.com>

On Wed, 17 May 2023 16:05:20 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed a couple of typos, made sure bullets start with a capital and end with a full stop - except for non-sentence bullets.  Clarified how to close a duplicate
>
> src/guide/jbs-jdk-bug-system.md line 101:
> 
>> 99: 
>> 100: ### Implementing a JEP
>> 101: It recommended that for [JEP]{.jbs-field}s that the implementation is spread across one or more [Enhancement]{.jbs-field}s as above.
> 
> It => It is?

fixed

> src/guide/jbs-jdk-bug-system.md line 238:
> 
>> 236:     <td class="dictionary">If a change is required in a repo to address an issue then the [Fixed]{.jbs-field} status should be used - for the JDK project in almost all cases the bots will transition the issue to [Fixed]{.jbs-field} when the changeset is pushed to the repo.<br />
>> 237: <ul>
>> 238:         <li>Once a bug is marked as fixed there is now the option of someone, other than the person that fixed it, marking it as [Verified]{.jbs-field} to confirm that the issue is fix after testing; marking it as [Fix Failed]{.jbs-field} if it did not solve the issue; or, [Not Verified]{.jbs-field} to indicate that it wasn't explicitly tested.  Note that the UI does not highlight when [Fix Failed]{.jbs-field} has been set, you need to look for the [Verification]{.jbs-label} Field at the bottom of the left-hand colum in the Details section.</li>
> 
> issue is fix => issue is fixed?

fixed (!)

> src/guide/jbs-jdk-bug-system.md line 668:
> 
>> 666:     <td class="dictionary">[[regression]{.jbs-label}]{#regression}</td>
>> 667:     <td class="dictionary">
>> 668:       Used to identify regressions. A regression is where behavior has _incorrectly_ changed from a previous build or release. Ideally all regressions must be fixed in the following release. All regressions must have the [Affects Version/s]{.jbs-field} set.
> 
>> Ideally all regressions must be fixed in the following release
> 
> This sounds weird. Ideally we identify and fix the regressions before they are released. We don't wait until the following release to fix them.

agreed, adjusted it to:
Ideally all regressions are identified and fixed before they are released, if not they must be fixed at latest in the following release after they are identified.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1197045004
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1197045115
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1197045207

From duke at openjdk.org  Wed May 17 21:00:55 2023
From: duke at openjdk.org (calnan)
Date: Wed, 17 May 2023 21:00:55 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v8]
In-Reply-To: <U9_YtpQtoZROq0V_xGU9ed0caJQ1Y55eGV1yfdZ02zI=.56ada3f2-894b-46f4-adb9-9f3909e99716@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>
 <54PGdsGlWb5JRsliZCH1BL3RT0zqclQdp75k22ouZsI=.a73563ac-d756-487e-97e6-e2db67bae6cc@github.com>
 <U9_YtpQtoZROq0V_xGU9ed0caJQ1Y55eGV1yfdZ02zI=.56ada3f2-894b-46f4-adb9-9f3909e99716@github.com>
Message-ID: <hMilkdVLwzrpN98IbaoZ2hZBrQgsiwjKQUjTWSqy53M=.002b7799-d79e-4a86-8cd3-9491cebc80b9@github.com>

On Wed, 17 May 2023 13:56:37 GMT, calnan <duke at openjdk.org> wrote:

>> src/guide/jbs-jdk-bug-system.md line 230:
>> 
>>> 228: ## Resolving an issue
>>> 229: 
>>> 230: Once the work on an issue has been completed the issue should be in a "closed" state.  There are two "closed" states: [Resolved]{.jbs-field} and [Closed]{.jbs-field} which can be used interchangeably except in the case of [Fixed]{.jbs-field}, or when flagged as  [Incomplete]{.jbs-field} (See Triaging).
>> 
>> There is also a discrepancy in terms of JBS operation when it comes to closing as a duplicate. If you use "Close" then you get the UI that allows you to set the Resolution as "Duplicate" and link to the issue which is duplicated. However, if you use Resolve then the ability to link in the UI is not there.
>
> That is a good point and leads to bugs being closed as duplicates without a duplicate link - I have a "filter" to look for these.
> 
> in the duplicate section of the following table it says:
> 
> Remember to add a [duplicates]{.jbs-field} link - not a [relates to]{.jbs-field} link</td>
> 
> Let me make that more explicit with the text you have above

done

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1197044949

From jwilhelm at openjdk.org  Wed May 17 21:58:20 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 17 May 2023 21:58:20 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <-vF2vQz_Qw9xHlYnAy9HF6Q6Am3WDitrsAQHbYzetzA=.c6729f41-9847-4d5a-bfef-79bf555b0b05@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
 <-vF2vQz_Qw9xHlYnAy9HF6Q6Am3WDitrsAQHbYzetzA=.c6729f41-9847-4d5a-bfef-79bf555b0b05@github.com>
Message-ID: <2urpPPLn4QI9hiB9Ahi9ozWXmyeeeAt5GlCUaK_kHJ4=.77d45c3b-aeef-44cb-97b5-360c42566906@github.com>

On Wed, 17 May 2023 16:15:12 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed a couple of typos, made sure bullets start with a capital and end with a full stop - except for non-sentence bullets.  Clarified how to close a duplicate
>
> src/guide/jbs-jdk-bug-system.md line 205:
> 
>> 203:     1. Bugs that do not affect product code, but are only against the regression test: 'noreg-self'
>> 204:     1. Issues that seem to be trivial to fix: 'starter'
>> 205:     1. RFEs that are pure cleanups: 'noreg-cleanup'
> 
> As I understand it, the noreg- labels are there to indicate the reason why there is *no reg*ression test. So, pure cleanups are typically labeled with 'cleanup' and 'noreg-cleanup' is later used by SQE to note why there's no regression test for the pushed change.

This is correct, but it's not only SQE that are allowed to set the noreg labels on issues. In triage we frequently set noreg-self on any test issues for instance. So I think it is fine for this text to recommend setting noreg-cleanup. Actually we probably could get rid of the cleanup label and only use noreg-cleanup.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1197091489

From jwilhelm at openjdk.org  Wed May 17 23:11:17 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 17 May 2023 23:11:17 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <GA-7b6Y-vqk3CWV0FAElu_fqYOoP_jARmPUIEHKHtAc=.76a8bf1f-67fd-45ec-8921-8988a8f6890a@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
 <GA-7b6Y-vqk3CWV0FAElu_fqYOoP_jARmPUIEHKHtAc=.76a8bf1f-67fd-45ec-8921-8988a8f6890a@github.com>
Message-ID: <GJSN5cHqlSXAiW7ow7rb21prVOu5rZSiTCKL7sKuV5g=.bfe640e3-861b-419c-9842-7b166d4d9a71@github.com>

On Wed, 17 May 2023 17:55:15 GMT, Phil Race <prr at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed comments
>
> src/guide/code-owners.md line 10:
> 
>> 8: * Client
>> 9:   * Client Libs: [`client-libs-dev`](https://mail.openjdk.org/mailman/listinfo/client-libs-dev)
>> 10:   * Project Wakefield: [`wakefield-dev`](https://mail.openjdk.org/mailman/listinfo/wakefield-dev)
> 
> I'm a bit surprised to see projects like Wakefield and Panama as "areas" .. not sure I understand the logic of including
> these here at all.

Thinking about it I do agree with you. These are in the list because they were sent to me as something that should be on the list. But really, if there's no directory in the list below that refers to the area, then the mailing list doesn't really fit in this list. There are other places to find mailing lists for different projects.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1197147935

From stefank at openjdk.org  Mon May 22 10:28:22 2023
From: stefank at openjdk.org (Stefan Karlsson)
Date: Mon, 22 May 2023 10:28:22 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <2urpPPLn4QI9hiB9Ahi9ozWXmyeeeAt5GlCUaK_kHJ4=.77d45c3b-aeef-44cb-97b5-360c42566906@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
 <-vF2vQz_Qw9xHlYnAy9HF6Q6Am3WDitrsAQHbYzetzA=.c6729f41-9847-4d5a-bfef-79bf555b0b05@github.com>
 <2urpPPLn4QI9hiB9Ahi9ozWXmyeeeAt5GlCUaK_kHJ4=.77d45c3b-aeef-44cb-97b5-360c42566906@github.com>
Message-ID: <avnY5j9cPRDJdvcja1RhdgaE_SPYvJvNbutItO9urEE=.b4025f1a-e330-4fa7-8659-0c642ac1b987@github.com>

On Wed, 17 May 2023 21:55:48 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> src/guide/jbs-jdk-bug-system.md line 205:
>> 
>>> 203:     1. Bugs that do not affect product code, but are only against the regression test: 'noreg-self'
>>> 204:     1. Issues that seem to be trivial to fix: 'starter'
>>> 205:     1. RFEs that are pure cleanups: 'noreg-cleanup'
>> 
>> As I understand it, the noreg- labels are there to indicate the reason why there is *no reg*ression test. So, pure cleanups are typically labeled with 'cleanup' and 'noreg-cleanup' is later used by SQE to note why there's no regression test for the pushed change.
>
> This is correct, but it's not only SQE that are allowed to set the noreg labels on issues. In triage we frequently set noreg-self on any test issues for instance. So I think it is fine for this text to recommend setting noreg-cleanup. Actually we probably could get rid of the cleanup label and only use noreg-cleanup.

I still think it is odd to recommend noreg-cleanup for cleanups instead of the better-named 'cleanup' label.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1200317189

From stefank at openjdk.org  Mon May 22 10:33:20 2023
From: stefank at openjdk.org (Stefan Karlsson)
Date: Mon, 22 May 2023 10:33:20 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <k4n2MyiQR9RwEoJu8iO42ECNK7c4M4_zleexPfyLQr0=.637d0784-1e2a-494d-92ac-880d9d0d7482@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
 <OMAtYfDHVxB_xuyCNXPFyOQty3SvoAGj52g4VQ5MKhQ=.c127cab9-54c7-4503-9eda-c7670a676664@github.com>
 <k4n2MyiQR9RwEoJu8iO42ECNK7c4M4_zleexPfyLQr0=.637d0784-1e2a-494d-92ac-880d9d0d7482@github.com>
Message-ID: <qA0EmNMH6OJXdL4IIeWQRFx_MKoUg-8tjNzyMkUc75A=.af695d9f-da0e-4cbe-af5c-eafd3481c198@github.com>

On Wed, 17 May 2023 20:51:04 GMT, calnan <duke at openjdk.org> wrote:

>> src/guide/jbs-jdk-bug-system.md line 177:
>> 
>>> 175: :::
>>> 176: 
>>> 177: ## Triaging an issue
>> 
>> While reading this section I'm thinking about a common situation. One team performs the initial triage, including moving the issue to the Open state. Later that team realizes that another team should own the bug. If they just move it over to the other team, that team's triage team will not notice that issue while triaging bugs, and the bug goes undetected until much later. Therefore we typically change the state from Open to New when moving bugs across teams.
>
> Correct see line 184:
> If the issue belongs to a different area (it was filed in libraries, but it is an HotSpot issue), transfer it to the correct component/subcomponent making sure that the state remains New.

Right. The difference is that this situation happens *after* the initial triage, which means that the state has already been moved to Open. It's important that the engineer, which often are not part of the triage team, move the bug back to the New state. Maybe it's not worth spelling out this situation explicitly when it can be implied from line 184.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1200321619

From duke at openjdk.org  Mon May 22 14:08:37 2023
From: duke at openjdk.org (calnan)
Date: Mon, 22 May 2023 14:08:37 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <qA0EmNMH6OJXdL4IIeWQRFx_MKoUg-8tjNzyMkUc75A=.af695d9f-da0e-4cbe-af5c-eafd3481c198@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
 <OMAtYfDHVxB_xuyCNXPFyOQty3SvoAGj52g4VQ5MKhQ=.c127cab9-54c7-4503-9eda-c7670a676664@github.com>
 <k4n2MyiQR9RwEoJu8iO42ECNK7c4M4_zleexPfyLQr0=.637d0784-1e2a-494d-92ac-880d9d0d7482@github.com>
 <qA0EmNMH6OJXdL4IIeWQRFx_MKoUg-8tjNzyMkUc75A=.af695d9f-da0e-4cbe-af5c-eafd3481c198@github.com>
Message-ID: <aQsRPS1DWsSfUdMMP76c6eiEa6z-0S0qiCgAFhuWgu0=.d44b4c21-2a07-4e5a-ad85-4b51bcd61bf6@github.com>

On Mon, 22 May 2023 10:30:10 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Correct see line 184:
>> If the issue belongs to a different area (it was filed in libraries, but it is an HotSpot issue), transfer it to the correct component/subcomponent making sure that the state remains New.
>
> Right. The difference is that this situation happens *after* the initial triage, which means that the state has already been moved to Open. It's important that the engineer, which often are not part of the triage team, move the bug back to the New state. Maybe it's not worth spelling out this situation explicitly when it can be implied from line 184.

ok how about on line 227:

Note: if during your investigation of the bug you determine that the issue is in the wrong component, make sure to move it back to the [New]{.jbs-field} state before moving it to the new component so that it will be picked up by the component's Triage team.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1200565191

From stefank at openjdk.org  Mon May 22 14:15:38 2023
From: stefank at openjdk.org (Stefan Karlsson)
Date: Mon, 22 May 2023 14:15:38 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <aQsRPS1DWsSfUdMMP76c6eiEa6z-0S0qiCgAFhuWgu0=.d44b4c21-2a07-4e5a-ad85-4b51bcd61bf6@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
 <OMAtYfDHVxB_xuyCNXPFyOQty3SvoAGj52g4VQ5MKhQ=.c127cab9-54c7-4503-9eda-c7670a676664@github.com>
 <k4n2MyiQR9RwEoJu8iO42ECNK7c4M4_zleexPfyLQr0=.637d0784-1e2a-494d-92ac-880d9d0d7482@github.com>
 <qA0EmNMH6OJXdL4IIeWQRFx_MKoUg-8tjNzyMkUc75A=.af695d9f-da0e-4cbe-af5c-eafd3481c198@github.com>
 <aQsRPS1DWsSfUdMMP76c6eiEa6z-0S0qiCgAFhuWgu0=.d44b4c21-2a07-4e5a-ad85-4b51bcd61bf6@github.com>
Message-ID: <FHfqqpkyRkPjK36a8lRAn6Se0gwIT-ab9U_8vbfU8GI=.957792a7-bfb9-4ca1-95d1-2dd0ba59df7f@github.com>

On Mon, 22 May 2023 14:04:01 GMT, calnan <duke at openjdk.org> wrote:

>> Right. The difference is that this situation happens *after* the initial triage, which means that the state has already been moved to Open. It's important that the engineer, which often are not part of the triage team, move the bug back to the New state. Maybe it's not worth spelling out this situation explicitly when it can be implied from line 184.
>
> ok how about on line 227:
> 
> Note: if during your investigation of the bug you determine that the issue is in the wrong component, make sure to move it back to the [New]{.jbs-field} state before moving it to the new component so that it will be picked up by the component's Triage team.

I think that sounds great. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1200576578

From duke at openjdk.org  Mon May 22 14:22:38 2023
From: duke at openjdk.org (calnan)
Date: Mon, 22 May 2023 14:22:38 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v11]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <CzFTNUYlMAwqSonjVpKb35sweTVHhj_RCHs1jqOVVdQ=.8f2964e4-3284-4d11-a283-5b54b4962750@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  added clarification that if a bug is moved to a new component once it is in the Open state then it should be moved back to the new state.

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/8e44a3ec..55cd481f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=10
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=09-10

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From duke at openjdk.org  Mon May 22 14:30:00 2023
From: duke at openjdk.org (calnan)
Date: Mon, 22 May 2023 14:30:00 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v12]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <uzF4h1aMxmZcPHC3L9-sUBS6nW3t56SX8DaVXEpUzUI=.505b2742-990d-488d-bc02-e3a7dcd59301@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  Cleaned up a few grammar and other mistakes

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/55cd481f..245870b3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=11
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=10-11

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From jwilhelm at openjdk.org  Mon May 22 20:08:16 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Mon, 22 May 2023 20:08:16 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <avnY5j9cPRDJdvcja1RhdgaE_SPYvJvNbutItO9urEE=.b4025f1a-e330-4fa7-8659-0c642ac1b987@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
 <-vF2vQz_Qw9xHlYnAy9HF6Q6Am3WDitrsAQHbYzetzA=.c6729f41-9847-4d5a-bfef-79bf555b0b05@github.com>
 <2urpPPLn4QI9hiB9Ahi9ozWXmyeeeAt5GlCUaK_kHJ4=.77d45c3b-aeef-44cb-97b5-360c42566906@github.com>
 <avnY5j9cPRDJdvcja1RhdgaE_SPYvJvNbutItO9urEE=.b4025f1a-e330-4fa7-8659-0c642ac1b987@github.com>
Message-ID: <GQ2QBg3jF2-zyu9cXi5B7BmmiPGRkTgyprVF0SV9wyI=.f5aee91d-e3a0-44e4-b697-2a5be3765d32@github.com>

On Mon, 22 May 2023 10:25:40 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> This is correct, but it's not only SQE that are allowed to set the noreg labels on issues. In triage we frequently set noreg-self on any test issues for instance. So I think it is fine for this text to recommend setting noreg-cleanup. Actually we probably could get rid of the cleanup label and only use noreg-cleanup.
>
> I still think it is odd to recommend noreg-cleanup for cleanups instead of the better-named 'cleanup' label.

I agree that "cleanup" is a more approachable name, but we will need the noreg-labels on any fix that doesn't come with a regression test which basically means that all cleanup fixes would have both labels. That seems a bit redundant to me.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1200995852

From jwilhelm at openjdk.org  Tue May 23 19:56:23 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 23 May 2023 19:56:23 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <GQ2QBg3jF2-zyu9cXi5B7BmmiPGRkTgyprVF0SV9wyI=.f5aee91d-e3a0-44e4-b697-2a5be3765d32@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
 <-vF2vQz_Qw9xHlYnAy9HF6Q6Am3WDitrsAQHbYzetzA=.c6729f41-9847-4d5a-bfef-79bf555b0b05@github.com>
 <2urpPPLn4QI9hiB9Ahi9ozWXmyeeeAt5GlCUaK_kHJ4=.77d45c3b-aeef-44cb-97b5-360c42566906@github.com>
 <avnY5j9cPRDJdvcja1RhdgaE_SPYvJvNbutItO9urEE=.b4025f1a-e330-4fa7-8659-0c642ac1b987@github.com>
 <GQ2QBg3jF2-zyu9cXi5B7BmmiPGRkTgyprVF0SV9wyI=.f5aee91d-e3a0-44e4-b697-2a5be3765d32@github.com>
Message-ID: <EDeDCam2EX2mZAImxbzsBS9S97bf02oZivdMANI5BrI=.678407dd-f654-4a9d-b212-5a5f5e9ba3c0@github.com>

On Mon, 22 May 2023 20:05:10 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> I still think it is odd to recommend noreg-cleanup for cleanups instead of the better-named 'cleanup' label.
>
> I agree that "cleanup" is a more approachable name, but we will need the noreg-labels on any fix that doesn't come with a regression test which basically means that all cleanup fixes would have both labels. That seems a bit redundant to me.

After some discussions and looking at some actual issues we can see that some cleanups actually do have regression tests which means that both labels are needed, and in many cases it would be premature to put noreg-cleanup on cleanup issues already at triage time. The text here should say 'cleanup' as Stefan indicated in his first comment. Thank you Stefan for highlighting this!

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1202921660

From jwilhelm at openjdk.org  Tue May 23 21:56:18 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 23 May 2023 21:56:18 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <Tp3QUvavpfHJhzHRBYocNhoWZrDeAi8DxVLYunt3RSQ=.9d1ff0e4-80e8-4743-ae17-7bfb9bae981c@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
 <Tp3QUvavpfHJhzHRBYocNhoWZrDeAi8DxVLYunt3RSQ=.9d1ff0e4-80e8-4743-ae17-7bfb9bae981c@github.com>
Message-ID: <nDSloC0YIUCQ7VRHPCd7V4w5AIRUD5tjWkJ9sxNyozA=.a4d75807-356a-4c11-bfb5-7ab67a8f4a64@github.com>

On Wed, 17 May 2023 20:49:18 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed comments
>
> src/guide/code-owners.md line 70:
> 
>> 68: * `java.base`
>> 69:   * Core Libs should almost always be included but Java Language, HotSpot, Security and/or I18n may also be involved.
>> 70:   * `classes`
> 
> Why isn't the `share` directory included here as in `hotspot`? Are these supposed to be full path names? It seems we should be consistent.

The `share` directory was excluded in `java.base` because the other directories next to `share` (`linux`, `aix` etc) all have the same directory structure in them as `share`, and all those directories with the same names are owned by the same area. We could perhaps add a `*` to show this more clearly?

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1203062119

From jwilhelm at openjdk.org  Tue May 23 22:21:20 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 23 May 2023 22:21:20 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <Tp3QUvavpfHJhzHRBYocNhoWZrDeAi8DxVLYunt3RSQ=.9d1ff0e4-80e8-4743-ae17-7bfb9bae981c@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
 <Tp3QUvavpfHJhzHRBYocNhoWZrDeAi8DxVLYunt3RSQ=.9d1ff0e4-80e8-4743-ae17-7bfb9bae981c@github.com>
Message-ID: <0AltCwzjEyIEv7QtcBHv-Bpm5xYADshfazDU6JQkpTs=.23d5d9c1-ac0f-4cf9-ad0d-b8d550cb70e5@github.com>

On Wed, 17 May 2023 20:52:02 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed comments
>
> src/guide/code-owners.md line 99:
> 
>> 97:     * `invoke` ? Core Libs
>> 98:     * `io` ? NIO
>> 99:     * `java`
> 
> Missing `security` and several other directories under `java`.

All the missing directories are because there are many paths with the same leaf directory, e.g:
src/java.base/unix/classes/sun/security
src/java.base/macosx/classes/apple/security
src/java.base/windows/classes/sun/security
src/java.base/windows/lib/security
src/java.base/share/classes/sun/security
src/java.base/share/classes/java/security
src/java.base/share/classes/javax/security
src/java.base/share/classes/com/sun/security
src/java.base/share/lib/security
src/java.base/share/conf/security

All of these belongs to the same area and the directory list would become huge if we include them all. Again, maybe some `*` could be used to show that the single entry refer to them all..? Suggestions welcome :-)

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1203088515

From jwilhelm at openjdk.org  Tue May 23 22:53:22 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 23 May 2023 22:53:22 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <Tp3QUvavpfHJhzHRBYocNhoWZrDeAi8DxVLYunt3RSQ=.9d1ff0e4-80e8-4743-ae17-7bfb9bae981c@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
 <Tp3QUvavpfHJhzHRBYocNhoWZrDeAi8DxVLYunt3RSQ=.9d1ff0e4-80e8-4743-ae17-7bfb9bae981c@github.com>
Message-ID: <SpYBEdM0NIOcJxJHqP4xfoQxKzMG-XhaEfDhSynoQlI=.a74992b1-6ee8-423b-a28b-6450b011655a@github.com>

On Wed, 17 May 2023 20:50:04 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed comments
>
> src/guide/code-owners.md line 72:
> 
>> 70:   * `classes`
>> 71:     * `crypto` ? Security
>> 72:     * `internal`
> 
> Should this be `jdk/internal`?

Fixed.

> src/guide/code-owners.md line 185:
> 
>> 183: * `jdk.internal.vm.compiler` ? Compiler
>> 184: * `jdk.internal.vm.compiler.management` ? Compiler
>> 185: * `jdk.jartool` ? JDK Tools
> 
> and Security because this includes `jarsigner`.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1203116908
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1203117278

From jwilhelm at openjdk.org  Tue May 23 22:53:21 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 23 May 2023 22:53:21 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v3]
In-Reply-To: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
Message-ID: <yW1sSwJDVKPEJvEWZu9xtka8tKyL2gXYxlnubk7D454=.db9ca16b-1c94-4e69-938d-6c47b193e0a0@github.com>

> This should be done after each release to make sure the list is kept up to date.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Updated based on feedback

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/103/files
  - new: https://git.openjdk.org/guide/pull/103/files/d33cceb7..d0838ad9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=103&range=02
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=103&range=01-02

  Stats: 358 lines in 1 file changed: 170 ins; 183 del; 5 mod
  Patch: https://git.openjdk.org/guide/pull/103.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/103/head:pull/103

PR: https://git.openjdk.org/guide/pull/103

From jwilhelm at openjdk.org  Tue May 23 22:54:22 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Tue, 23 May 2023 22:54:22 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
Message-ID: <b6eSS6AlBTiUQu8zqFTmLKZ7tQXlVBBZ6qJ4CmdjkB0=.ddb42553-be73-4040-ad0e-8924a27a9550@github.com>

On Wed, 17 May 2023 17:03:33 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> This should be done after each release to make sure the list is kept up to date.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed comments

@seanjmullan Thank you for reviewing!  I have updated the list with `*` in various places to make it more clear that the same directory may appear in several places. Let me know if this is better.

Also thanks to @prrace for your review!

-------------

PR Comment: https://git.openjdk.org/guide/pull/103#issuecomment-1560226798

From iris at openjdk.org  Wed May 24 01:09:20 2023
From: iris at openjdk.org (Iris Clark)
Date: Wed, 24 May 2023 01:09:20 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v3]
In-Reply-To: <yW1sSwJDVKPEJvEWZu9xtka8tKyL2gXYxlnubk7D454=.db9ca16b-1c94-4e69-938d-6c47b193e0a0@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <yW1sSwJDVKPEJvEWZu9xtka8tKyL2gXYxlnubk7D454=.db9ca16b-1c94-4e69-938d-6c47b193e0a0@github.com>
Message-ID: <xvKA9PCowmE4e6TaappOM6HCVxYbvcgJmpWwWpPFoo0=.9734ce05-16b2-43f6-a1ee-b4ed30d6a976@github.com>

On Tue, 23 May 2023 22:53:21 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> This should be done after each release to make sure the list is kept up to date.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated based on feedback

Marked as reviewed by iris (Reviewer).

src/guide/code-owners.md line 174:

> 172:   * `jdk.internal.vm.compiler` ? Compiler
> 173:   * `jdk.internal.vm.compiler.management` ? Compiler
> 174:   * `jdk.jartool` ? Generic List, Security

jartool (and APIs defined in `java.util.jar`) are both discussed/reviewed in Core Libs

-------------

PR Review: https://git.openjdk.org/guide/pull/103#pullrequestreview-1440791825
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1203257076

From jwilhelm at openjdk.org  Wed May 24 15:56:41 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 24 May 2023 15:56:41 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v4]
In-Reply-To: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
Message-ID: <Yg423AGd-rY_QbRxum1x_p2TaABXQ9yLR1do84a5awo=.9a510487-f9f8-462d-be61-c3d7280d39b6@github.com>

> This should be done after each release to make sure the list is kept up to date.

Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:

  Misplaced utils

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/103/files
  - new: https://git.openjdk.org/guide/pull/103/files/d0838ad9..f8aa6641

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=103&range=03
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=103&range=02-03

  Stats: 9 lines in 1 file changed: 2 ins; 2 del; 5 mod
  Patch: https://git.openjdk.org/guide/pull/103.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/103/head:pull/103

PR: https://git.openjdk.org/guide/pull/103

From duke at openjdk.org  Wed May 24 18:31:03 2023
From: duke at openjdk.org (calnan)
Date: Wed, 24 May 2023 18:31:03 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v13]
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <1NiegmjdulyDhgCtxKg5nOIKD6jRAGY3mji84UU8eD0=.41424d9f-bdc0-4245-8e49-52dbbc24364b@github.com>

> Added overview on triaging issues, the bug states and process.

calnan has updated the pull request incrementally with one additional commit since the last revision:

  changed label from 'cleanup' vs. 'noreg-cleanup'

-------------

Changes:
  - all: https://git.openjdk.org/guide/pull/100/files
  - new: https://git.openjdk.org/guide/pull/100/files/245870b3..eac0f510

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=guide&pr=100&range=12
 - incr: https://webrevs.openjdk.org/?repo=guide&pr=100&range=11-12

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/100.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/100/head:pull/100

PR: https://git.openjdk.org/guide/pull/100

From duke at openjdk.org  Wed May 24 18:31:05 2023
From: duke at openjdk.org (calnan)
Date: Wed, 24 May 2023 18:31:05 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v9]
In-Reply-To: <EDeDCam2EX2mZAImxbzsBS9S97bf02oZivdMANI5BrI=.678407dd-f654-4a9d-b212-5a5f5e9ba3c0@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <hjtoHmh978W5WKZ5063pgmPGnp2YE75z0qi-MdTdnEE=.5bf9f912-51b2-45f2-a413-0305e7ac299e@github.com>
 <-vF2vQz_Qw9xHlYnAy9HF6Q6Am3WDitrsAQHbYzetzA=.c6729f41-9847-4d5a-bfef-79bf555b0b05@github.com>
 <2urpPPLn4QI9hiB9Ahi9ozWXmyeeeAt5GlCUaK_kHJ4=.77d45c3b-aeef-44cb-97b5-360c42566906@github.com>
 <avnY5j9cPRDJdvcja1RhdgaE_SPYvJvNbutItO9urEE=.b4025f1a-e330-4fa7-8659-0c642ac1b987@github.com>
 <GQ2QBg3jF2-zyu9cXi5B7BmmiPGRkTgyprVF0SV9wyI=.f5aee91d-e3a0-44e4-b697-2a5be3765d32@github.com>
 <EDeDCam2EX2mZAImxbzsBS9S97bf02oZivdMANI5BrI=.678407dd-f654-4a9d-b212-5a5f5e9ba3c0@github.com>
Message-ID: <fKJmAIV_daS5N_Bg_6hhJ4p1I7YTAXbyDVJLHQ6EXpk=.0a893aa6-6d9c-468d-8687-438fa0003e13@github.com>

On Tue, 23 May 2023 19:53:44 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> I agree that "cleanup" is a more approachable name, but we will need the noreg-labels on any fix that doesn't come with a regression test which basically means that all cleanup fixes would have both labels. That seems a bit redundant to me.
>
> After some discussions and looking at some actual issues we can see that some cleanups actually do have regression tests which means that both labels are needed, and in many cases it would be premature to put noreg-cleanup on cleanup issues already at triage time. The text here should say 'cleanup' as Stefan indicated in his first comment. Thank you Stefan for highlighting this!

updated

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1204606693

From duke at openjdk.org  Thu May 25 19:08:27 2023
From: duke at openjdk.org (calnan)
Date: Thu, 25 May 2023 19:08:27 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v8]
In-Reply-To: <mZeycPM4XX6MAzPaBEdB_NQmqTbIdGrc-PDwViIcUOU=.fa997ab8-1725-4042-912b-f3a35272dbb2@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <btdrKgJQegsbJIU0p4wB-gHIf43SPRfwiL6loMmmYeU=.da3722a8-fe3e-470d-8090-b539ce674502@github.com>
 <mZeycPM4XX6MAzPaBEdB_NQmqTbIdGrc-PDwViIcUOU=.fa997ab8-1725-4042-912b-f3a35272dbb2@github.com>
Message-ID: <PZ-uqyAoSQu4-ALliejEfx-Ox47Hdwe61B6I9abjA28=.21b2b5b8-68c1-4e9f-bff4-ad3fa1c94c5b@github.com>

On Wed, 17 May 2023 01:15:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> calnan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Adjusted the wording on setting the priority
>>  - Updates to address additional comments
>
> src/guide/jbs-jdk-bug-system.md line 55:
> 
>> 53: 
>> 54: * If you suspect that the issue is a vulnerability, **don't file a JBS issue**, instead send your report to [vuln-report at openjdk.org](mailto:vuln-report at openjdk.org), also use this alias if you find an existing report which may be a vulnerability. Please do *not* report or discuss potential vulnerabilities on any open lists or other public channels - see [OpenJDK Vulnerabilities](https://openjdk.org/groups/vulnerability/report) for more information.
>> 55: * a [Bug]{.jbs} or [Enhancement]{.jbs-field} should only be used if the work is expected to result in a change in a code repository. A [Bug]{.jbs-field} or [Enhancement]{.jbs-field} with resolution Fixed is required to have a corresponding changeset in one of the OpenJDK repositories.
> 
> Sentence should start with capital A

fixed

-------------

PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1205907539

From jwilhelm at openjdk.org  Thu May 25 19:31:32 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 25 May 2023 19:31:32 GMT
Subject: RFR: Updates to the JBS section of the OpenJDK Dev Guide [v13]
In-Reply-To: <1NiegmjdulyDhgCtxKg5nOIKD6jRAGY3mji84UU8eD0=.41424d9f-bdc0-4245-8e49-52dbbc24364b@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
 <1NiegmjdulyDhgCtxKg5nOIKD6jRAGY3mji84UU8eD0=.41424d9f-bdc0-4245-8e49-52dbbc24364b@github.com>
Message-ID: <LupI7vAk4s3uqkYjtu_azwZaa9uCrEfV0NBHw6yimWE=.b9d3f6c3-6822-4f62-a826-6293b1d369f4@github.com>

On Wed, 24 May 2023 18:31:03 GMT, calnan <duke at openjdk.org> wrote:

>> Added overview on triaging issues, the bug states and process.
>
> calnan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changed label from 'cleanup' vs. 'noreg-cleanup'

Marked as reviewed by jwilhelm (Lead).

-------------

PR Review: https://git.openjdk.org/guide/pull/100#pullrequestreview-1444528732

From duke at openjdk.org  Thu May 25 19:39:29 2023
From: duke at openjdk.org (calnan)
Date: Thu, 25 May 2023 19:39:29 GMT
Subject: Integrated: Updates to the JBS section of the OpenJDK Dev Guide
In-Reply-To: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
References: <9Ucm8lqrtEdVFEOur4lhLLCDUuFTOjI1_rsRdn5SziY=.e936ef9b-d64b-4142-bb7b-e3ae079f99fb@github.com>
Message-ID: <jXp_ud0Ujgyai_D_FdcKAnjbB5fHnZZAVmvX_lAWumo=.9f6173ef-bb82-4239-a738-e1a868a6b68e@github.com>

On Tue, 14 Mar 2023 17:56:18 GMT, calnan <duke at openjdk.org> wrote:

> Added overview on triaging issues, the bug states and process.

This pull request has now been integrated.

Changeset: 04eb46b8
Author:    roger_calnan <roger.calnan at oracle.com>
Committer: Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/04eb46b8f8f15695161597af444e19eb44babd36
Stats:     320 lines in 1 file changed: 279 ins; 23 del; 18 mod

Updates to the JBS section of the OpenJDK Dev Guide

Reviewed-by: jwilhelm

-------------

PR: https://git.openjdk.org/guide/pull/100

From duke at openjdk.org  Thu May 25 21:23:40 2023
From: duke at openjdk.org (calnan)
Date: Thu, 25 May 2023 21:23:40 GMT
Subject: Integrated: extra spaces in quick links section causing problems
Message-ID: <lHZOeWHmLDY9e9InzcF195QrhuUD55eCE1UXk8mJ2ms=.5211563c-169d-4c2e-a19a-91caabc24875@github.com>

inadvertent spaces cause the quick links section in the JBS chapter cause it not to display correctly

-------------

Commit messages:
 - extra spaces in quick links section causing problems

Changes: https://git.openjdk.org/guide/pull/104/files
 Webrev: https://webrevs.openjdk.org/?repo=guide&pr=104&range=00
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/guide/pull/104.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/104/head:pull/104

PR: https://git.openjdk.org/guide/pull/104

From jwilhelm at openjdk.org  Thu May 25 21:23:42 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Thu, 25 May 2023 21:23:42 GMT
Subject: Integrated: extra spaces in quick links section causing problems
In-Reply-To: <lHZOeWHmLDY9e9InzcF195QrhuUD55eCE1UXk8mJ2ms=.5211563c-169d-4c2e-a19a-91caabc24875@github.com>
References: <lHZOeWHmLDY9e9InzcF195QrhuUD55eCE1UXk8mJ2ms=.5211563c-169d-4c2e-a19a-91caabc24875@github.com>
Message-ID: <5TFcf2MYz_0aWNyWu4_NvtD_ckmtUHgHa3z3qJ7OxMY=.a376495f-ba4e-407a-9cdc-e3dae419077a@github.com>

On Thu, 25 May 2023 21:15:04 GMT, calnan <duke at openjdk.org> wrote:

> inadvertent spaces cause the quick links section in the JBS chapter cause it not to display correctly

Marked as reviewed by jwilhelm (Lead).

-------------

PR Review: https://git.openjdk.org/guide/pull/104#pullrequestreview-1444662352

From duke at openjdk.org  Thu May 25 21:23:42 2023
From: duke at openjdk.org (calnan)
Date: Thu, 25 May 2023 21:23:42 GMT
Subject: Integrated: extra spaces in quick links section causing problems
In-Reply-To: <lHZOeWHmLDY9e9InzcF195QrhuUD55eCE1UXk8mJ2ms=.5211563c-169d-4c2e-a19a-91caabc24875@github.com>
References: <lHZOeWHmLDY9e9InzcF195QrhuUD55eCE1UXk8mJ2ms=.5211563c-169d-4c2e-a19a-91caabc24875@github.com>
Message-ID: <yTAGQLx2_lCUMraQfFO5dgbO0PIeuLU9phg-qZ5IRZ4=.18aad07a-87f7-4bae-aef7-4484684856f3@github.com>

On Thu, 25 May 2023 21:15:04 GMT, calnan <duke at openjdk.org> wrote:

> inadvertent spaces cause the quick links section in the JBS chapter cause it not to display correctly

This pull request has now been integrated.

Changeset: 96f91a26
Author:    roger_calnan <roger.calnan at oracle.com>
Committer: Jesper Wilhelmsson <jwilhelm at openjdk.org>
URL:       https://git.openjdk.org/guide/commit/96f91a268480e0511b203dd54e477adf0cdb3c49
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

extra spaces in quick links section causing problems

Reviewed-by: jwilhelm

-------------

PR: https://git.openjdk.org/guide/pull/104

From mullan at openjdk.org  Fri May 26 13:56:20 2023
From: mullan at openjdk.org (Sean Mullan)
Date: Fri, 26 May 2023 13:56:20 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v4]
In-Reply-To: <Yg423AGd-rY_QbRxum1x_p2TaABXQ9yLR1do84a5awo=.9a510487-f9f8-462d-be61-c3d7280d39b6@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <Yg423AGd-rY_QbRxum1x_p2TaABXQ9yLR1do84a5awo=.9a510487-f9f8-462d-be61-c3d7280d39b6@github.com>
Message-ID: <9mAe5aanWNanT-PV3B6j83L2fBVFGn0FImasJfV140w=.bb8a1621-a23c-45d6-a064-896bffc05f32@github.com>

On Wed, 24 May 2023 15:56:41 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

>> This should be done after each release to make sure the list is kept up to date.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Misplaced utils

Marked as reviewed by mullan (no project role).

-------------

PR Review: https://git.openjdk.org/guide/pull/103#pullrequestreview-1446287926

From mullan at openjdk.org  Fri May 26 13:56:20 2023
From: mullan at openjdk.org (Sean Mullan)
Date: Fri, 26 May 2023 13:56:20 GMT
Subject: RFR: Updated Code Owners for JDK 20 [v2]
In-Reply-To: <b6eSS6AlBTiUQu8zqFTmLKZ7tQXlVBBZ6qJ4CmdjkB0=.ddb42553-be73-4040-ad0e-8924a27a9550@github.com>
References: <dh10DltSW6Omfjr3-R_n0kUTkiXTNjLXb7lRKCipEPU=.37fea8a7-10cf-47dc-9e28-5c7158b47784@github.com>
 <W7_o_k_EeIN92huvr-XJwO7OIC6zSxqOYBsJ-Xitxd8=.bb78d1db-01c1-4e8f-8a82-9ee56f7ac444@github.com>
 <b6eSS6AlBTiUQu8zqFTmLKZ7tQXlVBBZ6qJ4CmdjkB0=.ddb42553-be73-4040-ad0e-8924a27a9550@github.com>
Message-ID: <NXInoLsRtXZjamuETNTLGycoZdFMYUlVEV6BvEZRjR4=.b72746a8-0efa-4ba8-b8c2-91131610ad86@github.com>

On Tue, 23 May 2023 22:51:42 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:

> @seanjmullan Thank you for reviewing! I have updated the list with `*` in various places to make it more clear that the same directory may appear in several places. Let me know if this is better.

Yes, this looks much better and more clear. Thanks!

-------------

PR Comment: https://git.openjdk.org/guide/pull/103#issuecomment-1564428710

From ehelin at openjdk.org  Wed May 31 18:39:08 2023
From: ehelin at openjdk.org (Erik Helin)
Date: Wed, 31 May 2023 18:39:08 GMT
Subject: RFR: Using backports for stabilization repositories
Message-ID: <8_DIzdBDwXda2cFya-ygFX9JE-UZA4UbjOoMNinUwRE=.e365bda0-d9fe-4cef-825c-17d29de20fa8@github.com>

Hi all,

please review this patch that replaces the documentation on the "forward ports" process with the [recently adopted](https://mail.openjdk.org/pipermail/jdk-dev/2023-May/007889.html) "backports" process. The changes are fairly small since the guide already contains great documentation on backports, I just had to adopt it slightly to also cover stabilization repositories.

Thanks!
Erik

-------------

Commit messages:
 - Using backports for stabilization repositories

Changes: https://git.openjdk.org/guide/pull/105/files
 Webrev: https://webrevs.openjdk.org/?repo=guide&pr=105&range=00
  Stats: 19 lines in 2 files changed: 0 ins; 15 del; 4 mod
  Patch: https://git.openjdk.org/guide/pull/105.diff
  Fetch: git fetch https://git.openjdk.org/guide.git pull/105/head:pull/105

PR: https://git.openjdk.org/guide/pull/105

From jwilhelm at openjdk.org  Wed May 31 19:11:42 2023
From: jwilhelm at openjdk.org (Jesper Wilhelmsson)
Date: Wed, 31 May 2023 19:11:42 GMT
Subject: RFR: Using backports for stabilization repositories
In-Reply-To: <8_DIzdBDwXda2cFya-ygFX9JE-UZA4UbjOoMNinUwRE=.e365bda0-d9fe-4cef-825c-17d29de20fa8@github.com>
References: <8_DIzdBDwXda2cFya-ygFX9JE-UZA4UbjOoMNinUwRE=.e365bda0-d9fe-4cef-825c-17d29de20fa8@github.com>
Message-ID: <Bkyfl17WwbVBj6WCJlOEzd6VoHyKl8d33SIVdMySxmk=.4d373321-e7f0-473d-add5-990b68a2895a@github.com>

On Wed, 31 May 2023 18:34:03 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that replaces the documentation on the "forward ports" process with the [recently adopted](https://mail.openjdk.org/pipermail/jdk-dev/2023-May/007889.html) "backports" process. The changes are fairly small since the guide already contains great documentation on backports, I just had to adopt it slightly to also cover stabilization repositories.
> 
> Thanks!
> Erik

Thank you for updating the guide with respect to the new policy! A few comments below.

src/guide/backporting.md line 12:

> 10: Development of the latest version of the JDK often results in bug fixes that might be interesting to include in some of the JDK update releases still being maintained or in a [release stabilization repository](https://openjdk.org/guide/#backporting-to-release-stabilization-fork). Moving a fix from a more recent release train (e.g. JDK 17) to an older release train (e.g. JDK 11) is called *backporting*.
> 11: 
> 12: The guideline for what to backport into a specific release will vary over the lifetime of that release. Initially more fixes are expected to be backported as new features and large changes introduced in a mainline release stabilize. Over time the focus will shift from stabilization to keeping it stable - the release will go into maintenance mode. This means that bug fixes that require larger disruptive changes are more likely to be made in mainline and backported to more recent release trains only, and not to older release trains. Release stabilization repositories (e.g. [jdk20](https://git.openjdk.org/jdk20)) follows the process described in [JEP 3](https://openjdk.org/jeps/3) for deciding the bug fixes that should be backported.

JEP 3 only sets the limits of what may and may not be included during rampdown, it doesn't give any hints of how to decide if a particular bugfix should be included. The developer of a fix will still need to decide if the change should go into the stabilization repo or not.

src/guide/the-jdk-release-process.md line 53:

> 51: Please note that the priority of a bug doesn't change just because you want to get your fix in late in the release, or if you want to be able to defer it. The priority is based on the severity of the bug and if it was deemed to be a P2 before, you better have a really good explanation to why that conveniently has changed by the end of the release. Being hard to fix is **not** a reason to lower the priority of a bug.
> 52: 
> 53: ## Backporting to release stabilization repository

This section is now unrelated to the particulars of the JDK release process and should be moved to the Backporting chapter instead. I suggest to place it after the section about working with Skara tooling.
Please add "a" (...to a release...) in the title.

src/guide/the-jdk-release-process.md line 55:

> 53: ## Backporting to release stabilization repository
> 54: 
> 55: During the rampdown of a release there are two repositories in play, the release stabilization repository for the outgoing release, and the mainline repository where the next release is being developed. Any bugfix going into the release stabilization repository is likely to be desired in mainline as well. As a developer you should always create a pull request targeting the mainline repository first and then, once the pull request is integrated, [backport](https://openjdk.org/guide/#backporting) the resulting commit to the release stabilization repository. For bugfixes that are **only** applicable to the release stablization repository, regular pull requests targeting the stabilization fork should be created.

The last sentence "For bugfixes that..." is unrelated to backporting and can be removed. I'm not sure if there is some other place to put such a note, but I don't think it needs to be explicitly mentioned. This is the same for any release repository (e.g. update releases - if a fix is needed in JDK 17u only it's integrated only there).

-------------

PR Review: https://git.openjdk.org/guide/pull/105#pullrequestreview-1453925826
PR Review Comment: https://git.openjdk.org/guide/pull/105#discussion_r1212183591
PR Review Comment: https://git.openjdk.org/guide/pull/105#discussion_r1212183325
PR Review Comment: https://git.openjdk.org/guide/pull/105#discussion_r1212182997