RFR: Updates to the JBS section of the OpenJDK Dev Guide [v3]
calnan
duke at openjdk.org
Wed May 10 02:51:47 UTC 2023
On Tue, 9 May 2023 02:01:46 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> calnan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updates to address current round of feedback
>
> src/guide/jbs-jdk-bug-system.md line 94:
>
>> 92: To find out which component to use for different bugs, consult the [directory to area mapping](#directory-to-area-mapping).
>> 93:
>> 94: ### Implementing a Large Change
>
> Hmm. I don't think I entirely agree with the guidance here.
>
> I've often used subtasks of a bug/enhancement to break the work into logical pieces (e.g. porting FDLIBM JDK-8171407) or partitioning work along review/maintenance domains (e.g. JDK-8231641: Suppress warnings on non-serializable non-transient instance fields in JDK libraries (umbrella)).
>
> I think such usages work with the features of JBS in terms of allowing an easy estimate of how much of the umbrella bug is left to do and looser connections between the cloud of issues obscures the intent of what is going on.
I believe that the examples you give are covered in the last sentence of that section, you examples are however good examples of where sub-tasks can be used to effect and so have included them as examples in that section
-------------
PR Review Comment: https://git.openjdk.org/guide/pull/100#discussion_r1189302385
More information about the guide-dev
mailing list