RFR: Updated Code Owners for JDK 20
Iris Clark
iris at openjdk.org
Wed May 17 15:58:41 UTC 2023
On Wed, 17 May 2023 15:41:34 GMT, Jesper Wilhelmsson <jwilhelm at openjdk.org> wrote:
> This should be done after each release to make sure the list is kept up to date.
Marked as reviewed by iris (Reviewer).
src/guide/code-owners.md line 84:
> 82: * `loader` – Core Libs
> 83: * `logger` – Core Libs
> 84: * `math` – Java Language
I think `java.math` should be Core Libraries. I could perhaps see the argument that the wrapper classes are very close to the Java Language, but those are in `java.lang`. `java.math` contains the floating-point implementation.
src/guide/code-owners.md line 101:
> 99: * `java`
> 100: * `lang` – Core Libs
> 101: * `math` – Java Language
Same comment as line 84.
src/guide/code-owners.md line 107:
> 105: * `net` – Net
> 106: * `nio` – NIO
> 107: * `reflect` – Java Language
I'm not sure I agree with this change. The reflection code is certainly discussed in core-lang-dev.
src/guide/code-owners.md line 119:
> 117: * `lib/security` – Security
> 118: * `man`
> 119: * `java.1` – JDK Tools
I'd add Hotspot to this list.
-------------
PR Review: https://git.openjdk.org/guide/pull/103#pullrequestreview-1431040545
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196730797
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196734106
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196733781
PR Review Comment: https://git.openjdk.org/guide/pull/103#discussion_r1196736047
More information about the guide-dev
mailing list